From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shahaf Shuler Subject: Re: [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API Date: Wed, 13 Dec 2017 07:21:01 +0000 Message-ID: References: <20171123121419.144132-1-shahafs@mellanox.com> <2601191342CEEE43887BDE71AB9772585FAC8AEB@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: "Ananyev, Konstantin" , "dev@dpdk.org" , "Nicolau, Radu" , "arybchenko@solarflare.com" Return-path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0073.outbound.protection.outlook.com [104.47.0.73]) by dpdk.org (Postfix) with ESMTP id B437A1C00 for ; Wed, 13 Dec 2017 08:21:03 +0100 (CET) In-Reply-To: <2601191342CEEE43887BDE71AB9772585FAC8AEB@irsmsx105.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tuesday, December 12, 2017 7:12 PM, Ananyev, Konstantin: > > -----Original Message----- > > From: Shahaf Shuler [mailto:shahafs@mellanox.com] > > Sent: Tuesday, December 12, 2017 12:26 PM > > To: dev@dpdk.org; Ananyev, Konstantin > ; > > Nicolau, Radu ; arybchenko@solarflare.com > > Subject: [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API > > > > Ethdev offloads API has changed since: > > > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit > > cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > > > This commit support the new API. > > > > Signed-off-by: Shahaf Shuler > > --- > > examples/l3fwd/main.c | 40 ++++++++++++++++++++++++++++++-------- > -- > > 1 file changed, 30 insertions(+), 10 deletions(-) > > > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index > > 6229568..3bdf4d5 100644 > > --- a/examples/l3fwd/main.c > > +++ b/examples/l3fwd/main.c > > @@ -149,11 +149,9 @@ struct lcore_params { > > .mq_mode =3D ETH_MQ_RX_RSS, > > .max_rx_pkt_len =3D ETHER_MAX_LEN, > > .split_hdr_size =3D 0, > > - .header_split =3D 0, /**< Header Split disabled */ > > - .hw_ip_checksum =3D 1, /**< IP checksum offload enabled */ > > - .hw_vlan_filter =3D 0, /**< VLAN filtering disabled */ > > - .jumbo_frame =3D 0, /**< Jumbo Frame Support disabled */ > > - .hw_strip_crc =3D 1, /**< CRC stripped by hardware */ > > + .ignore_offload_bitfield =3D 1, > > + .offloads =3D (DEV_RX_OFFLOAD_CRC_STRIP | > > + DEV_RX_OFFLOAD_CHECKSUM), > > }, > > .rx_adv_conf =3D { > > .rss_conf =3D { > > @@ -163,6 +161,7 @@ struct lcore_params { > > }, > > .txmode =3D { > > .mq_mode =3D ETH_MQ_TX_NONE, > > + .offloads =3D DEV_TX_OFFLOAD_MBUF_FAST_FREE, >=20 > Hmm, does it mean a new warning for all PMDs (majority) which don't > support DEV_TX_OFFLOAD_MBUF_FAST_FREE? Good point. Unlike other offloads which are must for the application proper run, this o= ne it only for optimizing the performance and should be set only if PMD sup= ports.=20 Am continuing to aggregate reasons why the DEV_TX_OFFLOAD_MBUF_FAST_FREE sh= ould not be defined as an offload. Anyway we passed that...=20 I will fix on v3. > Konstantin >=20 > > }, > > }; > > > > @@ -612,7 +611,8 @@ enum { > > }; > > > > printf("%s\n", str8); > > - port_conf.rxmode.jumbo_frame =3D 1; > > + port_conf.rxmode.offloads |=3D > DEV_RX_OFFLOAD_JUMBO_FRAME; > > + port_conf.txmode.offloads |=3D > DEV_TX_OFFLOAD_MULTI_SEGS; > > > > /* > > * if no max-pkt-len set, use the default @@ -908,6 > +908,22 @@ > > enum { > > n_tx_queue =3D MAX_TX_QUEUE_PER_PORT; > > printf("Creating queues: nb_rxq=3D%d nb_txq=3D%u... ", > > nb_rx_queue, (unsigned)n_tx_queue ); > > + > > + rte_eth_dev_info_get(portid, &dev_info); > > + if ((dev_info.rx_offload_capa & port_conf.rxmode.offloads) > !=3D > > + port_conf.rxmode.offloads) { > > + printf("Some Rx offloads are not supported " > > + "by port %d: requested 0x%lx supported > 0x%lx\n", > > + portid, port_conf.rxmode.offloads, > > + dev_info.rx_offload_capa); > > + } > > + if ((dev_info.tx_offload_capa & port_conf.txmode.offloads) > !=3D > > + port_conf.txmode.offloads) { > > + printf("Some Tx offloads are not supported " > > + "by port %d: requested 0x%lx supported > 0x%lx\n", > > + portid, port_conf.txmode.offloads, > > + dev_info.tx_offload_capa); > > + } > > ret =3D rte_eth_dev_configure(portid, nb_rx_queue, > > (uint16_t)n_tx_queue, &port_conf); > > if (ret < 0) > > @@ -955,10 +971,9 @@ enum { > > printf("txq=3D%u,%d,%d ", lcore_id, queueid, > socketid); > > fflush(stdout); > > > > - rte_eth_dev_info_get(portid, &dev_info); > > txconf =3D &dev_info.default_txconf; > > - if (port_conf.rxmode.jumbo_frame) > > - txconf->txq_flags =3D 0; > > + txconf->txq_flags =3D ETH_TXQ_FLAGS_IGNORE; > > + txconf->offloads =3D port_conf.txmode.offloads; > > ret =3D rte_eth_tx_queue_setup(portid, queueid, > nb_txd, > > socketid, txconf); > > if (ret < 0) > > @@ -984,6 +999,8 @@ enum { > > fflush(stdout); > > /* init RX queues */ > > for(queue =3D 0; queue < qconf->n_rx_queue; ++queue) { > > + struct rte_eth_rxconf rxq_conf; > > + > > portid =3D qconf->rx_queue_list[queue].port_id; > > queueid =3D qconf->rx_queue_list[queue].queue_id; > > > > @@ -996,9 +1013,12 @@ enum { > > printf("rxq=3D%d,%d,%d ", portid, queueid, socketid); > > fflush(stdout); > > > > + rte_eth_dev_info_get(portid, &dev_info); > > + rxq_conf =3D dev_info.default_rxconf; > > + rxq_conf.offloads =3D port_conf.rxmode.offloads; > > ret =3D rte_eth_rx_queue_setup(portid, queueid, > nb_rxd, > > socketid, > > - NULL, > > + &rxq_conf, > > pktmbuf_pool[socketid]); > > if (ret < 0) > > rte_exit(EXIT_FAILURE, > > -- > > 1.8.3.1