From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [PATCH v2 05/39] examples/l3fwd: move to ethdev
 offloads API
Date: Thu, 21 Dec 2017 14:26:52 +0000
Message-ID: <VI1PR05MB3149959C43EF4269EDE4515AC30D0@VI1PR05MB3149.eurprd05.prod.outlook.com>
References: <20171123121419.144132-1-shahafs@mellanox.com>
 <cover.1513081087.git.shahafs@mellanox.com>
 <c19854dcdd6724fd96c9cee685181ac429db23bc.1513081087.git.shahafs@mellanox.com>
 <2601191342CEEE43887BDE71AB9772585FAC8AEB@irsmsx105.ger.corp.intel.com>
 <VI1PR05MB3149923F0F925B4356217E34C3350@VI1PR05MB3149.eurprd05.prod.outlook.com>
 <20171213075518.GA18228@jerin>
 <2601191342CEEE43887BDE71AB9772585FAC9140@irsmsx105.ger.corp.intel.com>
 <20171213173203.GA3462@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Nicolau, Radu" <radu.nicolau@intel.com>,
 "arybchenko@solarflare.com" <arybchenko@solarflare.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr60048.outbound.protection.outlook.com [40.107.6.48])
 by dpdk.org (Postfix) with ESMTP id 3732A1B28D
 for <dev@dpdk.org>; Thu, 21 Dec 2017 15:26:53 +0100 (CET)
In-Reply-To: <20171213173203.GA3462@jerin>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Wednesday, December 13, 2017 7:32 PM, Jerin Jacob:
>=20
> OK. I just suggested because adding the flag in PMD is harmless and we ca=
n
> avoid an extra check(setting the DEV_TX_OFFLOAD_MBUF_FAST_FREE only
> when PMD supports it) in application to hide warning as you pointed out.
> No strong opinion on the specifics, I am just cared only reaching the fla=
g to
> driver.

Following some other comments from different examples I believe the way to =
go is the following:=20
1. application will set the offloads it *must have* in order to properly fu=
nction. PMD will fail the configuration if not supported. Such kind of offl=
oads are basically all the offloads besides=20
DEV_TX_OFFLOAD_MBUF_FAST_FREE as it is an optimization.=20
2. application will set optional features only if supported (such as DEV_TX=
_OFFLOAD_MBUF_FAST_FREE)
3. I will remove the redundant print for offloads set but not supported. Th=
is can be done in the PMD level based on its implemented (as I understood s=
ome PMDs don't set some offloads but do expect to have them enabled. This t=
hough should be fixed IMO).=20
>=20
>=20