From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227tYeo/fnKuC/Y/EXPTeUSvgWJ6/FJRuyfrzUb38z/S8M4y7E7WlXcxkFq/KNuHt/K258dt ARC-Seal: i=1; a=rsa-sha256; t=1516813504; cv=none; d=google.com; s=arc-20160816; b=R77dhETcjDUpLQjbvrP879GEv7whwoimI2ywxpylnZuFf0hkd3H/bV8yvBhRA7mBew 2g/odmAtJ0+u941ODM8VrvhEg6cZfVVIVB9PIpRr9skYNw4OgiqhTWMYE4MRIViOhTz3 S+4ficwcX1beqKMfqvs1bx1dQ0Muv5tXQ02SQS9Z1oYMsnjTSbWomyOtPtf9C+s3rTnY 7F+nbqILGX7sOjHtQNTnsaevTxx0Q8mhIA8TesKJydz5woNPDdpDNbWW8PXnVV2Z47jo 05ezcAlQij1KXDJFTgtQoJIJPLdtEusD/OA3l8OeI0ePZ6oRojmkCAnsE9zLKXYJLDon PBjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:spamdiagnosticmetadata :spamdiagnosticoutput:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:dkim-signature:arc-authentication-results; bh=XL1PyY0aCl1CqOszHnQjnt+PU6vMiUFAU+/n5BUtWxM=; b=gDZ22oL7YUhZLh7eFIgJOPxSjtBaJLASdaC4cVARqd9r/juA00gNIV5DMl8zPXbRKX VHfBoPpb6mxiIwbE9vL+ODGY+FG6TRGy2y4R9e95NL1jM/4rKBqFs2UsOA6DDsdLk13e m/XBvqXR9x1sUEUKlnpRfuFBfWhyqh0PVdB87ShQpAB1pPvrj7y54F+8n2ZN3IEeQwNz H2M8mztKsKcY1O2hND/8ew1Fb3PDPXvV24sEbJj8K3u9LAH5P5c/Gdn/JpGWDSEv41AR bOLBe6fRqJDIoABWSKRiMZOHljdExrebLsAd8Yzyy+2+pkA3XlMfvgNjT6oXHyK8JX1s Fwlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector1 header.b=YIJQYkaA; spf=pass (google.com: domain of vadimp@mellanox.com designates 104.47.0.71 as permitted sender) smtp.mailfrom=vadimp@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Authentication-Results: mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector1 header.b=YIJQYkaA; spf=pass (google.com: domain of vadimp@mellanox.com designates 104.47.0.71 as permitted sender) smtp.mailfrom=vadimp@mellanox.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com From: Vadim Pasternak To: Darren Hart CC: "andy.shevchenko@gmail.com" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "jiri@resnulli.us" Subject: RE: [patch v10 4/6] platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface Thread-Topic: [patch v10 4/6] platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface Thread-Index: AQHTlHldkudUE+blp0KEh05WSPjBg6OCElyAgAEfgQA= Date: Wed, 24 Jan 2018 17:05:00 +0000 Message-ID: References: <1516739665-132304-1-git-send-email-vadimp@mellanox.com> <1516739665-132304-4-git-send-email-vadimp@mellanox.com> <20180123225817.GB16464@fury> In-Reply-To: <20180123225817.GB16464@fury> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=vadimp@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR05MB1101;7:9ZBpa6o0tVKEKHNodnRAKgZcnSBAjNYqk+/L84kFhg0uG816Auk1i1w7v81C7Vcxt/RJnJmW9k8z6NUaAu5dR1YC56Lk43SzuWq5WHfnXNgnRMvKKzqOF7wZnSLh0WIFC6OOEjKYWDbKvQhjUC8ZQbky9tro8vuMqehRfyMc6nf+U0gBAzoP1cZ9Gg5owLwGqmoKz8HfwdX8OhtY4ijCj3S08Chjjl3LUH1XySZ/6Oa5ZYMp468usC5cnZZ8YWlj x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d7e7550d-0679-47d3-c6d7-08d5634c9a73 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020);SRVR:VI1PR05MB1101; x-ms-traffictypediagnostic: VI1PR05MB1101: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(166708455590820)(9452136761055)(85827821059158); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231023)(2400081)(944501161)(6055026)(6041288)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011);SRVR:VI1PR05MB1101;BCL:0;PCL:0;RULEID:;SRVR:VI1PR05MB1101; x-forefront-prvs: 056297E276 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(346002)(39380400002)(376002)(366004)(39860400002)(199004)(189003)(13464003)(55016002)(5890100001)(66066001)(26005)(2950100002)(81156014)(6916009)(6246003)(105586002)(7696005)(8676002)(76176011)(5250100002)(4326008)(14454004)(99286004)(6436002)(966005)(9686003)(316002)(86362001)(8936002)(3660700001)(59450400001)(33656002)(53546011)(3846002)(3280700002)(2906002)(305945005)(74316002)(102836004)(6116002)(6306002)(39060400002)(68736007)(5660300001)(106356001)(25786009)(478600001)(2900100001)(7736002)(54906003)(53936002)(6506007)(97736004)(81166006)(229853002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB1101;H:VI1PR05MB3341.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: tzE68v6sgobsDwIwtGJxo9Ousp3LpL1+6bPZBan6NTyfuWis+9DPdSLrgnWOkYpXRX3BtA5Y+EbX6pUSUTT/nw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7e7550d-0679-47d3-c6d7-08d5634c9a73 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2018 17:05:00.1955 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB1101 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590409505885907527?= X-GMAIL-MSGID: =?utf-8?q?1590494236975896653?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: > -----Original Message----- > From: Darren Hart [mailto:dvhart@infradead.org] > Sent: Wednesday, January 24, 2018 12:58 AM > To: Vadim Pasternak > Cc: andy.shevchenko@gmail.com; gregkh@linuxfoundation.org; linux- > kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; jiri@resnull= i.us > Subject: Re: [patch v10 4/6] platform/mellanox: mlxreg-hotplug: Modify to= use a > regmap interface >=20 > On Tue, Jan 23, 2018 at 08:34:23PM +0000, Vadim Pasternak wrote: > > Restructure mlxreg header for unification of hotplug item definitions. > > > > Unify hotplug items to allow any kind of item (power controller, fan > > eeprom, psu eeprom, asic health) in common way. > > > > Use a hardware independent regmap interface, enabling the support of > > hotplug events over programmable devices attached to different bus > > types, such as I2C, LPC, or SPI. Add a device node to the > > mlxreg_core_data structure. > > > > Signed-off-by: Vadim Pasternak > > Acked-by: Andy Shevchenko > > --- > > v10->v9: > > Fixes provided by Vadim: > > - add missed description of pdev_hotplug for struct mlxplat_priv; >=20 > I didn't see this in the diff from my version to this one. >=20 > > - remove struct mlxplat_mlxcpld_regmap_context, which contains only > > the field with base address. Instead obtain locally defined base > > address by devm_ioport_map in mlxplat_init and pass it to > > devm_regmap_init; > > - modify mlxplat_mlxcpld_reg_read/write to use directly pointer to > > context; >=20 > Also adds incorrect conversion of tabs to spaces in at least 3 locations = ... >=20 > I had also corrected various typos and the copyright statement, as well a= s > reworked the commit messages. So at this point, I'd rather see these as c= hanges > on top of what I have cleaned up. >=20 > Please compare what you have here with: > https://github.com/dvhart/linux-pdx86/tree/review-dvhart-mellanox-v10 >=20 > And send me any changes strictly on top of that. Hi Darren, I'll send you four patches on top review-dvhart-mellanox-v10. There are - Patch to simplify IO access to regmap context. - Register map configuration extension with IO access verification callbacks. - Adding check for negative adapter number value in hotplug; - Adding validation of return code of mlxreg_hotplug_device_create. This is instead of what have been removed in "FIXME:" But there were two Kbuild issues with these two patches: [4/9] FIXME platform/mellanox: Remove redundant dev_err messages on device_= create [6/8] platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface This is because of incorrect order of patches: FIXME platform/mellanox uses filed nr which replaces field bus in Rename-i2c-bus-to-nr. 0003-FIXME-platform-mellanox-Remove-redundant-dev_err-mes.patch=20 0004-platform-mellanox-Group-create-destroy-with-attribut.patch 0005-platform-mellanox-Rename-i2c-bus-to-nr.patch So, I'll resend the above three patches marked v11 "re-ordered". If it's not good I'll redo it according to your input. >=20 > Are you anticipating any additional changes beyond those in this version? >=20 Additionally, after we are done with this series, I'd like to add: - several new systems to mlx-platform; - new module to mellanox folder with sysfs access to some special registers= , like resets and reset causes registers (mlxreg-io); - make configuration and activation of mlxreg-io in mlx-patfrom; And later, after I am done with upstream work with leds-mlxreg driver, I'd like to add configuration and activation of this driver in mlx-patform as w= ell. Thanks, Vadim. > -- > Darren Hart > VMware Open Source Technology Center