Re: [PATCH v2 3/3] app/testpmd: add debug command Tx metadata set

[Dekel Peled <dekelp@mellanox.com>]

Thanks, PSB.

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Friday, October 5, 2018 4:20 PM
> To: Dekel Peled <dekelp@mellanox.com>; wenzhuo.lu@intel.com;
> jingjing.wu@intel.com; bernard.iremonger@intel.com; dev@dpdk.org;
> olivier.matz@6wind.com; Adrien Mazarguil <adrien.mazarguil@6wind.com>;
> Thomas Monjalon <thomas@monjalon.net>; arybchenko@solarflare.com
> Cc: Shahaf Shuler <shahafs@mellanox.com>; Ori Kam
> <orika@mellanox.com>
> Subject: Re: [PATCH v2 3/3] app/testpmd: add debug command Tx metadata
> set
> 
> On 9/16/2018 3:37 PM, Dekel Peled wrote:
> > As described in [1],[2] this series adds option to set metadata value
> > as match pattern when creating a new flow rule.
> >
> > This patch introduces code for debug porpuse only.
> > The new debug command takes a 32 bit value and stores it per port.
> > testpmd will add to any Tx packet sent from this port the metadata
> > value, and set ol_flags accordingly.
> >
> > [1] "ethdev: support metadata as flow rule criteria"
> > [2] "app/testpmd: support metadata as flow rule criteria"
> >
> > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> 
> <...>
> 
> > @@ -851,6 +851,13 @@ Disable hardware insertion of a VLAN header in
> packets sent on a port::
> >
> >     testpmd> tx_vlan reset (port_id)
> >
> > +tx_metadata set
> > +~~~~~~~~~~~~~~~
> > +
> > +Set metadata value to insert in packets sent to PMD::
> > +
> > +   testpmd> tx_metadata set (port_id) (value)
> 
> My usual testpmd grunting:
> 
> Everybody is adding a high level command to testpmd, with own syntax and
> in the scope of a specific feature, that nobody else knows about, it makes
> testpmd confusing/hard to use.
> If this is a command to set a port feature, why not extend existing, "port
> config <port_id> ..."
> 
> Like "port config <port_id> tx_metadata <value>" ?
> 
> 
> And second, I think it is good to have a set & show as pairs, this function sets
> the "tx_metadata", is there a way to display existing "tx_metadata"? If not,
> what about: "show port <port_id> tx_metadata"?

OK, will implement as suggested.