From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dekel Peled Subject: Re: [PATCH v5 2/3] app/testpmd: support metadata as flow rule item Date: Sun, 21 Oct 2018 13:49:30 +0000 Message-ID: References: <1539254998-8555-1-git-send-email-dekelp@mellanox.com> <1539777829-64412-3-git-send-email-dekelp@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Shahaf Shuler , "dev@dpdk.org" To: Ori Kam , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" , "olivier.matz@6wind.com" , Adrien Mazarguil , Thomas Monjalon , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" Return-path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50061.outbound.protection.outlook.com [40.107.5.61]) by dpdk.org (Postfix) with ESMTP id 90A424C92 for ; Sun, 21 Oct 2018 15:49:32 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks, PSB. > -----Original Message----- > From: Ori Kam > Sent: Thursday, October 18, 2018 3:26 PM > To: Dekel Peled ; wenzhuo.lu@intel.com; > jingjing.wu@intel.com; bernard.iremonger@intel.com; > olivier.matz@6wind.com; Adrien Mazarguil ; > Thomas Monjalon ; ferruh.yigit@intel.com; > arybchenko@solarflare.com > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v5 2/3] app/testpmd: support metadata as > flow rule item >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Dekel Peled > > Sent: Wednesday, October 17, 2018 3:04 PM > > To: wenzhuo.lu@intel.com; jingjing.wu@intel.com; > > bernard.iremonger@intel.com; olivier.matz@6wind.com; Adrien Mazarguil > > ; Thomas Monjalon > ; > > ferruh.yigit@intel.com; arybchenko@solarflare.com > > Cc: Shahaf Shuler ; dev@dpdk.org; Ori Kam > > > > Subject: [dpdk-dev] [PATCH v5 2/3] app/testpmd: support metadata as > > flow rule item > > > > As described in [1], this series adds option to set metadata value as > > match pattern when creating a new flow rule. > > > > This patch introduces additional options in testpmd commands. > > New item type "meta" "data", new offload flag "match_metadata". > > > > [1] "ethdev: support metadata as flow rule criteria" > > > > Signed-off-by: Dekel Peled > > --- > > app/test-pmd/cmdline.c | 10 +++++----- > > app/test-pmd/cmdline_flow.c | 25 +++++++++++++++++++++= ++++ > > app/test-pmd/testpmd.c | 4 ++++ > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 +++++- > > 4 files changed, 39 insertions(+), 6 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 6e14345..28bbd80 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -18124,7 +18124,8 @@ struct > cmd_config_per_port_tx_offload_result { > > > "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" > > "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" > > "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" > > - > "mt_lockfree#multi_segs#mbuf_fast_free#security"); > > + > "mt_lockfree#multi_segs#mbuf_fast_free#security#" > > + "match_metadata"); > > cmdline_parse_token_string_t > > cmd_config_per_port_tx_offload_result_on_off > > =3D > > TOKEN_STRING_INITIALIZER > > (struct cmd_config_per_port_tx_offload_result, > > @@ -18205,8 +18206,8 @@ struct > cmd_config_per_port_tx_offload_result { > > "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" > > "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" > > "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" > > - "mt_lockfree|multi_segs|mbuf_fast_free|security " > > - "on|off", > > + "mt_lockfree|multi_segs|mbuf_fast_free|security|" > > + "match_metadata on|off", > > .tokens =3D { > > (void *)&cmd_config_per_port_tx_offload_result_port, > > (void *)&cmd_config_per_port_tx_offload_result_config, > > @@ -18309,8 +18310,7 @@ struct > cmd_config_per_queue_tx_offload_result { > > "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" > > "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" > > "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" > > - "mt_lockfree|multi_segs|mbuf_fast_free|security " > > - "on|off", > > + "mt_lockfree|multi_segs|mbuf_fast_free|security > on|off", >=20 > Is this relevant for your patch? Removed. >=20 > > .tokens =3D { > > (void *)&cmd_config_per_queue_tx_offload_result_port, > > (void *)&cmd_config_per_queue_tx_offload_result_port_id, > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > > index 1c72ad9..7ee9b7c 100644 > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -178,6 +178,8 @@ enum index { > > ITEM_ICMP6_ND_OPT_SLA_ETH_SLA, > > ITEM_ICMP6_ND_OPT_TLA_ETH, > > ITEM_ICMP6_ND_OPT_TLA_ETH_TLA, > > + ITEM_META, > > + ITEM_META_DATA, > > > > /* Validate/create actions. */ > > ACTIONS, > > @@ -599,6 +601,7 @@ struct parse_action_priv { > > ITEM_ICMP6_ND_OPT, > > ITEM_ICMP6_ND_OPT_SLA_ETH, > > ITEM_ICMP6_ND_OPT_TLA_ETH, > > + ITEM_META, > > ZERO, > > }; > > > > @@ -819,6 +822,12 @@ struct parse_action_priv { > > ZERO, > > }; > > > > +static const enum index item_meta[] =3D { > > + ITEM_META_DATA, > > + ITEM_NEXT, > > + ZERO, > > +}; > > + > > static const enum index next_action[] =3D { > > ACTION_END, > > ACTION_VOID, > > @@ -2087,6 +2096,22 @@ static int comp_vc_action_rss_queue(struct > > context *, const struct token *, > > .args =3D ARGS(ARGS_ENTRY_HTON > > (struct rte_flow_item_icmp6_nd_opt_tla_eth, > tla)), > > }, > > + [ITEM_META] =3D { > > + .name =3D "meta", > > + .help =3D "match metadata header", > > + .priv =3D PRIV_ITEM(META, sizeof(struct > rte_flow_item_meta)), > > + .next =3D NEXT(item_meta), > > + .call =3D parse_vc, > > + }, > > + [ITEM_META_DATA] =3D { > > + .name =3D "data", > > + .help =3D "metadata value", > > + .next =3D NEXT(item_meta, NEXT_ENTRY(UNSIGNED), > > item_param), >=20 > Do you support all the options? (mask, last ...) Changed to provide 'is' option only. >=20 > > + .args =3D ARGS(ARGS_ENTRY_MASK_HTON(struct >=20 > This means that the value is in network byte order. Yes, will note in variables type. >=20 > > rte_flow_item_meta, > > + data, > > + "\xff\xff\xff\xff" > > + "\xff\xff\xff\xff")), > > + }, > > > > /* Validate/create actions. */ > > [ACTIONS] =3D { > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > d550bda..75e960a 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -1060,6 +1060,10 @@ struct extmem_param { > > DEV_TX_OFFLOAD_MBUF_FAST_FREE)) > > port->dev_conf.txmode.offloads &=3D > > ~DEV_TX_OFFLOAD_MBUF_FAST_FREE; > > + if (!(port->dev_info.tx_offload_capa & > > + DEV_TX_OFFLOAD_MATCH_METADATA)) > > + port->dev_conf.txmode.offloads &=3D > > + ~DEV_TX_OFFLOAD_MATCH_METADATA; > > if (numa_support) { > > if (port_numa[pid] !=3D NUMA_NO_CONFIG) > > port_per_socket[port_numa[pid]]++; > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > index 8d60bf0..c97f26b 100644 > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > @@ -3671,11 +3671,15 @@ This section lists supported pattern items and > > their attributes, if any. > > > > - ``sla {MAC-48}``: source Ethernet LLA. > > > > -- ``icmp6_nd_opt_sla_eth``: match ICMPv6 neighbor discovery target > > Ethernet > > +- ``icmp6_nd_opt_tla_eth``: match ICMPv6 neighbor discovery target > > +Ethernet > > link-layer address option. >=20 > Is this relevant to your patch? Removed. >=20 > > > > - ``tla {MAC-48}``: target Ethernet LLA. > > > > +- ``meta``: match application specific metadata. > > + > > + - ``data``: metadata value. >=20 > Should show what value to add. > Also missing the documentations for enabling the offload. Added. >=20 > > + > > Actions list > > ^^^^^^^^^^^^ > > > > -- > > 1.8.3.1 > Thanks, > Ori