From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [PATCH] ethdev: force RSS offload rules again
Date: Sun, 3 Jun 2018 10:41:46 +0000
Message-ID: <VI1PR05MB443154231B403543F6DD9372C3600@VI1PR05MB4431.eurprd05.prod.outlook.com>
References: <20180531132245.19424-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Xueming(Steven) Li"
 <xuemingl@mellanox.com>, Wei Dai <wei.dai@intel.com>, Qi Zhang
 <qi.z.zhang@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Thomas Monjalon
 <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr40047.outbound.protection.outlook.com [40.107.4.47])
 by dpdk.org (Postfix) with ESMTP id AC4FE56A3
 for <dev@dpdk.org>; Sun,  3 Jun 2018 12:41:47 +0200 (CEST)
In-Reply-To: <20180531132245.19424-1-ferruh.yigit@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thursday, May 31, 2018 4:23 PM, Ferruh Yigit:
> Subject: [PATCH] ethdev: force RSS offload rules again
>=20
> PMDs should provide supported RSS hash functions via
> dev_info.flow_type_rss_offloads variable.
>=20
> There is a check in ethdev if requested RSS hash function is supported by
> PMD or not.
> This check has been relaxed in previous release to not return an error wh=
en a
> non supported has function requested [1], this has been done to not break
> the applications.
>=20
> Adding the error return back.
> PMDs need to provide correct list of supported hash functions and
> applications need to take care this information before configuring the RS=
S
> otherwise they will get an error from APIs:
> rte_eth_dev_rss_hash_update()
> rte_eth_dev_configure()

Are the current app/examples in DPDK tree behave accordingly? =20