Re: [dpdk-dev] [PATCH v5 3/3] mempool: mempool build on Windows

From: Fady Bader <fady@mellanox.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
	Tasnim Bashar <tbashar@mellanox.com>,
	Tal Shnaiderman <talshn@mellanox.com>,
	Yohad Tor <yohadt@mellanox.com>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>,
	Omar Cardona <ocardona@microsoft.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>,
	Ranjit Menon <ranjit.menon@intel.com>,
	Olivier Matz <olivier.matz@6wind.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>,
	Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH v5 3/3] mempool: mempool build on Windows
Date: Sun, 5 Jul 2020 12:24:05 +0000	[thread overview]
Message-ID: <VI1PR05MB587292DF47773AFF07E8729ABF680@VI1PR05MB5872.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8zUfk74DO5DHr8E2Si2x-b28TZHwRr6b+L_j8BEc43Fgw@mail.gmail.com>

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Sunday, July 5, 2020 3:01 PM
> To: Fady Bader <fady@mellanox.com>
> Cc: dev <dev@dpdk.org>; Thomas Monjalon <thomas@monjalon.net>; Tasnim
> Bashar <tbashar@mellanox.com>; Tal Shnaiderman <talshn@mellanox.com>;
> Yohad Tor <yohadt@mellanox.com>; Dmitry Kozlyuk
> <dmitry.kozliuk@gmail.com>; Harini Ramakrishnan
> <harini.ramakrishnan@microsoft.com>; Omar Cardona
> <ocardona@microsoft.com>; Pallavi Kadam <pallavi.kadam@intel.com>; Ranjit
> Menon <ranjit.menon@intel.com>; Olivier Matz <olivier.matz@6wind.com>;
> Andrew Rybchenko <arybchenko@solarflare.com>; Ray Kinsella
> <mdr@ashroe.eu>; Neil Horman <nhorman@tuxdriver.com>
> Subject: Re: [dpdk-dev] [PATCH v5 3/3] mempool: mempool build on Windows
> 
> On Sun, Jul 5, 2020 at 1:47 PM Fady Bader <fady@mellanox.com> wrote:
> > diff --git a/lib/librte_eal/rte_eal_version.map
> b/lib/librte_eal/rte_eal_version.map
> > index 196eef5afa..9ad843c754 100644
> > --- a/lib/librte_eal/rte_eal_version.map
> > +++ b/lib/librte_eal/rte_eal_version.map
> > @@ -395,4 +395,5 @@ INTERNAL {
> >         rte_mem_map;
> >         rte_mem_page_size;
> >         rte_mem_unmap;
> > +       __rte_trace_mem_per_thread_alloc;
> 
> The CI result is not there yet, but I expect issues.
> This symbol is marked as experimental, not internal.
> + it is exported already in the experimental section of the EAL map.

You are right, I'll remove it in the next version of the patch.

> 
> Why did you need this line? 
> 
> 
> --
> David Marchand