From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:41599) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyGNi-00027c-Qd for qemu-devel@nongnu.org; Mon, 25 Feb 2019 08:33:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyGNh-0006P0-Gp for qemu-devel@nongnu.org; Mon, 25 Feb 2019 08:33:18 -0500 Received: from mail-oln040092064071.outbound.protection.outlook.com ([40.92.64.71]:17541 helo=EUR01-DB5-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gyGNg-0006G5-Vp for qemu-devel@nongnu.org; Mon, 25 Feb 2019 08:33:17 -0500 From: =?iso-8859-1?Q?Fernando_Casas_Sch=F6ssow?= Date: Mon, 25 Feb 2019 13:32:47 +0000 Message-ID: References: <28e6b4ed-9afd-3a79-6267-86c7385c23ce@redhat.com> <20190223165523.1d674224@ncopa-desktop.copa.dup.pw> <20190225112424.2dd535a1@ncopa-desktop.copa.dup.pw> <20190225132156.477faf18@ncopa-desktop.copa.dup.pw> <20190225142517.24367cad@ncopa-desktop.copa.dup.pw> In-Reply-To: <20190225142517.24367cad@ncopa-desktop.copa.dup.pw> Content-Language: en-US MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Natanael Copa Cc: Peter Maydell , Stefan Hajnoczi , Paolo Bonzini , qemu-devel , Richard Henderson Thanks Natanael. Is the new package ready? I will update as soon as the package is available, try to repro and report = back. Thanks everyone for looking into this! On lun, feb 25, 2019 at 2:25 PM, Natanael Copa wrot= e: On Mon, 25 Feb 2019 13:06:16 +0000 Peter Maydell > wrote: On Mon, 25 Feb 2019 at 12:22, Natanael Copa > wrote: > > On Mon, 25 Feb 2019 10:34:23 +0000 > Pete= r Maydell > wrote= : > > The short term fix is to fix your toolchain/compilation > > environme= nt options so that it isn't trying to override > > the definition of memcpy= (). > > The easiest workaround is to simply disable FORTIY_SOURCE, but that= > will weaken the security for all implemented string functions, strcpy, >= memmove etc, so I don't want to do that. > > Is it only lduw_he_p that nee= ds to be atomic or are the other functions > in include/qemu/bswap.h using = memcpy also required to be atomic? Hard to say, since we haven't done the "= audit all the callers" step that Stefan mentioned. If you're going to repla= ce memcpy with __builtin_memcpy then the safest thing is to do it for all t= hose uses (this will also give you much better generated code for performan= ce purposes). I figured that and that is exactly what I did. Fernando: Can you please tes= t the binary from qemu-system-x86_64-3.1.0-r3 from alpine edge? I will back= port the fix if you can confirm it fixes the problem. Thanks! -nc PS. Those= issues are pretty hard to track down, so big thanks to everyone who helped= find the exact issue here. You have done a great work!