From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gavin Hu (Arm Technology China)" Subject: Re: [PATCH v3 3/3] doc: add cross compile part for sample applications Date: Mon, 17 Sep 2018 10:55:29 +0000 Message-ID: References: <20180807031943.5331-1-gavin.hu@arm.com> <20180917074735.28161-1-gavin.hu@arm.com> <20180917074735.28161-3-gavin.hu@arm.com> <20180917094819.GA3140@jerin> <20180917103438.GA7618@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Honnappa Nagarahalli , Steve Capper , Ola Liljedahl , nd , "stable@dpdk.org" To: Jerin Jacob Return-path: In-Reply-To: <20180917103438.GA7618@jerin> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jerin, Thanks for review, could you help review the v5 version? Best Regards, Gavin > -----Original Message----- > From: Jerin Jacob > Sent: Monday, September 17, 2018 6:35 PM > To: Gavin Hu (Arm Technology China) > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; Steve Capper > ; Ola Liljedahl ; nd > ; stable@dpdk.org > Subject: Re: [PATCH v3 3/3] doc: add cross compile part for sample > applications >=20 > -----Original Message----- > > Date: Mon, 17 Sep 2018 10:28:57 +0000 > > From: "Gavin Hu (Arm Technology China)" > > To: Jerin Jacob > > CC: "dev@dpdk.org" , Honnappa Nagarahalli > > , Steve Capper > , > > Ola Liljedahl , nd , > "stable@dpdk.org" > > > > Subject: RE: [PATCH v3 3/3] doc: add cross compile part for sample > > applications > > > > > -----Original Message----- > > > From: Jerin Jacob > > > Sent: Monday, September 17, 2018 5:48 PM > > > To: Gavin Hu (Arm Technology China) > > > Cc: dev@dpdk.org; Honnappa Nagarahalli > > > ; Steve Capper > ; > > > Ola Liljedahl ; nd ; > > > stable@dpdk.org > > > Subject: Re: [PATCH v3 3/3] doc: add cross compile part for sample > > > applications > > > > > > -----Original Message----- > > > > Date: Mon, 17 Sep 2018 15:47:35 +0800 > > > > From: Gavin Hu > > > > To: dev@dpdk.org > > > > CC: gavin.hu@arm.com, Honnappa.Nagarahalli@arm.com, > > > > steve.capper@arm.com, Ola.Liljedahl@arm.com, > > > > jerin.jacob@caviumnetworks.com, nd@arm.com, stable@dpdk.org > > > > Subject: [PATCH v3 3/3] doc: add cross compile part for sample > > > > applications > > > > X-Mailer: git-send-email 2.11.0 > > > > > > > > External Email > > > > > > > > Fixes: 7cacb05655 ("doc: add generic build instructions for sample > > > > apps") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Gavin Hu > > > > Reviewed-by: Honnappa Nagarahalli > > > > --- > > > > doc/guides/sample_app_ug/compiling.rst | 15 ++++++++++++++- > > > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/doc/guides/sample_app_ug/compiling.rst > > > > b/doc/guides/sample_app_ug/compiling.rst > > > > index a2d75ed22..6f04743c8 100644 > > > > --- a/doc/guides/sample_app_ug/compiling.rst > > > > +++ b/doc/guides/sample_app_ug/compiling.rst > > > > @@ -9,7 +9,6 @@ This section explains how to compile the DPDK > > > > sample > > > applications. > > > > To compile all the sample applications > > > > -------------------------------------- > > > > > > > > - > > > > Set the path to DPDK source code if its not set: > > > > > > > > .. code-block:: console > > > > @@ -93,3 +92,17 @@ Build the application: > > > > > > > > export RTE_TARGET=3Dbuild > > > > make > > > > + > > > > +To cross compile the sample application(s) > > > > +------------------------------------------ > > > > + > > > > +For cross compiling the sample application(s), please append > > > 'CROSS=3D$(CROSS_COMPILER_PREFIX)' to the 'make' command. > > > > +In example of AARCH64 cross compiling: > > > > + > > > > + .. code-block:: console > > > > + > > > > + export RTE_TARGET=3Dbuild > > > > + export RTE_SDK=3D/path/to/rte_sdk > > > > + make -C examples CROSS=3Daarch64-linux-gnu- > > > > + or > > > > + make CROSS=3Daarch64-linux-gnu- > > > > > > It should be make -C examples/l3fwd CROSS=3Daarch64-linux-gnu-, Right= ? > > > as without giving directory it builds the SDK only. > > > > -C examples/l3fwd can be ignored if the $(pwd) is already in there. >=20 > Yes. Since it mentioned as "or" it better to explicitly mentioned in it. >=20 > i.e >=20 > make -C examples CROSS=3Daarch64-linux-gnu- >=20 > or >=20 > cd $(pwd)/examples/ > make CROSS=3Daarch64-linux-gnu- >=20 > or >=20 > make -C examples/ CROSS=3Daarch64-linux-gnu- >=20 > > > > > > > > > -- > > > > 2.11.0 > > > >