From: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: Ola Liljedahl <Ola.Liljedahl@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Steve Capper <Steve.Capper@arm.com>, nd <nd@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH v3 1/3] ring: read tail using atomic load
Date: Wed, 10 Oct 2018 06:28:36 +0000 [thread overview]
Message-ID: <VI1PR08MB3167DC47C7D01845E51814F98FE00@VI1PR08MB3167.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20181008104944.GD11081@jerin>
Hi Jerin,
Following the guide to use the PMU counters(KO inserted and DPDK recompiled), the numbers increased 10+ folds(bigger numbers here mean more precise?), is this valid and expected?
No significant difference was seen.
gavin@net-arm-thunderx2:~/community/dpdk$ sudo ./test/test/test -l 16-19,44-47,72-75,100-103 -n 4 --socket-mem=1024 -- -i
RTE>>ring_perf_autotest (#1 run w/o the patch)
### Testing single element and burst enq/deq ###
SP/SC single enq/dequeue: 103
MP/MC single enq/dequeue: 130
SP/SC burst enq/dequeue (size: 8): 18
MP/MC burst enq/dequeue (size: 8): 21
SP/SC burst enq/dequeue (size: 32): 7
MP/MC burst enq/dequeue (size: 32): 8
### Testing empty dequeue ###
SC empty dequeue: 3.00
MC empty dequeue: 3.00
### Testing using a single lcore ###
SP/SC bulk enq/dequeue (size: 8): 17.48
MP/MC bulk enq/dequeue (size: 8): 21.77
SP/SC bulk enq/dequeue (size: 32): 7.39
MP/MC bulk enq/dequeue (size: 32): 8.52
### Testing using two hyperthreads ###
SP/SC bulk enq/dequeue (size: 8): 31.32
MP/MC bulk enq/dequeue (size: 8): 38.52
SP/SC bulk enq/dequeue (size: 32): 13.39
MP/MC bulk enq/dequeue (size: 32): 14.15
### Testing using two physical cores ###
SP/SC bulk enq/dequeue (size: 8): 75.00
MP/MC bulk enq/dequeue (size: 8): 141.97
SP/SC bulk enq/dequeue (size: 32): 23.85
MP/MC bulk enq/dequeue (size: 32): 36.13
Test OK
RTE>>ring_perf_autotest (#2 run w/o the patch)
### Testing single element and burst enq/deq ###
SP/SC single enq/dequeue: 103
MP/MC single enq/dequeue: 130
SP/SC burst enq/dequeue (size: 8): 18
MP/MC burst enq/dequeue (size: 8): 21
SP/SC burst enq/dequeue (size: 32): 7
MP/MC burst enq/dequeue (size: 32): 8
### Testing empty dequeue ###
SC empty dequeue: 3.00
MC empty dequeue: 3.00
### Testing using a single lcore ###
SP/SC bulk enq/dequeue (size: 8): 17.48
MP/MC bulk enq/dequeue (size: 8): 21.77
SP/SC bulk enq/dequeue (size: 32): 7.38
MP/MC bulk enq/dequeue (size: 32): 8.52
### Testing using two hyperthreads ###
SP/SC bulk enq/dequeue (size: 8): 31.31
MP/MC bulk enq/dequeue (size: 8): 38.52
SP/SC bulk enq/dequeue (size: 32): 13.33
MP/MC bulk enq/dequeue (size: 32): 14.16
### Testing using two physical cores ###
SP/SC bulk enq/dequeue (size: 8): 75.74
MP/MC bulk enq/dequeue (size: 8): 147.33
SP/SC bulk enq/dequeue (size: 32): 24.79
MP/MC bulk enq/dequeue (size: 32): 40.09
Test OK
RTE>>ring_perf_autotest (#1 run w/ the patch)
### Testing single element and burst enq/deq ###
SP/SC single enq/dequeue: 103
MP/MC single enq/dequeue: 129
SP/SC burst enq/dequeue (size: 8): 18
MP/MC burst enq/dequeue (size: 8): 22
SP/SC burst enq/dequeue (size: 32): 7
MP/MC burst enq/dequeue (size: 32): 8
### Testing empty dequeue ###
SC empty dequeue: 3.00
MC empty dequeue: 4.00
### Testing using a single lcore ###
SP/SC bulk enq/dequeue (size: 8): 17.89
MP/MC bulk enq/dequeue (size: 8): 21.77
SP/SC bulk enq/dequeue (size: 32): 7.50
MP/MC bulk enq/dequeue (size: 32): 8.52
### Testing using two hyperthreads ###
SP/SC bulk enq/dequeue (size: 8): 31.24
MP/MC bulk enq/dequeue (size: 8): 38.14
SP/SC bulk enq/dequeue (size: 32): 13.24
MP/MC bulk enq/dequeue (size: 32): 14.69
### Testing using two physical cores ###
SP/SC bulk enq/dequeue (size: 8): 74.63
MP/MC bulk enq/dequeue (size: 8): 137.61
SP/SC bulk enq/dequeue (size: 32): 24.82
MP/MC bulk enq/dequeue (size: 32): 36.64
Test OK
RTE>>ring_perf_autotest (#1 run w/ the patch)
### Testing single element and burst enq/deq ###
SP/SC single enq/dequeue: 103
MP/MC single enq/dequeue: 129
SP/SC burst enq/dequeue (size: 8): 18
MP/MC burst enq/dequeue (size: 8): 22
SP/SC burst enq/dequeue (size: 32): 7
MP/MC burst enq/dequeue (size: 32): 8
### Testing empty dequeue ###
SC empty dequeue: 3.00
MC empty dequeue: 4.00
### Testing using a single lcore ###
SP/SC bulk enq/dequeue (size: 8): 17.89
MP/MC bulk enq/dequeue (size: 8): 21.77
SP/SC bulk enq/dequeue (size: 32): 7.50
MP/MC bulk enq/dequeue (size: 32): 8.52
### Testing using two hyperthreads ###
SP/SC bulk enq/dequeue (size: 8): 31.53
MP/MC bulk enq/dequeue (size: 8): 38.59
SP/SC bulk enq/dequeue (size: 32): 13.24
MP/MC bulk enq/dequeue (size: 32): 14.69
### Testing using two physical cores ###
SP/SC bulk enq/dequeue (size: 8): 75.60
MP/MC bulk enq/dequeue (size: 8): 149.14
SP/SC bulk enq/dequeue (size: 32): 25.13
MP/MC bulk enq/dequeue (size: 32): 40.60
Test OK
> -----Original Message-----
> From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Sent: Monday, October 8, 2018 6:50 PM
> To: Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>
> Cc: Ola Liljedahl <Ola.Liljedahl@arm.com>; dev@dpdk.org; Honnappa
> Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Steve Capper <Steve.Capper@arm.com>;
> nd <nd@arm.com>; stable@dpdk.org
> Subject: Re: [PATCH v3 1/3] ring: read tail using atomic load
>
> -----Original Message-----
> > Date: Mon, 8 Oct 2018 10:33:43 +0000
> > From: "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>
> > To: Ola Liljedahl <Ola.Liljedahl@arm.com>, Jerin Jacob
> > <jerin.jacob@caviumnetworks.com>
> > CC: "dev@dpdk.org" <dev@dpdk.org>, Honnappa Nagarahalli
> > <Honnappa.Nagarahalli@arm.com>, "Ananyev, Konstantin"
> > <konstantin.ananyev@intel.com>, Steve Capper
> <Steve.Capper@arm.com>,
> > nd <nd@arm.com>, "stable@dpdk.org" <stable@dpdk.org>
> > Subject: RE: [PATCH v3 1/3] ring: read tail using atomic load
> >
> >
> > I did benchmarking w/o and w/ the patch, it did not show any noticeable
> differences in terms of latency.
> > Here is the full log( 3 runs w/o the patch and 2 runs w/ the patch).
> >
> > sudo ./test/test/test -l 16-19,44-47,72-75,100-103 -n 4
> > --socket-mem=1024 -- -i
>
> These counters are running at 100MHz. Use PMU counters to get more
> accurate results.
>
> https://doc.dpdk.org/guides/prog_guide/profile_app.html
> See: 55.2. Profiling on ARM64
>
next prev parent reply other threads:[~2018-10-10 6:28 UTC|newest]
Thread overview: 131+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 1:18 [PATCH] ring: fix c11 memory ordering issue Gavin Hu
2018-08-06 9:19 ` Thomas Monjalon
2018-08-08 1:39 ` Gavin Hu
2018-08-07 3:19 ` [PATCH v2] " Gavin Hu
2018-08-07 5:56 ` He, Jia
2018-08-07 7:56 ` Gavin Hu
2018-08-08 3:07 ` Jerin Jacob
2018-08-08 7:23 ` [dpdk-stable] " Thomas Monjalon
2018-09-17 7:47 ` [PATCH v3 1/3] app/testpmd: show errno along with flow API errors Gavin Hu
2018-09-17 7:47 ` [PATCH v3 2/3] net/i40e: remove invalid comment Gavin Hu
2018-09-17 8:25 ` Gavin Hu (Arm Technology China)
2018-09-17 7:47 ` [PATCH v3 3/3] doc: add cross compile part for sample applications Gavin Hu
2018-09-17 9:48 ` Jerin Jacob
2018-09-17 10:28 ` Gavin Hu (Arm Technology China)
2018-09-17 10:34 ` Jerin Jacob
2018-09-17 10:55 ` Gavin Hu (Arm Technology China)
2018-09-17 10:49 ` [PATCH v4] " Gavin Hu
2018-09-17 10:53 ` [PATCH v5] " Gavin Hu
2018-09-18 11:00 ` Jerin Jacob
2018-09-19 0:33 ` [PATCH v6] " Gavin Hu
2018-09-17 8:11 ` [PATCH v4 1/4] bus/fslmc: fix undefined reference of memsegs Gavin Hu
2018-09-17 8:11 ` [PATCH v4 2/4] ring: read tail using atomic load Gavin Hu
2018-09-20 6:41 ` Jerin Jacob
2018-09-25 9:26 ` Gavin Hu (Arm Technology China)
2018-09-17 8:11 ` [PATCH v4 3/4] ring: synchronize the load and store of the tail Gavin Hu
2018-09-17 8:11 ` [PATCH v4 4/4] ring: move the atomic load of head above the loop Gavin Hu
2018-10-27 14:21 ` [dpdk-stable] " Thomas Monjalon
2018-09-17 8:17 ` [PATCH v3 1/3] ring: read tail using atomic load Gavin Hu
2018-09-17 8:17 ` [PATCH v3 2/3] ring: synchronize the load and store of the tail Gavin Hu
2018-09-26 9:29 ` Gavin Hu (Arm Technology China)
2018-09-26 9:59 ` Justin He
2018-09-29 10:57 ` Jerin Jacob
2018-10-17 6:29 ` [PATCH 1/2] " Gavin Hu
2018-10-17 6:29 ` [PATCH 2/2] ring: move the atomic load of head above the loop Gavin Hu
2018-10-17 6:35 ` [PATCH 1/2] ring: synchronize the load and store of the tail Gavin Hu (Arm Technology China)
2018-10-27 14:39 ` Thomas Monjalon
2018-10-27 15:00 ` Jerin Jacob
2018-10-27 15:13 ` Thomas Monjalon
2018-10-27 15:34 ` Jerin Jacob
2018-10-27 15:48 ` Thomas Monjalon
2018-10-29 2:51 ` Gavin Hu (Arm Technology China)
2018-10-29 2:57 ` Gavin Hu (Arm Technology China)
2018-10-29 10:16 ` Jerin Jacob
2018-10-29 10:47 ` Thomas Monjalon
2018-10-29 11:10 ` Jerin Jacob
2018-11-03 20:12 ` Mattias Rönnblom
2018-11-05 21:51 ` Honnappa Nagarahalli
2018-11-06 11:03 ` Mattias Rönnblom
2018-10-31 3:35 ` [PATCH v2 0/2] rte ring c11 bug fix and optimization Gavin Hu
2018-10-31 10:26 ` [PATCH v3 0/2] ring library with c11 memory model " Gavin Hu
2018-10-31 16:58 ` Thomas Monjalon
2018-11-01 9:53 ` [PATCH v4 1/2] ring: synchronize the load and store of the tail Gavin Hu
2018-11-01 9:53 ` [PATCH v4 2/2] ring: move the atomic load of head above the loop Gavin Hu
2018-11-01 17:26 ` Stephen Hemminger
2018-11-02 0:53 ` Gavin Hu (Arm Technology China)
2018-11-02 4:30 ` Honnappa Nagarahalli
2018-11-02 7:15 ` Gavin Hu (Arm Technology China)
2018-11-02 9:36 ` Thomas Monjalon
2018-11-02 11:23 ` Gavin Hu (Arm Technology China)
2018-10-31 10:26 ` [PATCH v3 1/2] ring: synchronize the load and store of the tail Gavin Hu
2018-10-31 22:07 ` Stephen Hemminger
2018-11-01 9:56 ` Gavin Hu (Arm Technology China)
2018-10-31 10:26 ` [PATCH v3 2/2] ring: move the atomic load of head above the loop Gavin Hu
2018-10-31 3:35 ` [PATCH v2 1/2] ring: synchronize the load and store of the tail Gavin Hu
2018-10-31 3:35 ` [PATCH v2 2/2] ring: move the atomic load of head above the loop Gavin Hu
2018-10-31 9:36 ` Thomas Monjalon
2018-10-31 10:27 ` Gavin Hu (Arm Technology China)
2018-11-01 9:53 ` [PATCH v4 0/2] ring library with c11 memory model bug fix and optimization Gavin Hu
2018-11-02 11:21 ` [PATCH v5 " Gavin Hu
2018-11-02 11:21 ` [PATCH v5 1/2] ring: synchronize the load and store of the tail Gavin Hu
2018-11-05 9:30 ` Olivier Matz
2018-11-02 11:21 ` [PATCH v5 2/2] ring: move the atomic load of head above the loop Gavin Hu
2018-11-02 11:43 ` Bruce Richardson
2018-11-03 1:19 ` Gavin Hu (Arm Technology China)
2018-11-03 9:34 ` Honnappa Nagarahalli
2018-11-05 13:17 ` [dpdk-stable] " Thomas Monjalon
2018-11-05 13:41 ` Jerin Jacob
2018-11-05 9:44 ` Olivier Matz
2018-11-05 13:36 ` [dpdk-stable] " Thomas Monjalon
2018-09-17 8:17 ` [PATCH v3 3/3] " Gavin Hu
2018-09-26 9:29 ` Gavin Hu (Arm Technology China)
2018-09-26 10:06 ` Justin He
2018-09-29 7:19 ` Stephen Hemminger
2018-09-29 10:59 ` Jerin Jacob
2018-09-26 9:29 ` [PATCH v3 1/3] ring: read tail using atomic load Gavin Hu (Arm Technology China)
2018-09-26 10:09 ` Justin He
2018-09-29 10:48 ` Jerin Jacob
2018-10-05 0:47 ` Gavin Hu (Arm Technology China)
2018-10-05 8:21 ` Ananyev, Konstantin
2018-10-05 11:15 ` Ola Liljedahl
2018-10-05 11:36 ` Ola Liljedahl
2018-10-05 13:44 ` Ananyev, Konstantin
2018-10-05 14:21 ` Ola Liljedahl
2018-10-05 15:11 ` Honnappa Nagarahalli
2018-10-05 17:07 ` Jerin Jacob
2018-10-05 18:05 ` Ola Liljedahl
2018-10-05 20:06 ` Honnappa Nagarahalli
2018-10-05 20:17 ` Ola Liljedahl
2018-10-05 20:29 ` Honnappa Nagarahalli
2018-10-05 20:34 ` Ola Liljedahl
2018-10-06 7:41 ` Jerin Jacob
2018-10-06 19:44 ` Ola Liljedahl
2018-10-06 19:59 ` Ola Liljedahl
2018-10-07 4:02 ` Jerin Jacob
2018-10-07 20:11 ` Ola Liljedahl
2018-10-07 20:44 ` Ola Liljedahl
2018-10-08 6:06 ` Jerin Jacob
2018-10-08 9:22 ` Ola Liljedahl
2018-10-08 10:00 ` Jerin Jacob
2018-10-08 10:25 ` Ola Liljedahl
2018-10-08 10:33 ` Gavin Hu (Arm Technology China)
2018-10-08 10:39 ` Ola Liljedahl
2018-10-08 10:41 ` Gavin Hu (Arm Technology China)
2018-10-08 10:49 ` Jerin Jacob
2018-10-10 6:28 ` Gavin Hu (Arm Technology China) [this message]
2018-10-10 19:26 ` Honnappa Nagarahalli
2018-10-08 10:46 ` Jerin Jacob
2018-10-08 11:21 ` Ola Liljedahl
2018-10-08 11:50 ` Jerin Jacob
2018-10-08 11:59 ` Ola Liljedahl
2018-10-08 12:05 ` Jerin Jacob
2018-10-08 12:20 ` Jerin Jacob
2018-10-08 12:30 ` Ola Liljedahl
2018-10-09 8:53 ` Olivier Matz
2018-10-09 3:16 ` Honnappa Nagarahalli
2018-10-08 14:43 ` Bruce Richardson
2018-10-08 14:46 ` Ola Liljedahl
2018-10-08 15:45 ` Ola Liljedahl
2018-10-08 5:27 ` Honnappa Nagarahalli
2018-10-08 10:01 ` Ola Liljedahl
2018-10-27 14:17 ` [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR08MB3167DC47C7D01845E51814F98FE00@VI1PR08MB3167.eurprd08.prod.outlook.com \
--to=gavin.hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Ola.Liljedahl@arm.com \
--cc=Steve.Capper@arm.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.