From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gavin Hu (Arm Technology China)" Subject: Re: [PATCH v3 2/3] net/i40e: remove invalid comment Date: Mon, 17 Sep 2018 08:25:11 +0000 Message-ID: References: <20180807031943.5331-1-gavin.hu@arm.com> <20180917074735.28161-1-gavin.hu@arm.com> <20180917074735.28161-2-gavin.hu@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Honnappa Nagarahalli , Steve Capper , Ola Liljedahl , "jerin.jacob@caviumnetworks.com" , nd , Ferruh Yigit To: "Gavin Hu (Arm Technology China)" , "dev@dpdk.org" Return-path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0048.outbound.protection.outlook.com [104.47.1.48]) by dpdk.org (Postfix) with ESMTP id 274262BA8 for ; Mon, 17 Sep 2018 10:25:13 +0200 (CEST) In-Reply-To: <20180917074735.28161-2-gavin.hu@arm.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi All, I am really sorry I made a mistake by submitting patches from a wrong branc= h and tried to rescue quickly and made another mistake(submitted one more p= atch not mine). Please skip these wrong patches(I already superseded them) and help review = the new 3 patches for rte ring. Really sorry again for the confusion and inconveniences! Best Regards, Gavin > -----Original Message----- > From: Gavin Hu > Sent: Monday, September 17, 2018 3:48 PM > To: dev@dpdk.org > Cc: Gavin Hu (Arm Technology China) ; Honnappa > Nagarahalli ; Steve Capper > ; Ola Liljedahl ; > jerin.jacob@caviumnetworks.com; nd ; Ferruh Yigit > > Subject: [PATCH v3 2/3] net/i40e: remove invalid comment >=20 > From: Ferruh Yigit >=20 > Comments says "no csum error report support" but there is no check relate= d > csum offloads. Removing the comment. >=20 > Signed-off-by: Ferruh Yigit > Acked-by: Qi Zhang > --- > drivers/net/i40e/i40e_rxtx_vec_common.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h > b/drivers/net/i40e/i40e_rxtx_vec_common.h > index 63cb17742..f00f6d648 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h > @@ -199,9 +199,7 @@ > i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev) > if (fconf->mode !=3D RTE_FDIR_MODE_NONE) > return -1; >=20 > - /* - no csum error report support > - * - no header split support > - */ > + /* no header split support */ > if (rxmode->offloads & DEV_RX_OFFLOAD_HEADER_SPLIT) > return -1; >=20 > -- > 2.11.0