From: "Geva, Erez" <erez.geva.ext@siemens.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Arnd Bergmann <arnd@arndb.de>,
Cong Wang <xiyou.wangcong@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Jakub Kicinski <kuba@kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
Alexei Starovoitov <ast@kernel.org>,
Colin Ian King <colin.king@canonical.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Eric Dumazet <edumazet@google.com>,
Eyal Birger <eyal.birger@gmail.com>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
Jakub Sitnicki <jakub@cloudflare.com>,
John Ogness <john.ogness@linutronix.de>,
Jon Rosen <jrosen@cisco.com>, Kees Cook <keescook@chromium.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Martin KaFai Lau <kafai@fb.com>,
Matthieu Baerts <matthieu.baerts@tessares.net>,
Andrei Vagin <avagin@gmail.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Ingo Molnar <mingo@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Miaohe Lin <linmiaohe@huawei.com>,
Michal Kubecek <mkubecek@suse.cz>,
Or Cohen <orcohen@paloaltonetworks.com>,
Oleg Nesterov <oleg@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Richard Cochran <richardcochran@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
Xie He <xie.he.0141@gmail.com>, Stephen Boyd <sboyd@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vladis Dronov <vdronov@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Vedang Patel <vedang.patel@intel.com>,
"Molzahn, Ines" <ines.molzahn@siemens.com>,
"Sudler, Simon" <simon.sudler@siemens.com>,
"Meisinger, Andreas" <andreas.meisinger@siemens.com>,
"Bucher, Andreas" <andreas.bucher@siemens.com>,
"henning.schild@siemens.com" <henning.schild@siemens.com>,
"jan.kiszka@siemens.com" <jan.kiszka@siemens.com>,
"Zirkler, Andreas" <andreas.zirkler@siemens.com>,
"Sakic, Ermin" <ermin.sakic@siemens.com>,
"anninh.nguyen@siemens.com" <anninh.nguyen@siemens.com>,
"Saenger, Michael" <michael.saenger@siemens.com>,
"Maehringer, Bernd" <bernd.maehringer@siemens.com>,
"gisela.greinert@siemens.com" <gisela.greinert@siemens.com>,
Erez Geva <ErezGeva2@gmail.com>
Subject: Re: [PATCH 1/3] Add TX sending hardware timestamp.
Date: Wed, 9 Dec 2020 15:21:34 +0000 [thread overview]
Message-ID: <VI1PR10MB244654C4B42E47DB5EBE0B05ABCC0@VI1PR10MB2446.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CA+FuTScWkYn0Ur+aSuz1cREbQJO0fB6powOm8PFxze4v8JwBaw@mail.gmail.com>
On 09/12/2020 15:48, Willem de Bruijn wrote:
> On Wed, Dec 9, 2020 at 9:37 AM Erez Geva <erez.geva.ext@siemens.com> wrote:
>>
>> Configure and send TX sending hardware timestamp from
>> user space application to the socket layer,
>> to provide to the TC ETC Qdisc, and pass it to
>> the interface network driver.
>>
>> - New flag for the SO_TXTIME socket option.
>> - New access auxiliary data header to pass the
>> TX sending hardware timestamp.
>> - Add the hardware timestamp to the socket cookie.
>> - Copy the TX sending hardware timestamp to the socket cookie.
>>
>> Signed-off-by: Erez Geva <erez.geva.ext@siemens.com>
>
> Hardware offload of pacing is definitely useful.
>
Thanks for your comment.
I agree, it is not limited of use.
> I don't think this needs a new separate h/w variant of SO_TXTIME.
>
I only extend SO_TXTIME.
> Indeed, we want pacing offload to work for existing applications.
>
As the conversion of the PHC and the system clock is dynamic over time.
How do you propse to achive it?
> It only requires that pacing qdiscs, both sch_etf and sch_fq,
> optionally skip queuing in their .enqueue callback and instead allow
> the skb to pass to the device driver as is, with skb->tstamp set. Only
> to devices that advertise support for h/w pacing offload.
>
I did not use "Fair Queue traffic policing".
As for ETF, it is all about ordering packets from different applications.
How can we achive it with skiping queuing?
Could you elaborate on this point?
Thanks
Erez
next prev parent reply other threads:[~2020-12-09 15:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 14:37 [PATCH 0/3] Add sending TX hardware timestamp for TC ETF Qdisc Erez Geva
2020-12-09 14:37 ` [PATCH 1/3] Add TX sending hardware timestamp Erez Geva
2020-12-09 14:48 ` Willem de Bruijn
2020-12-09 15:21 ` Geva, Erez [this message]
2020-12-09 17:37 ` Willem de Bruijn
2020-12-09 20:18 ` Geva, Erez
2020-12-10 1:03 ` Willem de Bruijn
2020-12-10 19:11 ` Willem de Bruijn
2020-12-10 22:37 ` Geva, Erez
2020-12-10 23:30 ` Willem de Bruijn
2020-12-11 0:27 ` Vinicius Costa Gomes
2020-12-11 14:44 ` Geva, Erez
2020-12-11 15:15 ` Willem de Bruijn
2020-12-11 14:22 ` Geva, Erez
2020-12-10 3:11 ` kernel test robot
2020-12-10 3:11 ` kernel test robot
2020-12-10 12:41 ` Geva, Erez
2020-12-10 12:41 ` Geva, Erez
2020-12-10 18:17 ` Geva, Erez
2020-12-10 18:17 ` Geva, Erez
2020-12-12 8:47 ` [kbuild-all] " Philip Li
2020-12-12 8:47 ` Philip Li
2020-12-16 2:01 ` [kbuild-all] " Rong Chen
2020-12-16 2:01 ` Rong Chen
2020-12-16 10:12 ` Geva, Erez
2020-12-09 14:37 ` [PATCH 2/3] Pass TX sending hardware timestamp to a socket's buffer Erez Geva
2020-12-09 14:37 ` [PATCH 3/3] The TC ETF Qdisc pass the hardware timestamp to the interface driver Erez Geva
[not found] <VI1PR10MB2446D7885F67ACCE3EEE67E9ABC50@VI1PR10MB2446.EURPRD10.PROD.OUTLOOK.COM>
2020-12-17 0:59 ` [PATCH 1/3] Add TX sending hardware timestamp Rong Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR10MB244654C4B42E47DB5EBE0B05ABCC0@VI1PR10MB2446.EURPRD10.PROD.OUTLOOK.COM \
--to=erez.geva.ext@siemens.com \
--cc=0x7f454c46@gmail.com \
--cc=ErezGeva2@gmail.com \
--cc=andreas.bucher@siemens.com \
--cc=andreas.meisinger@siemens.com \
--cc=andreas.zirkler@siemens.com \
--cc=anninh.nguyen@siemens.com \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=avagin@gmail.com \
--cc=bernd.maehringer@siemens.com \
--cc=bigeasy@linutronix.de \
--cc=colin.king@canonical.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=ermin.sakic@siemens.com \
--cc=eyal.birger@gmail.com \
--cc=frederic@kernel.org \
--cc=gisela.greinert@siemens.com \
--cc=gustavoars@kernel.org \
--cc=henning.schild@siemens.com \
--cc=ines.molzahn@siemens.com \
--cc=jakub@cloudflare.com \
--cc=jan.kiszka@siemens.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.ogness@linutronix.de \
--cc=john.stultz@linaro.org \
--cc=jrosen@cisco.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linmiaohe@huawei.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=michael.saenger@siemens.com \
--cc=mingo@kernel.org \
--cc=mkl@pengutronix.de \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=orcohen@paloaltonetworks.com \
--cc=peterz@infradead.org \
--cc=richardcochran@gmail.com \
--cc=sboyd@kernel.org \
--cc=simon.sudler@siemens.com \
--cc=stefan@datenfreihafen.org \
--cc=tglx@linutronix.de \
--cc=vdronov@redhat.com \
--cc=vedang.patel@intel.com \
--cc=vinicius.gomes@intel.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xie.he.0141@gmail.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.