From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BD27C433EF for ; Thu, 7 Jul 2022 09:17:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235133AbiGGJQ6 (ORCPT ); Thu, 7 Jul 2022 05:16:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230272AbiGGJQ5 (ORCPT ); Thu, 7 Jul 2022 05:16:57 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 863FA2CDDE; Thu, 7 Jul 2022 02:16:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1657185414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0G9+ZdgiY1pf7540Iu8Mnhcomtxme7gXDOd3aBrjvco=; b=VyD4jBxnLv08QoWXpC0q4O64XKy65EcXZ9cz2Bd64ITcPsfwEZHpaaMYN0/lJpIyXR2MRh hbEdTldsBf/5cCq38mYAn3Q+lzpnsNSizOhJSXk3Nk0TSOzfYjYMo811SiofIV7BFjx9L4 9qQlmXByEkj81aMxv/rZ6wzmc8o098M= Date: Thu, 07 Jul 2022 10:16:44 +0100 From: Paul Cercueil Subject: Re: [PATCH 01/11] ASoC: jz4740-i2s: Remove Open Firmware dependency To: Aidan MacDonald Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <20220706211330.120198-2-aidanmacdonald.0x0@gmail.com> References: <20220706211330.120198-1-aidanmacdonald.0x0@gmail.com> <20220706211330.120198-2-aidanmacdonald.0x0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Aidan, Le mer., juil. 6 2022 at 22:13:20 +0100, Aidan MacDonald=20 a =E9crit : > This driver doesn't require Open Firmware support. Remove the > OF-specific includes and drop the Kconfig dependency. >=20 > Signed-off-by: Aidan MacDonald Acked-by: Paul Cercueil Cheers, -Paul > --- > sound/soc/jz4740/Kconfig | 2 +- > sound/soc/jz4740/jz4740-i2s.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/sound/soc/jz4740/Kconfig b/sound/soc/jz4740/Kconfig > index 29144720cb62..e72f826062e9 100644 > --- a/sound/soc/jz4740/Kconfig > +++ b/sound/soc/jz4740/Kconfig > @@ -2,7 +2,7 @@ > config SND_JZ4740_SOC_I2S > tristate "SoC Audio (I2S protocol) for Ingenic JZ4740 SoC" > depends on MIPS || COMPILE_TEST > - depends on OF && HAS_IOMEM > + depends on HAS_IOMEM > select SND_SOC_GENERIC_DMAENGINE_PCM > help > Say Y if you want to use I2S protocol and I2S codec on Ingenic=20 > JZ4740 > diff --git a/sound/soc/jz4740/jz4740-i2s.c=20 > b/sound/soc/jz4740/jz4740-i2s.c > index 79afac0c5003..298ff0a83931 100644 > --- a/sound/soc/jz4740/jz4740-i2s.c > +++ b/sound/soc/jz4740/jz4740-i2s.c > @@ -5,10 +5,9 @@ >=20 > #include > #include > -#include > -#include > #include > #include > +#include > #include > #include >=20 > -- > 2.35.1 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72B79C43334 for ; Thu, 7 Jul 2022 09:17:56 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2DF9515E0; Thu, 7 Jul 2022 11:17:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2DF9515E0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657185474; bh=bzKwx+3ShntRFS/GXCVR2I42NNcZDHH6hYgFEHVJgdE=; h=Date:From:Subject:To:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CmOEM3Yzk0zDXd31MpvDAWZowqbuDC0GU+F0qRMKLFW1nLgh99sZsqkFJllZBDYqC vakl5NNuUPke2xTM2g+0c7A/kUeLKf0CXYsOklLizHG9uhVlMYmsmgGKGfX3K6aCVD nRlhNYjYSXJ6bwf37YYdzd+e9+IBXdP/j7qAaV/o= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B7DE4F80137; Thu, 7 Jul 2022 11:17:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6B9D5F8016A; Thu, 7 Jul 2022 11:17:02 +0200 (CEST) Received: from aposti.net (aposti.net [89.234.176.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 12B41F800C5 for ; Thu, 7 Jul 2022 11:16:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 12B41F800C5 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="VyD4jBxn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1657185414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0G9+ZdgiY1pf7540Iu8Mnhcomtxme7gXDOd3aBrjvco=; b=VyD4jBxnLv08QoWXpC0q4O64XKy65EcXZ9cz2Bd64ITcPsfwEZHpaaMYN0/lJpIyXR2MRh hbEdTldsBf/5cCq38mYAn3Q+lzpnsNSizOhJSXk3Nk0TSOzfYjYMo811SiofIV7BFjx9L4 9qQlmXByEkj81aMxv/rZ6wzmc8o098M= Date: Thu, 07 Jul 2022 10:16:44 +0100 From: Paul Cercueil Subject: Re: [PATCH 01/11] ASoC: jz4740-i2s: Remove Open Firmware dependency To: Aidan MacDonald Message-Id: In-Reply-To: <20220706211330.120198-2-aidanmacdonald.0x0@gmail.com> References: <20220706211330.120198-1-aidanmacdonald.0x0@gmail.com> <20220706211330.120198-2-aidanmacdonald.0x0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, tiwai@suse.com, broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Aidan, Le mer., juil. 6 2022 at 22:13:20 +0100, Aidan MacDonald=20 a =E9crit : > This driver doesn't require Open Firmware support. Remove the > OF-specific includes and drop the Kconfig dependency. >=20 > Signed-off-by: Aidan MacDonald Acked-by: Paul Cercueil Cheers, -Paul > --- > sound/soc/jz4740/Kconfig | 2 +- > sound/soc/jz4740/jz4740-i2s.c | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/sound/soc/jz4740/Kconfig b/sound/soc/jz4740/Kconfig > index 29144720cb62..e72f826062e9 100644 > --- a/sound/soc/jz4740/Kconfig > +++ b/sound/soc/jz4740/Kconfig > @@ -2,7 +2,7 @@ > config SND_JZ4740_SOC_I2S > tristate "SoC Audio (I2S protocol) for Ingenic JZ4740 SoC" > depends on MIPS || COMPILE_TEST > - depends on OF && HAS_IOMEM > + depends on HAS_IOMEM > select SND_SOC_GENERIC_DMAENGINE_PCM > help > Say Y if you want to use I2S protocol and I2S codec on Ingenic=20 > JZ4740 > diff --git a/sound/soc/jz4740/jz4740-i2s.c=20 > b/sound/soc/jz4740/jz4740-i2s.c > index 79afac0c5003..298ff0a83931 100644 > --- a/sound/soc/jz4740/jz4740-i2s.c > +++ b/sound/soc/jz4740/jz4740-i2s.c > @@ -5,10 +5,9 @@ >=20 > #include > #include > -#include > -#include > #include > #include > +#include > #include > #include >=20 > -- > 2.35.1 >=20