From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 401E7C433E0 for ; Thu, 14 Jan 2021 02:16:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AFDA23359 for ; Thu, 14 Jan 2021 02:16:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726705AbhANCPc (ORCPT ); Wed, 13 Jan 2021 21:15:32 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:37890 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728025AbhANCPT (ORCPT ); Wed, 13 Jan 2021 21:15:19 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 008CA279; Thu, 14 Jan 2021 03:14:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1610590478; bh=gGcX7lcfM0iCQ6q8iGJIajqVIFrdbyZylHHpNTEIpik=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i5SlE41ajy5bjEvDukqJQPhpniq53aElJj4GciYVmrfIDw1TQHV7dyL+sCvgouPSP xLM3nEuQKjFRgt80/rgBqQJIE0NiMe4BdPijMEgh6A19Y32SyQ6uFjhB5fHbbeesnY pTLwRxJsUfvdnN+oaWmHJue31NlkhQsbVzlEff9M= Date: Thu, 14 Jan 2021 04:14:20 +0200 From: Laurent Pinchart To: Ezequiel Garcia Cc: linux-media@vger.kernel.org, Hans Verkuil , kernel@collabora.com, Sakari Ailus Subject: Re: [PATCH 11/13] media: v4l2-async: Drop v4l2_fwnode_reference_parse_sensor_common mention Message-ID: References: <20210112132339.5621-1-ezequiel@collabora.com> <20210112132339.5621-12-ezequiel@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210112132339.5621-12-ezequiel@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Ezequiel, Thank you for the patch. On Tue, Jan 12, 2021 at 10:23:37AM -0300, Ezequiel Garcia wrote: > The v4l2_async_notifier_cleanup documentation mentions > v4l2_fwnode_reference_parse_sensor_common, which doesn't exist. > Drop it. The function is actually called v4l2_async_notifier_parse_fwnode_sensor_common(). It was introduced in commit 7a9ec808ad46 ("media: v4l: fwnode: Add convenience function for parsing common external refs") with an incorrect name in the documentation. Commit b064945517ee ("media: fix kernel-doc markups") fixed the kerneldoc header for the function, but forgot to address this location. > Signed-off-by: Ezequiel Garcia > --- > include/media/v4l2-async.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h > index 76be1e01222e..2429ac55be1c 100644 > --- a/include/media/v4l2-async.h > +++ b/include/media/v4l2-async.h > @@ -290,9 +290,8 @@ void v4l2_async_notifier_unregister(struct v4l2_async_notifier *notifier); > * sub-devices allocated for the purposes of the notifier but not the notifier > * itself. The user is responsible for calling this function to clean up the > * notifier after calling > - * @v4l2_async_notifier_add_subdev, > - * @v4l2_async_notifier_parse_fwnode_endpoints or > - * @v4l2_fwnode_reference_parse_sensor_common. > + * @v4l2_async_notifier_add_subdev or > + * @v4l2_async_notifier_parse_fwnode_endpoints. > * > * There is no harm from calling v4l2_async_notifier_cleanup in other > * cases as long as its memory has been zeroed after it has been -- Regards, Laurent Pinchart