From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11BAFC433DB for ; Thu, 14 Jan 2021 02:28:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4AF8235FA for ; Thu, 14 Jan 2021 02:28:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726825AbhANC2F (ORCPT ); Wed, 13 Jan 2021 21:28:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726720AbhANC2E (ORCPT ); Wed, 13 Jan 2021 21:28:04 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ADC0C061575 for ; Wed, 13 Jan 2021 18:27:24 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 332FF279; Thu, 14 Jan 2021 03:27:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1610591240; bh=lEb2m4CSKKvyQ0Et2/uywXnV+0/viNEoWKGIhwxk/4k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vB565s06ugrA3o04LU1aGnjJO3UYyKcK9po1PC/tGtP8SlcDncm2ZBIFo42rXsZjy aJ2y6rwhFPRsn+iCoO2uKASq6/javQNBjOFxv9N0o7qFjSeUbIPw/SlflbRuWK4GGH S7WLLx1JJGjyKhqMLAdvWb/1mUhYXhKtu7r39Dm4= Date: Thu, 14 Jan 2021 04:27:03 +0200 From: Laurent Pinchart To: Ezequiel Garcia Cc: linux-media@vger.kernel.org, Hans Verkuil , kernel@collabora.com, Sakari Ailus Subject: Re: [PATCH 13/13] media: v4l2-async: Discourage use of v4l2_async_notifier_add_subdev Message-ID: References: <20210112132339.5621-1-ezequiel@collabora.com> <20210112132339.5621-14-ezequiel@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210112132339.5621-14-ezequiel@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Ezequiel, Thank you for the patch. On Tue, Jan 12, 2021 at 10:23:39AM -0300, Ezequiel Garcia wrote: > Most -if not all- use-cases are expected to be covered by one of: > v4l2_async_notifier_add_fwnode_subdev, > v4l2_async_notifier_add_fwnode_remote_subdev, > v4l2_async_notifier_add_i2c_subdev or > v4l2_async_notifier_add_devname_subdev. > > We'd like to discourage drivers from using v4l2_async_notifier_add_subdev, > so rename it as __v4l2_async_notifier_add_subdev. This is > typically a good hint for drivers to avoid using the function. > > Signed-off-by: Ezequiel Garcia > --- > drivers/media/v4l2-core/v4l2-async.c | 10 +++++----- > drivers/media/v4l2-core/v4l2-fwnode.c | 2 +- > include/media/v4l2-async.h | 10 ++++++++-- > 3 files changed, 14 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c > index b325bacddff4..e8e690280922 100644 > --- a/drivers/media/v4l2-core/v4l2-async.c > +++ b/drivers/media/v4l2-core/v4l2-async.c > @@ -630,7 +630,7 @@ void v4l2_async_notifier_cleanup(struct v4l2_async_notifier *notifier) > } > EXPORT_SYMBOL_GPL(v4l2_async_notifier_cleanup); > > -int v4l2_async_notifier_add_subdev(struct v4l2_async_notifier *notifier, > +int __v4l2_async_notifier_add_subdev(struct v4l2_async_notifier *notifier, > struct v4l2_async_subdev *asd) > { > int ret; > @@ -647,7 +647,7 @@ int v4l2_async_notifier_add_subdev(struct v4l2_async_notifier *notifier, > mutex_unlock(&list_lock); > return ret; > } > -EXPORT_SYMBOL_GPL(v4l2_async_notifier_add_subdev); > +EXPORT_SYMBOL_GPL(__v4l2_async_notifier_add_subdev); > > struct v4l2_async_subdev * > v4l2_async_notifier_add_fwnode_subdev(struct v4l2_async_notifier *notifier, > @@ -664,7 +664,7 @@ v4l2_async_notifier_add_fwnode_subdev(struct v4l2_async_notifier *notifier, > asd->match_type = V4L2_ASYNC_MATCH_FWNODE; > asd->match.fwnode = fwnode_handle_get(fwnode); > > - ret = v4l2_async_notifier_add_subdev(notifier, asd); > + ret = __v4l2_async_notifier_add_subdev(notifier, asd); > if (ret) { > fwnode_handle_put(fwnode); > kfree(asd); > @@ -714,7 +714,7 @@ v4l2_async_notifier_add_i2c_subdev(struct v4l2_async_notifier *notifier, > asd->match.i2c.adapter_id = adapter_id; > asd->match.i2c.address = address; > > - ret = v4l2_async_notifier_add_subdev(notifier, asd); > + ret = __v4l2_async_notifier_add_subdev(notifier, asd); > if (ret) { > kfree(asd); > return ERR_PTR(ret); > @@ -739,7 +739,7 @@ v4l2_async_notifier_add_devname_subdev(struct v4l2_async_notifier *notifier, > asd->match_type = V4L2_ASYNC_MATCH_DEVNAME; > asd->match.device_name = device_name; > > - ret = v4l2_async_notifier_add_subdev(notifier, asd); > + ret = __v4l2_async_notifier_add_subdev(notifier, asd); > if (ret) { > kfree(asd); > return ERR_PTR(ret); > diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c > index 5353e37eb950..919fde20032e 100644 > --- a/drivers/media/v4l2-core/v4l2-fwnode.c > +++ b/drivers/media/v4l2-core/v4l2-fwnode.c > @@ -833,7 +833,7 @@ v4l2_async_notifier_fwnode_parse_endpoint(struct device *dev, > if (ret < 0) > goto out_err; > > - ret = v4l2_async_notifier_add_subdev(notifier, asd); > + ret = __v4l2_async_notifier_add_subdev(notifier, asd); > if (ret < 0) { > /* not an error if asd already exists */ > if (ret == -EEXIST) I wonder if v4l2-fwnode should be moved to videodev-objs in the Makefile, we could then avoid exporting __v4l2_async_notifier_add_subdev(). This doesn't need to be fixed here, Reviewed-by: Laurent Pinchart > diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h > index 1278f98355a7..9cf83f1ecca6 100644 > --- a/include/media/v4l2-async.h > +++ b/include/media/v4l2-async.h > @@ -161,17 +161,23 @@ void v4l2_async_debug_init(struct dentry *debugfs_dir); > void v4l2_async_notifier_init(struct v4l2_async_notifier *notifier); > > /** > - * v4l2_async_notifier_add_subdev - Add an async subdev to the > + * __v4l2_async_notifier_add_subdev - Add an async subdev to the > * notifier's master asd list. > * > * @notifier: pointer to &struct v4l2_async_notifier > * @asd: pointer to &struct v4l2_async_subdev > * > + * \warning: Drivers should avoid using this function and instead use one of: > + * @v4l2_async_notifier_add_fwnode_subdev, > + * @v4l2_async_notifier_add_fwnode_remote_subdev, > + * @v4l2_async_notifier_add_i2c_subdev or > + * @v4l2_async_notifier_add_devname_subdev. > + * > * Call this function before registering a notifier to link the provided @asd to > * the notifiers master @asd_list. The @asd must be allocated with k*alloc() as > * it will be freed by the framework when the notifier is destroyed. > */ > -int v4l2_async_notifier_add_subdev(struct v4l2_async_notifier *notifier, > +int __v4l2_async_notifier_add_subdev(struct v4l2_async_notifier *notifier, > struct v4l2_async_subdev *asd); > > /** -- Regards, Laurent Pinchart