From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E02D2C433DB for ; Tue, 12 Jan 2021 14:21:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CD882311E for ; Tue, 12 Jan 2021 14:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730108AbhALOVW (ORCPT ); Tue, 12 Jan 2021 09:21:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726119AbhALOVV (ORCPT ); Tue, 12 Jan 2021 09:21:21 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F124DC061786 for ; Tue, 12 Jan 2021 06:20:40 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id r4so2263806wmh.5 for ; Tue, 12 Jan 2021 06:20:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=lRZ3d22RXi2ViyjCaIZIVlAwq5J2EBopCK/yoHar0tk=; b=Tnor6WweTI6EMJ3JkUSAheTZoPtMvnhHIrNwk2GPdLYm+l8vUhui0OTuLf3VW2t7Zp LmrhMjocBU+y7mPLZkHzqBtelT3BCd/Js5+749EuC9BVTQcRZF3m0dMQyyg4QMYbGqze Wp+YMC/JMjblo0QMU4DCnvhZ+mVZmdkN7PQog= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=lRZ3d22RXi2ViyjCaIZIVlAwq5J2EBopCK/yoHar0tk=; b=FOv8VfEJDcybLoCAH3ypa769CxwveHYESs/srj8vwJAcmn0m/XhKYRzIFJP8u4DHBw jDWPCX+QkXm+EbYA6Agez4EelrWf6rd5NxN17LRrtxq9PYxyy+M704zqq8ijWufwt5Dn I5Q0wEatP38/Dfl46gjAIPJbzkZAM0qdzboKXMWf7PPHSxLPe5GCKyqs56TKkCs1kq/3 kdMgQ7m+39kwUJAYEvquyjtVqnnRaYkOqGzJpFrDNPNCIVaJpVMXG57OdMnRaaGW4mJX 34sg5laD20453ieLAG7Ipp9l2Nk27iJHsM4BFUlU6AXiBUvSrrHhnU3F6VY8XZF7lcy2 QC/A== X-Gm-Message-State: AOAM530bbhYGF1axLW+17rwkLPKd0GzqVmDGD1Ej4EzmckIUVN5Oct2l 14+EvY0CmEkTYiQvlNKMNE6CQ9MIQMJdyivy X-Google-Smtp-Source: ABdhPJy83/7uShpCX8AKV6iHS42oLbgL1kEyg4Xhn+9gXQjSyaPhkB95sv3erSdwA2vZlZOynSSvUQ== X-Received: by 2002:a1c:a501:: with SMTP id o1mr3840543wme.44.1610461239793; Tue, 12 Jan 2021 06:20:39 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id a17sm5486318wrs.20.2021.01.12.06.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 06:20:38 -0800 (PST) Date: Tue, 12 Jan 2021 15:20:36 +0100 From: Daniel Vetter To: "ZhiJie.Zhang" Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: Improve the output_poll_changed description Message-ID: Mail-Followup-To: "ZhiJie.Zhang" , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20210112104644.341345-1-zhangzhijie@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210112104644.341345-1-zhangzhijie@loongson.cn> X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 12, 2021 at 06:46:44PM +0800, ZhiJie.Zhang wrote: > From: zhangzhijie > > codeview the implementation of few Drivers. I'm not really understanding what you're trying to say here. > this callback was used by drm_kms_helper_hotplug_event() > > Signed-off-by: zhangzhijie > --- > include/drm/drm_mode_config.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > index ab424ddd7665..e01c4d0f07d1 100644 > --- a/include/drm/drm_mode_config.h > +++ b/include/drm/drm_mode_config.h > @@ -104,7 +104,7 @@ struct drm_mode_config_funcs { > * changes. > * > * Drivers implementing fbdev emulation with the helpers can call > - * drm_fb_helper_hotplug_changed from this hook to inform the fbdev > + * drm_kms_helper_hotplug_event() from this hook to inform the fbdev > * helper of output changes. I think since we touch this, maybe better to revamp it complete. The best way to handle all this is by registering a struct drm_client, since that provides the &drm_client_funcs.hotplug callback. Also for fbdev support drivers shouldn't even use that, but instead use the drm_fbdev_generic_setup() function, which takes care of everything. I think we can also remove the FIXME below, since with the drm_client infrastructure and the generic fbdev emulation we've resolved this all very neatly now. Can you please respin with my suggestions taking into account somehow? Thanks, Daniel > * > * FIXME: > -- > 2.29.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFC98C433E0 for ; Tue, 12 Jan 2021 14:20:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E7F123122 for ; Tue, 12 Jan 2021 14:20:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E7F123122 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 63AA06E24E; Tue, 12 Jan 2021 14:20:42 +0000 (UTC) Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by gabe.freedesktop.org (Postfix) with ESMTPS id 128266E23D for ; Tue, 12 Jan 2021 14:20:41 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id e25so2287474wme.0 for ; Tue, 12 Jan 2021 06:20:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=lRZ3d22RXi2ViyjCaIZIVlAwq5J2EBopCK/yoHar0tk=; b=Tnor6WweTI6EMJ3JkUSAheTZoPtMvnhHIrNwk2GPdLYm+l8vUhui0OTuLf3VW2t7Zp LmrhMjocBU+y7mPLZkHzqBtelT3BCd/Js5+749EuC9BVTQcRZF3m0dMQyyg4QMYbGqze Wp+YMC/JMjblo0QMU4DCnvhZ+mVZmdkN7PQog= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=lRZ3d22RXi2ViyjCaIZIVlAwq5J2EBopCK/yoHar0tk=; b=phnKErPUpPdxzMTL9iGuk9QizT1B/+7O1cfofP6hcjBGxyE/zSooz38oeohd/2JN8K wf5cfIfdwPOfm300mtmx4eTtWyEMzV/LTjr182K8C2jSgXgX/ayxymxi/DcGPjtf22TK j7E4bNwaJdjgq8zH771mDO6j8Rl88W58akhdWhIVw/pAIssTwhwY5l5OnJjRX0/6nvdY NsDTr4MVek8HxHL5aiY90LpChL6cYEmb3g1s3nC6v5xD7oMmP2eo6t8lbH5BdFFtmePm lWepQAmkZpu1KZvgtffFP+QqQVJg/HpfaH9fuw55WgYD0W/ooaRZMYuRDqyI/DdrBtkc EPag== X-Gm-Message-State: AOAM531zuQEIGU48Drk+wcVyxGgaTGmy2+56SHLwcatPOxne2mPI9F7h Vba5pmWL/RyKUH3Niu+quewCKg== X-Google-Smtp-Source: ABdhPJy83/7uShpCX8AKV6iHS42oLbgL1kEyg4Xhn+9gXQjSyaPhkB95sv3erSdwA2vZlZOynSSvUQ== X-Received: by 2002:a1c:a501:: with SMTP id o1mr3840543wme.44.1610461239793; Tue, 12 Jan 2021 06:20:39 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id a17sm5486318wrs.20.2021.01.12.06.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 06:20:38 -0800 (PST) Date: Tue, 12 Jan 2021 15:20:36 +0100 From: Daniel Vetter To: "ZhiJie.Zhang" Subject: Re: [PATCH] drm: Improve the output_poll_changed description Message-ID: Mail-Followup-To: "ZhiJie.Zhang" , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20210112104644.341345-1-zhangzhijie@loongson.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210112104644.341345-1-zhangzhijie@loongson.cn> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tzimmermann@suse.de, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 12, 2021 at 06:46:44PM +0800, ZhiJie.Zhang wrote: > From: zhangzhijie > > codeview the implementation of few Drivers. I'm not really understanding what you're trying to say here. > this callback was used by drm_kms_helper_hotplug_event() > > Signed-off-by: zhangzhijie > --- > include/drm/drm_mode_config.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > index ab424ddd7665..e01c4d0f07d1 100644 > --- a/include/drm/drm_mode_config.h > +++ b/include/drm/drm_mode_config.h > @@ -104,7 +104,7 @@ struct drm_mode_config_funcs { > * changes. > * > * Drivers implementing fbdev emulation with the helpers can call > - * drm_fb_helper_hotplug_changed from this hook to inform the fbdev > + * drm_kms_helper_hotplug_event() from this hook to inform the fbdev > * helper of output changes. I think since we touch this, maybe better to revamp it complete. The best way to handle all this is by registering a struct drm_client, since that provides the &drm_client_funcs.hotplug callback. Also for fbdev support drivers shouldn't even use that, but instead use the drm_fbdev_generic_setup() function, which takes care of everything. I think we can also remove the FIXME below, since with the drm_client infrastructure and the generic fbdev emulation we've resolved this all very neatly now. Can you please respin with my suggestions taking into account somehow? Thanks, Daniel > * > * FIXME: > -- > 2.29.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel