From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12F22C433E6 for ; Tue, 5 Jan 2021 15:38:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D217D227C3 for ; Tue, 5 Jan 2021 15:38:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728557AbhAEPiK (ORCPT ); Tue, 5 Jan 2021 10:38:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728412AbhAEPiH (ORCPT ); Tue, 5 Jan 2021 10:38:07 -0500 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43C77C061574; Tue, 5 Jan 2021 07:37:27 -0800 (PST) Received: by mail-qk1-x72d.google.com with SMTP id v126so26734437qkd.11; Tue, 05 Jan 2021 07:37:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OkXL1EFyZinDOQMdya4rZdvw/dJev0p82LTHbe0DFao=; b=KJ6P2nu2S3iBxkYTpfSqP+V+xlOKYWA3Y5MKfCdWSvI20X4BmnSw0FBdKZ2tiysa/u OHtFo4qwvv/ETi6a+9k8DHlc0dOgavjgIi4Dmsuxzw3DQm22Mryu88ADMBb7+VjglpwI Q2wQ2S7LVuAtL6vQcxNqa/Tjj/PGjwWasP5OTH8FaWQuaeAtL+4sK9cvDCN1/+dpHSu8 ZE0RhTN9bEQ7ImcQS0qmZjyWUUbY5L5H0x2xkBlXMHzUJ2oXExF+xTHINcglxBablW0w QYqq2IEmch/yoe5fAfdRu5Ejp6jDeedkfgWQQ3zJBUssG70masoUfUcmR1VV9/uXuLKg piuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=OkXL1EFyZinDOQMdya4rZdvw/dJev0p82LTHbe0DFao=; b=csybmMIOx3U6jozsh7jeGT6AdAF8DD42COdqe2tf1xU0k3Ws1KdYpxmJ04NlzyBSCV KG/jPpAFrie29sYalrGKap+0ZkXqX+Q+mTgsHOzTlY7Damx+daZlLC9QaCYwWfKWS4xE 0qXjYOiArzcwnRMpRSZRllqpqMzxxdwQ6c6v8m+lPI9qFr0xOlTezInICYHDMUPDKA5v etkzhH/V+yooTLwzEAe4OFvSU0QVftC2pmIe+JP4XWgwheRgbcw7iumK6Lee5UiXKEtH XXi0XExFh1JC+brmZ8+LHJhorv+qOPLRvXdkukc5zQPx8JZHJH23EvjrBcuWN4g1w/BN WFVg== X-Gm-Message-State: AOAM532uvlhMiXERE6flZei1uE18iIKlR9B3sQNf83sB3za0+sZB/K/W ST2yhmxdXCCzC/xxYmyrLDE= X-Google-Smtp-Source: ABdhPJzw2/nGtWwAC4dfC2TVBj+Emx4Ao/FIkSFzpZCfTwUBlCU6BbWkVTJK7u+fv0xNDXfYhOPP5g== X-Received: by 2002:a05:620a:11ad:: with SMTP id c13mr104956qkk.134.1609861046219; Tue, 05 Jan 2021 07:37:26 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:ce7b]) by smtp.gmail.com with ESMTPSA id j124sm143633qkf.113.2021.01.05.07.37.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jan 2021 07:37:24 -0800 (PST) Sender: Tejun Heo Date: Tue, 5 Jan 2021 10:36:40 -0500 From: Tejun Heo To: Vipin Sharma Cc: David Rientjes , Christian Borntraeger , Tom Lendacky , Brijesh , Jon , Eric , pbonzini@redhat.com, Sean Christopherson , lizefan@huawei.com, hannes@cmpxchg.org, Janosch Frank , corbet@lwn.net, joro@8bytes.org, vkuznets@redhat.com, wanpengli@tencent.com, Jim Mattson , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, Matt Gingell , Dionna Glaze , kvm@vger.kernel.org, x86@kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v3 0/2] cgroup: KVM: New Encryption IDs cgroup controller Message-ID: References: <20201209205413.3391139-1-vipinsh@google.com> <4f7b9c3f-200e-6127-1d94-91dd9c917921@de.ibm.com> <5f8d4cba-d3f-61c2-f97-fdb338fec9b8@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Happy new year! On Wed, Dec 16, 2020 at 12:02:37PM -0800, Vipin Sharma wrote: > I like the idea of having a separate controller to keep the code simple and > easier for maintenance. Yeah, the more I think about it, keeping it separate seems like the right thing to do. What bothers me primarily is that the internal logic is identical between the RDMA controller and this one. If you wanna try factoring them out into library, great. If not, I don't think it should block merging this controller. We can get to refactoring later. Thanks. -- tejun