All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benson Leung <bleung@google.com>
To: Prashant Malani <pmalani@chromium.org>
Cc: Utkarsh Patel <utkarsh.h.patel@intel.com>,
	linux-kernel@vger.kernel.org, enric.balletbo@collabora.com,
	bleung@chromium.org, heikki.krogerus@linux.intel.com,
	rajmohan.mani@intel.com, gwendal@chromium.org
Subject: Re: [PATCH 2/2] platform/chrome: cros_ec_typec: Send mux configuration acknowledgment to EC
Date: Tue, 5 Jan 2021 14:41:22 -0800	[thread overview]
Message-ID: <X/TrEgQf5l8yHKrx@google.com> (raw)
In-Reply-To: <X+FBsu+VNsEJlgBp@google.com>

[-- Attachment #1: Type: text/plain, Size: 1730 bytes --]

Hi Prashant and Utkarash,

On Mon, Dec 21, 2020 at 04:45:38PM -0800, Prashant Malani wrote:
> Hi Utkarsh,
> 
> On Wed, Dec 09, 2020 at 10:09:03PM -0800, Utkarsh Patel wrote:
> > In some corner cases downgrade of the superspeed typec device(e.g. Dell
> > typec Dock, apple dongle) was seen because before the SOC mux configuration
> > finishes, EC starts configuring the next mux state.
> > 
> > With this change, once the SOC mux is configured, kernel will send an
> > acknowledgment to EC via Host command EC_CMD_USB_PD_MUX_ACK [1].
> > After sending the host event EC will wait for the acknowledgment from
> > kernel before starting the PD negotiation for the next mux state. This
> > helps to have a framework to build better error handling along with the
> > synchronization of timing sensitive mux states.
> > 
> > This change also brings in corresponding EC header updates from the EC code
> > base [1].
> > 
> > [1]:
> > https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/master/include/ec_commands.h
> > 
> > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
> 
> I'm not sure what the maintainers' preference is for the header (same
> patch or separate patch). FWIW:
> 
> Reviewed-by: Prashant Malani <pmalani@chromium.org>

I asked Gwendal to look over this change. It looks good to him, so I've gone
ahead and merged it.

At some point we have to completely sync ec_commands.h, but the change here
is well contained, so it minimally adds to the delta between the EC codebase's
header and the kernel's.

Thanks,
Benson
-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2021-01-05 22:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10  6:09 [PATCH 0/2] Send acknowledgment to ec from cors_ec_typec Utkarsh Patel
2020-12-10  6:09 ` [PATCH 1/2] platform/chrome: cros_ec_typec: Parameterize cros_typec_cmds_supported() Utkarsh Patel
2020-12-22  0:44   ` Prashant Malani
2020-12-10  6:09 ` [PATCH 2/2] platform/chrome: cros_ec_typec: Send mux configuration acknowledgment to EC Utkarsh Patel
2020-12-22  0:45   ` Prashant Malani
2021-01-05 22:41     ` Benson Leung [this message]
2021-01-05 22:50   ` Benson Leung
2021-01-06 21:17     ` Patel, Utkarsh H
2021-01-05 22:35 ` [PATCH 0/2] Send acknowledgment to ec from cors_ec_typec Benson Leung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X/TrEgQf5l8yHKrx@google.com \
    --to=bleung@google.com \
    --cc=bleung@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=gwendal@chromium.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmalani@chromium.org \
    --cc=rajmohan.mani@intel.com \
    --cc=utkarsh.h.patel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.