From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9657C433DB for ; Wed, 6 Jan 2021 18:46:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7698F23124 for ; Wed, 6 Jan 2021 18:46:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727085AbhAFSqB (ORCPT ); Wed, 6 Jan 2021 13:46:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726999AbhAFSqA (ORCPT ); Wed, 6 Jan 2021 13:46:00 -0500 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F502C061357 for ; Wed, 6 Jan 2021 10:45:20 -0800 (PST) Received: by mail-pf1-x429.google.com with SMTP id m6so2215000pfm.6 for ; Wed, 06 Jan 2021 10:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ho+xRsAlnZPA9XwreJh6lam3mNeyMrjUZb8gp0Pijj4=; b=pp1lm1jkJ+G032pTcswwk6Ab4cZJqTQ98WbtBympCzpKmXncEcv6qCTKzdSbVOifHF uO+nl+4aB9LlmW27p+QnG2+/nu8cKCtE16/9E02D0atV5oYdFrwqTeb1hcvmgQQjdytE BP1rIL3zXJL23b5bAWRaM36ihs/hLE+PLKsZFbf/TciuW23P2ye6vkAHfsnLnFQiw8op SaTOOnQnWIsFOuYSjlppUh85Nmnt1nhpBQbFhMgLCW6419x2Pc3B2b/hRpknb8qcl2/J v0XFc/9O3QoVmWuvbjNFMHTi5AJ8M6U2jnYB8YoB90TeBavfL516zS3wbFWGmGUCg3im GPtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ho+xRsAlnZPA9XwreJh6lam3mNeyMrjUZb8gp0Pijj4=; b=tZ5qkZiaOxjcKMrZY5pzY2Hqf1tbPmJtd9I5Ekk7UtqM0a/LqC95MMYP78BQqTWHOw MB1rf33WZlWRh2YVMAfQ06bLG3W8aEchdspNFd7dlBJAMJ9xffbUQDznOU6/DpMbuqYI IerlDt4sBNi5GiHQfrXysN6xuwvU9lINBLz2AJAW4DgV0+T+96uuyd1PwrLXFUPM5oD7 bzceWM0/ly1yUC5JsjjVyhuut/kxBKyowjrv/tMPd69+lnr7X+MpKOiBWUqcQPpbwDhP uxuBYBRcQCRKSYkgWPUGZMN6/uklDtFD2OEowSOSNv0BJ7fRx+QuXLU0EVL3kZdvxw4d Vshg== X-Gm-Message-State: AOAM533qXbdvULY7k85TpHmo99tS9IOkKiFR11+qKa8+bVjRlq3IgQks qxiVGkNBK9Adpk484pZTwAdc+g== X-Google-Smtp-Source: ABdhPJwtNkxU+RDoHsd2aWmLEUDActU8ItlTVYihGE3QCDrRNmO5CRDj6A156uPcWiMvJZXbiH69+g== X-Received: by 2002:a63:1261:: with SMTP id 33mr5797347pgs.213.1609958719939; Wed, 06 Jan 2021 10:45:19 -0800 (PST) Received: from google.com ([2620:0:1008:10:1ea0:b8ff:fe75:b885]) by smtp.gmail.com with ESMTPSA id 21sm3299297pfx.84.2021.01.06.10.45.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jan 2021 10:45:19 -0800 (PST) Date: Wed, 6 Jan 2021 10:45:14 -0800 From: Vipin Sharma To: Tejun Heo Cc: David Rientjes , Christian Borntraeger , Tom Lendacky , Brijesh , Jon , Eric , pbonzini@redhat.com, Sean Christopherson , lizefan@huawei.com, hannes@cmpxchg.org, Janosch Frank , corbet@lwn.net, joro@8bytes.org, vkuznets@redhat.com, wanpengli@tencent.com, Jim Mattson , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, Matt Gingell , Dionna Glaze , kvm@vger.kernel.org, x86@kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v3 0/2] cgroup: KVM: New Encryption IDs cgroup controller Message-ID: References: <20201209205413.3391139-1-vipinsh@google.com> <4f7b9c3f-200e-6127-1d94-91dd9c917921@de.ibm.com> <5f8d4cba-d3f-61c2-f97-fdb338fec9b8@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 05, 2021 at 10:36:40AM -0500, Tejun Heo wrote: > Happy new year! > > On Wed, Dec 16, 2020 at 12:02:37PM -0800, Vipin Sharma wrote: > > I like the idea of having a separate controller to keep the code simple and > > easier for maintenance. > > Yeah, the more I think about it, keeping it separate seems like the right > thing to do. What bothers me primarily is that the internal logic is > identical between the RDMA controller and this one. If you wanna try > factoring them out into library, great. If not, I don't think it should > block merging this controller. We can get to refactoring later. > Happy new year! Sounds great, I will send out a new patch which will not reject the new max limit based on the current usage. It will not include refactoring out common code between RDMA and Encryption ID controller. We can pursue that later. Thanks Vipin