From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB0DCC433E0 for ; Thu, 7 Jan 2021 17:03:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92E8922C9F for ; Thu, 7 Jan 2021 17:03:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92E8922C9F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DB6EC6E4B0; Thu, 7 Jan 2021 17:03:52 +0000 (UTC) Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3271E6E4B0 for ; Thu, 7 Jan 2021 17:03:52 +0000 (UTC) Received: by mail-wm1-x32c.google.com with SMTP id c124so5749221wma.5 for ; Thu, 07 Jan 2021 09:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+lEZ7oIvKm2BBIytBd5KhhxEP920NiQD+2lcPsM6TpM=; b=aXGyCa495ZG85l0b9GcSnWCF+vWITZULQ1jgeIWz30mtovFXithyYA7NDdkUYSsaiA 2q64Udru2WyZIrndsVRfcTalMAbqLk3mrYzPGFtzY3P70nTf0CQzMKxAGSzwONuw7eCo 9j0clCA/wW0uujhaNReSTPsTzxojlJT6wQfuA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+lEZ7oIvKm2BBIytBd5KhhxEP920NiQD+2lcPsM6TpM=; b=QZMT/KL6+2NXGz4FKH2G5twkSYfKgCtzRxP/SE+Bcg7g8HRNlujjweN7/T75ZnO3Yj bsZAM9LFVPViIONUe9GVBERNFgA5Mjx0FlR6IWDQ0Kgg7yYGRwT8SqmCvwwlrxdWhftl 2aCCKCQF2IBH75bur0vrqhHFWm5YtoECR0+A7QRCQL0gYJP+AlmUueReJBCY0XZsqcup XiCY0rHVf1oxXG8KT/OVoiW10AnQL54VcGbGBKNrrBITkd0FiY0blSs2g9hkjteFdRSs isDsXtVGS9GBgrHJxH3UtV5iOmSJyN+Th+IWUuvm6CEOzfu0Agd6RrhY3ijp36qq2+OV +bqQ== X-Gm-Message-State: AOAM531QvUMLJ5K3PZwNVIrBv+db9etolGaoIOv7NBhyswQFh5qdKSfO Na/2JO4nbZIECcaE7xRkbiPaQQ== X-Google-Smtp-Source: ABdhPJyZFJXjWI6KjgND1aIwwBqaBBETfIkkhLqYzm4hEc6WVovvc8CMhcP9MW9VeHf95jD4+hqFVA== X-Received: by 2002:a1c:8085:: with SMTP id b127mr8623554wmd.16.1610039030885; Thu, 07 Jan 2021 09:03:50 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id n11sm10279071wra.9.2021.01.07.09.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jan 2021 09:03:50 -0800 (PST) Date: Thu, 7 Jan 2021 18:03:48 +0100 From: Daniel Vetter To: Tian Tao Subject: Re: [PATCH] drm/qxl: Use managed mode-config init Message-ID: References: <1609153481-9909-1-git-send-email-tiantao6@hisilicon.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1609153481-9909-1-git-send-email-tiantao6@hisilicon.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, airlied@redhat.com, dri-devel@lists.freedesktop.org, kraxel@redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Dec 28, 2020 at 07:04:41PM +0800, Tian Tao wrote: > Using drmm_mode_config_init() sets up managed release of modesetting > resources. > > Signed-off-by: Tian Tao This changes the order of the cleanup actions, so most likely will break really badly. You can only move a cleanup action safely over to drmm_ if it is the last thing (at the time the patch is applied) done before cleanup is finished. There's a _lot_ of code that's run after qxl_modeset_fini. -Daniel > --- > drivers/gpu/drm/qxl/qxl_display.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c > index 012bce0..38d6b59 100644 > --- a/drivers/gpu/drm/qxl/qxl_display.c > +++ b/drivers/gpu/drm/qxl/qxl_display.c > @@ -1195,7 +1195,9 @@ int qxl_modeset_init(struct qxl_device *qdev) > int i; > int ret; > > - drm_mode_config_init(&qdev->ddev); > + ret = drmm_mode_config_init(&qdev->ddev); > + if (ret) > + return ret; > > ret = qxl_create_monitors_object(qdev); > if (ret) > @@ -1228,5 +1230,4 @@ int qxl_modeset_init(struct qxl_device *qdev) > void qxl_modeset_fini(struct qxl_device *qdev) > { > qxl_destroy_monitors_object(qdev); > - drm_mode_config_cleanup(&qdev->ddev); > } > -- > 2.7.4 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel