From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A46FBC433E0 for ; Thu, 7 Jan 2021 19:36:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6462723441 for ; Thu, 7 Jan 2021 19:36:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728751AbhAGTgZ (ORCPT ); Thu, 7 Jan 2021 14:36:25 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:55696 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726386AbhAGTgZ (ORCPT ); Thu, 7 Jan 2021 14:36:25 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kxb4Q-00Gjcy-AB; Thu, 07 Jan 2021 20:35:42 +0100 Date: Thu, 7 Jan 2021 20:35:42 +0100 From: Andrew Lunn To: M Chetan Kumar Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, johannes@sipsolutions.net, krishna.c.sudi@intel.com Subject: Re: [PATCH 07/18] net: iosm: char device for FW flash & coredump Message-ID: References: <20210107170523.26531-1-m.chetan.kumar@intel.com> <20210107170523.26531-8-m.chetan.kumar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210107170523.26531-8-m.chetan.kumar@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Jan 07, 2021 at 10:35:12PM +0530, M Chetan Kumar wrote: > Implements a char device for flashing Modem FW image while Device > is in boot rom phase and for collecting traces on modem crash. Since this is a network device, you might want to take a look at devlink support for flashing devices. https://www.kernel.org/doc/html/latest/networking/devlink/devlink-flash.html And for collecting crashes and other health information, consider devlink region and devlink health. It is much better to reuse existing infrastructure than do something proprietary with a char dev. Andrew