From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB9CC433E6 for ; Thu, 7 Jan 2021 21:57:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E358D23435 for ; Thu, 7 Jan 2021 21:57:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727297AbhAGV5D (ORCPT ); Thu, 7 Jan 2021 16:57:03 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:55880 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726646AbhAGV5D (ORCPT ); Thu, 7 Jan 2021 16:57:03 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kxdGV-00Gkzs-9H; Thu, 07 Jan 2021 22:56:19 +0100 Date: Thu, 7 Jan 2021 22:56:19 +0100 From: Andrew Lunn To: M Chetan Kumar Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, johannes@sipsolutions.net, krishna.c.sudi@intel.com Subject: Re: [PATCH 11/18] net: iosm: encode or decode datagram Message-ID: References: <20210107170523.26531-1-m.chetan.kumar@intel.com> <20210107170523.26531-12-m.chetan.kumar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210107170523.26531-12-m.chetan.kumar@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > +/* Pass the DL packet to the netif layer. */ > +static int mux_net_receive(struct iosm_mux *ipc_mux, int if_id, > + struct iosm_wwan *wwan, u32 offset, u8 service_class, > + struct sk_buff *skb) > +{ > + /* for "zero copy" use clone */ > + struct sk_buff *dest_skb = skb_clone(skb, GFP_ATOMIC); > + > + if (!dest_skb) > + return -1; > + > + skb_pull(dest_skb, offset); > + > + skb_set_tail_pointer(dest_skb, dest_skb->len); > + > + /* Goto the start of the Ethernet header. */ > + skb_push(dest_skb, ETH_HLEN); > + > + /* map session to vlan */ > + __vlan_hwaccel_put_tag(dest_skb, htons(ETH_P_8021Q), if_id + 1); Well, that explains a bit, my comments on the netdev patch. So there is no Ethernet header on the 'wire'. This is not an Ethernet device at all. More in the documentation patch... Andrew