From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Danielle Ratson <danieller@mellanox.com>,
netdev@vger.kernel.org, davem@davemloft.net, jiri@nvidia.com,
f.fainelli@gmail.com, mkubecek@suse.cz, mlxsw@nvidia.com,
idosch@nvidia.com, Danielle Ratson <danieller@nvidia.com>
Subject: Re: [PATCH net-next repost v2 2/7] ethtool: Get link mode in use instead of speed and duplex parameters
Date: Fri, 8 Jan 2021 02:11:39 +0100 [thread overview]
Message-ID: <X/exS1VmkmxCI8TK@lunn.ch> (raw)
In-Reply-To: <20210107164240.17fcda6e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
> > diff --git a/Documentation/networking/ethtool-netlink.rst b/Documentation/networking/ethtool-netlink.rst
> > index 05073482db05..c21e71e0c0e8 100644
> > --- a/Documentation/networking/ethtool-netlink.rst
> > +++ b/Documentation/networking/ethtool-netlink.rst
> > @@ -406,6 +406,7 @@ Kernel response contents:
> > ``ETHTOOL_A_LINKMODES_PEER`` bitset partner link modes
> > ``ETHTOOL_A_LINKMODES_SPEED`` u32 link speed (Mb/s)
> > ``ETHTOOL_A_LINKMODES_DUPLEX`` u8 duplex mode
> > + ``ETHTOOL_A_LINKMODES_LINK_MODE`` u8 link mode
>
> Are there other places in the uapi we already limit ourselves to
> u8 / max 255? Otherwise u32 is better, the nlattr will be padded,
> anyway.
Only allowing 255 values might be too limiting. We already have 91 of
them. It was initially thought that 32 would be enough, and fixing
that limitation was a lot of work.
Andrew
next prev parent reply other threads:[~2021-01-08 1:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 13:06 [PATCH net-next repost v2 0/7] Support setting lanes via ethtool Danielle Ratson
2021-01-06 13:06 ` [PATCH net-next repost v2 1/7] ethtool: Extend link modes settings uAPI with lanes Danielle Ratson
2021-01-08 0:35 ` Jakub Kicinski
2021-01-11 14:00 ` Danielle Ratson
2021-01-11 17:57 ` Jakub Kicinski
2021-01-06 13:06 ` [PATCH net-next repost v2 2/7] ethtool: Get link mode in use instead of speed and duplex parameters Danielle Ratson
2021-01-08 0:42 ` Jakub Kicinski
2021-01-08 1:11 ` Andrew Lunn [this message]
2021-01-06 13:06 ` [PATCH net-next repost v2 3/7] ethtool: Expose the number of lanes in use Danielle Ratson
2021-01-06 13:06 ` [PATCH net-next repost v2 4/7] mlxsw: ethtool: Remove max lanes filtering Danielle Ratson
2021-01-06 13:06 ` [PATCH net-next repost v2 5/7] mlxsw: ethtool: Add support for setting lanes when autoneg is off Danielle Ratson
2021-01-06 13:06 ` [PATCH net-next repost v2 6/7] mlxsw: ethtool: Pass link mode in use to ethtool Danielle Ratson
2021-01-06 13:06 ` [PATCH net-next repost v2 7/7] net: selftests: Add lanes setting test Danielle Ratson
2021-01-08 0:45 ` Jakub Kicinski
2021-01-10 12:35 ` Danielle Ratson
2021-01-07 17:36 ` [PATCH net-next repost v2 0/7] Support setting lanes via ethtool Edwin Peer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/exS1VmkmxCI8TK@lunn.ch \
--to=andrew@lunn.ch \
--cc=danieller@mellanox.com \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.