All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Nika Layzell via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org, "Nika Layzell" <nika@thelayzells.com>
Subject: Re: Cc'ing the Git maintainer on GitGitGadget contributions, was Re: [PATCH 0/1] add--interactive: skip index refresh in reset patch mode
Date: Fri, 8 Jan 2021 15:08:46 -0500	[thread overview]
Message-ID: <X/i7zvgMJHfOmyZG@nand.local> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2101081534380.2213@tvgsbejvaqbjf.bet>

On Fri, Jan 08, 2021 at 03:56:20PM +0100, Johannes Schindelin wrote:
> Hi Junio,
>
> On Thu, 7 Jan 2021, Junio C Hamano wrote:
>
> > We may not be able to automate the thinking part to decide when
> > submitter may want to get help, but an automation can help by giving
> > the submitter cues and clues when to ask for help and from whom.
>
> I fear that we're striking the balance on the side of expecting too much
> knowledge about project-specific lore from contributors.

I think that this could be reasonably addressed. When someone opens a PR
(but before the hit /submit), GGG could say:

    Your change touches these files, and so suggested reviewers include
    X, Y, Z. When you believe your submission is in its last round,
    please also include the maintainer, M.

> We already have a ticket suggesting to add reviewers:
> https://github.com/gitgitgadget/gitgitgadget/issues/219
>
> With this suggestion, too, we could go and extend that wall of text even
> further and expect contributors to just know what they are supposed to do.
> But I don't see how that would make this process more inviting to new
> contributors.

Yeah, I agree that adding this as a separate step does not make sense,
since it's hard to discover such things (especially by individuals who
merely want to send a single contribution to the project). Having this
happen automatically upon creating a PR would make more sense to me.

Thanks,
Taylor

  parent reply	other threads:[~2021-01-08 20:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23 19:56 [PATCH 0/1] add--interactive: skip index refresh in reset patch mode Nika Layzell via GitGitGadget
2019-11-23 19:56 ` [PATCH 1/1] " Nika Layzell via GitGitGadget
2019-11-24  6:01 ` [PATCH 0/1] " Junio C Hamano
2019-11-25 14:24   ` Johannes Schindelin
2019-11-25 14:45     ` Johannes Schindelin
2019-11-26  1:13       ` Junio C Hamano
2021-01-07 14:18         ` Cc'ing the Git maintainer on GitGitGadget contributions, was " Johannes Schindelin
2021-01-07 14:57           ` Ævar Arnfjörð Bjarmason
2021-01-07 16:20             ` Johannes Schindelin
2021-01-07 21:25               ` Junio C Hamano
2021-01-08 14:56                 ` Johannes Schindelin
2021-01-08 19:48                   ` Junio C Hamano
2021-01-10 12:02                     ` Johannes Schindelin
2021-01-08 20:08                   ` Taylor Blau [this message]
2021-01-10 12:21                     ` Johannes Schindelin
2021-01-10 20:18                       ` Junio C Hamano
2021-01-11 19:18                         ` Taylor Blau
2021-01-12 23:22                           ` Junio C Hamano
2021-01-14  6:32                         ` 胡哲宁
2019-11-26  1:12     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X/i7zvgMJHfOmyZG@nand.local \
    --to=me@ttaylorr.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=nika@thelayzells.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.