All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Matyukevich <geomatsi@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 02/11] boot/mv-ddr-marvell: Bump to HEAD as of 20201207
Date: Sun, 10 Jan 2021 13:09:51 +0300	[thread overview]
Message-ID: <X/rSb+XAGWY16Hep@curiosity> (raw)
In-Reply-To: <cGJJkB-og8Jn4-_QkIs51CQXDaGcbNU611Z7EItf9_VAvIcfmnDOq2ikgutqZVlNQXds65qfBwogvb6QZhYswMLsMeb-evjf_8NEAJsqVok=@senzilla.io>

Hello Dick,

> > My apologies for the late feedback. This change breaks the
> > build for MacchiatoBin board. I guess it also breaks the
> > build for ClearFrog GT 8k board. The reason is straightforward: > both boards make use of Marvell ATF v18.12.x which is
> > compatible with mv-ddr-marvell release devel-18.12.x.
> > Your change bumps mv-ddr-marvell version, however the new
> > version is not compatible with older Marvell ATF release since
> > mv_ddr_topology_map structure has been changed.
> 
> I'm very sorry for breaking this! I thought I tested a build with the original MacchiatoBin defconfig, but clearly my testing was flawed!
> 
> > Could you please clarify the reason behind this change ? There
> > are no users for mv-ddr-marvell other than Marvell ATF that is
> > used only for MacchiatoBin and ClearFrog GT 8k boards. So on
> > the first glance it looks like this change has been introduced
> > as an accompanying update/cleanup during your work on adding
> > EDK2 firmware.
> 
> Bumping to a later version of mv-ddr-marvell was required in
> order to successfully built with mainline ATF, which in turn is
> required in order to build well with the latest release of EDK2.
> Based on my brief analysis, most of the patches in Marvell's ATF
> has made it upstream to ATF v2.4 (or earlier). So I thought the
> best and most secure approach would be to use mainline.

As I mentioned, so far there were just two users of mv-ddr-marvell:
defconfigs for MacchiatoBin and ClearFrog GT 8k. And both of them used
Marvell ATF. It looks like test_atf.py still uses Marvell ATF as well.
So could you please clarify this point ? Am I correct assuming that
you have some defconfigs that are not yet in mainline buildroot,
enabling both EDK2 and mv-ddr-marvell ?

> > If so, then I would suggest to revert this particular commit.
> > Let me know if you have any objections for this change.
> 
> May I propose that we "roll-forward" instead, and update all
> Marvell defconfigs to use mainline ATF instead? I believe this
> would add the most value for Buildroot users, having access to
> the latest and most stable fixes. What do you think?

I see that Baruch has already updated ClearFrog GT 8k to use mainline
ATF. So I will just do the same for MacchiatoBin. Though I guess there
might be some issues with PCIe support for MacchiatoBin board since
upstream ATF does not yet include Marvell PCIe drivers.

Regards,
Sergey

  parent reply	other threads:[~2021-01-10 10:09 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 20:27 [Buildroot] [PATCH v3 00/11] Introduce EDK2 firmware package Dick Olsson
2020-12-18 20:27 ` [Buildroot] [PATCH v3 01/11] boot/arm-trusted-firmware: Bump to version 2.4 Dick Olsson
2020-12-30  9:30   ` Yann E. MORIN
2020-12-18 20:27 ` [Buildroot] [PATCH v3 02/11] boot/mv-ddr-marvell: Bump to HEAD as of 20201207 Dick Olsson
2020-12-30  9:30   ` Yann E. MORIN
2021-01-09 13:32   ` Sergey Matyukevich
2021-01-10  9:37     ` D. Olsson
2021-01-10  9:47       ` Baruch Siach
2021-01-10 10:09       ` Sergey Matyukevich [this message]
2020-12-18 20:27 ` [Buildroot] [PATCH v3 03/11] package/edk2-platforms: new package Dick Olsson
2020-12-30 13:39   ` Yann E. MORIN
2020-12-18 20:27 ` [Buildroot] [PATCH v3 04/11] boot/edk2: " Dick Olsson
2020-12-30 10:51   ` Yann E. MORIN
2020-12-30 20:22     ` D. Olsson
2020-12-30 21:30       ` Yann E. MORIN
2020-12-18 20:27 ` [Buildroot] [PATCH v3 05/11] configs/aarch64_efi_defconfig: build the EDK2 firmware from source Dick Olsson
2020-12-30 12:54   ` Yann E. MORIN
2020-12-18 20:27 ` [Buildroot] [PATCH v3 06/11] configs/pc_x86_64_defconfig: " Dick Olsson
2020-12-18 20:27 ` [Buildroot] [PATCH v3 07/11] boot/arm-trusted-firmware: add EDK2 as BL33 option Dick Olsson
2020-12-30 13:00   ` Yann E. MORIN
2020-12-18 20:27 ` [Buildroot] [PATCH v3 08/11] configs/qemu_aarch64_sbsa_defconfig: new config for QEMU sbsa-ref Dick Olsson
2020-12-30 13:11   ` Yann E. MORIN
2020-12-18 20:27 ` [Buildroot] [PATCH v3 09/11] configs/qemu_aarch64_virt_efi_defconfig: new config for QEMU Virt EFI Dick Olsson
2020-12-30 13:30   ` Yann E. MORIN
2021-01-05  9:09     ` D. Olsson
2020-12-18 20:28 ` [Buildroot] [PATCH v3 10/11] configs/socionext_developerbox_defconfig: new config for Developerbox Dick Olsson
2020-12-18 20:28 ` [Buildroot] [PATCH v3 11/11] configs/solidrun_macchiatobin_efi_defconfig: EFI config for MacchiatoBin Dick Olsson
2020-12-19 18:08   ` Baruch Siach
2020-12-30 13:41 ` [Buildroot] [PATCH v3 00/11] Introduce EDK2 firmware package Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X/rSb+XAGWY16Hep@curiosity \
    --to=geomatsi@gmail.com \
    --cc=buildroot@busybox.net \
    --subject='Re: [Buildroot] [PATCH v3 02/11] boot/mv-ddr-marvell: Bump to HEAD as of 20201207' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.