All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Pho Tran <Pho.Tran@silabs.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Hung Nguyen <Hung.Nguyen@silabs.com>,
	Tung Pham <Tung.Pham@silabs.com>
Subject: Re: [PATCH] USB: otg: Fix error 32 when enable hardware flow control.
Date: Mon, 11 Jan 2021 11:16:02 +0100	[thread overview]
Message-ID: <X/wlYs1zerpM9jew@hovoldconsulting.com> (raw)
In-Reply-To: <C429CBAD-FE44-42AE-909C-4C33052A7413@silabs.com>

On Mon, Jan 11, 2021 at 04:55:22AM +0000, Pho Tran wrote:
> When hardware flow control is enabled,
> don't allow host send MHS command to cp210x.

You're commit message needs to explain *why* this is needed (and not
just say *what* the patch does).
 
> Signed-off-by: Pho Tran<pho.tran@silabs.com>

Also fix up the Subject prefix.

Johan

      parent reply	other threads:[~2021-01-11 10:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11  4:55 [PATCH] USB: otg: Fix error 32 when enable hardware flow control Pho Tran
2021-01-11  7:14 ` gregkh
2021-01-11 10:16 ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X/wlYs1zerpM9jew@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=Hung.Nguyen@silabs.com \
    --cc=Pho.Tran@silabs.com \
    --cc=Tung.Pham@silabs.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.