From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 199A7C433E6 for ; Mon, 11 Jan 2021 18:08:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E697A2250E for ; Mon, 11 Jan 2021 18:08:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390234AbhAKSId (ORCPT ); Mon, 11 Jan 2021 13:08:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390021AbhAKSIc (ORCPT ); Mon, 11 Jan 2021 13:08:32 -0500 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3705CC061794 for ; Mon, 11 Jan 2021 10:07:52 -0800 (PST) Received: by mail-pf1-x435.google.com with SMTP id m6so419860pfk.1 for ; Mon, 11 Jan 2021 10:07:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FzYi5CFHX7yAe6C21w/ewHOkjzBSVorYsZxNkxZbkLM=; b=Cf2SHU/6ht8TunF5tqJEWjahTp11UIqc4oE8ZfJA3t+1AFVBY55f7BO+Ch4Sptba3d xoS04jtiBWO6s4KeWpA4DbtGt764iAV6oOXYetqSo8Uh08vD4Vg/C01Vn+ToRq8CfjXX CYUpL3p5bg4WAQqEG3iz9nOucPiVm1/PS25QJqiKTJ/79K8pFNgH8P0dq3aG3GIoWhNe Azb++dM3F5iuTAlLeKLWLcBuitWjf2c+MKM2C5abRuhnQzWn4MP3CPoVH3hNiw3ZDdYu WBGoP6z3/ROXRWBxodFqG5otUxD2x29yT6/lgkThBW7n0j6N+FTeWj2BUUZBLSbivGEW r4mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FzYi5CFHX7yAe6C21w/ewHOkjzBSVorYsZxNkxZbkLM=; b=ZhenR6KBzGtPtJxZqfMDH5mQ+3v0VYVHWN6TuTXEyS19eZg/bzmDigoqfWer8g8mhC TyHvtYwKvdrNaXHU4y9x2kK1LIegIGtH3EczZ+/bKL5OX1j5YIo3L8sqa9SsagHjIHCZ RERCGYab0sT+zOOO/ACfVzzJ3ntNAKVDuewx/+zdXWXauJD8m6k4dCkFCF8zbeUDHMSk 2VazTBiW1pXs8qZeM+JTCsW3MdFhEUfZNM3H+gwmDyd7SZD6/QoBIj2JsmHR+Xeewxvt P488o5pdvakv7ZIE1pJrdSqf/BO+2GELiMJnj92oh2UWzXcqyBQJwQXqA9F5bK5efySH 9jPQ== X-Gm-Message-State: AOAM533ofRcg6l1VEKFmE3747V3g/q9b5lu8eQp2wCkN0IOhtTAVeo5p pyRgayL9FR/YgPCGWgNj+D9elQ== X-Google-Smtp-Source: ABdhPJy7Yt/kUlgbKAw0hyBc7JlPxMxVO5s9HLF5Xa/jBlMZ2QxouheJnaUbtcDPOqoEdNS0mqU+RQ== X-Received: by 2002:a63:5023:: with SMTP id e35mr756868pgb.56.1610388471618; Mon, 11 Jan 2021 10:07:51 -0800 (PST) Received: from google.com ([2620:15c:f:10:1ea0:b8ff:fe73:50f5]) by smtp.gmail.com with ESMTPSA id z13sm41478pjt.45.2021.01.11.10.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 10:07:50 -0800 (PST) Date: Mon, 11 Jan 2021 10:07:44 -0800 From: Sean Christopherson To: Tom Lendacky Cc: Paolo Bonzini , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov , Brijesh Singh Subject: Re: [PATCH 01/13] KVM: SVM: Free sev_asid_bitmap during init if SEV setup fails Message-ID: References: <20210109004714.1341275-1-seanjc@google.com> <20210109004714.1341275-2-seanjc@google.com> <34921a58-ce49-f0fd-e321-c5363e91f3f5@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <34921a58-ce49-f0fd-e321-c5363e91f3f5@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021, Tom Lendacky wrote: > On 1/8/21 6:47 PM, Sean Christopherson wrote: > > Free sev_asid_bitmap if the reclaim bitmap allocation fails, othwerise > > it will be leaked as sev_hardware_teardown() frees the bitmaps if and > > only if SEV is fully enabled (which obviously isn't the case if SEV > > setup fails). > > The svm_sev_enabled() function is only based on CONFIG_KVM_AMD_SEV and > max_sev_asid. So sev_hardware_teardown() should still free everything if it > was allocated since we never change max_sev_asid, no? Aha! You're correct. This is needed once svm_sev_enabled() is gone, but is not an actual bug in upstream. I created the commit before the long New Years weekend, but stupidly didn't write a changelog. I then forgot that my series effectively introduce the bug and incorrectly moved this patch to the front and treated it as an upstream bug fix when retroactively writing the changelog. Thanks!