All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition
@ 2020-12-18 19:50 ` Paul Kocialkowski
  0 siblings, 0 replies; 10+ messages in thread
From: Paul Kocialkowski @ 2020-12-18 19:50 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-kernel
  Cc: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, Paul Kocialkowski

This adds a device-tree definition for the CSI0 MCLK pin,
which can be used for feeding MIPI CSI-2 sensors.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 arch/arm/boot/dts/sun8i-v3s.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
index a9f5795d4e57..bff822b9fa01 100644
--- a/arch/arm/boot/dts/sun8i-v3s.dtsi
+++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
@@ -337,6 +337,12 @@ pio: pinctrl@1c20800 {
 			interrupt-controller;
 			#interrupt-cells = <3>;
 
+			/omit-if-no-ref/
+			csi0_mclk_pin: csi0-mclk-pin {
+				pins = "PE20";
+				function = "csi_mipi";
+			};
+
 			/omit-if-no-ref/
 			csi1_8bit_pins: csi1-8bit-pins {
 				pins = "PE0", "PE2", "PE3", "PE8", "PE9",
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition
@ 2020-12-18 19:50 ` Paul Kocialkowski
  0 siblings, 0 replies; 10+ messages in thread
From: Paul Kocialkowski @ 2020-12-18 19:50 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-kernel
  Cc: Chen-Yu Tsai, Jernej Skrabec, Maxime Ripard, Paul Kocialkowski

This adds a device-tree definition for the CSI0 MCLK pin,
which can be used for feeding MIPI CSI-2 sensors.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 arch/arm/boot/dts/sun8i-v3s.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi
index a9f5795d4e57..bff822b9fa01 100644
--- a/arch/arm/boot/dts/sun8i-v3s.dtsi
+++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
@@ -337,6 +337,12 @@ pio: pinctrl@1c20800 {
 			interrupt-controller;
 			#interrupt-cells = <3>;
 
+			/omit-if-no-ref/
+			csi0_mclk_pin: csi0-mclk-pin {
+				pins = "PE20";
+				function = "csi_mipi";
+			};
+
 			/omit-if-no-ref/
 			csi1_8bit_pins: csi1-8bit-pins {
 				pins = "PE0", "PE2", "PE3", "PE8", "PE9",
-- 
2.29.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition
  2020-12-18 19:50 ` Paul Kocialkowski
@ 2020-12-22  8:17   ` Jernej Škrabec
  -1 siblings, 0 replies; 10+ messages in thread
From: Jernej Škrabec @ 2020-12-22  8:17 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-kernel, Paul Kocialkowski
  Cc: Maxime Ripard, Chen-Yu Tsai, Paul Kocialkowski

Hi!

Dne petek, 18. december 2020 ob 20:50:33 CET je Paul Kocialkowski napisal(a):
> This adds a device-tree definition for the CSI0 MCLK pin,
> which can be used for feeding MIPI CSI-2 sensors.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>

Is this used anywhere? Current policy is to add pin definitions only if any 
user exists.

Best regards,
Jernej

> ---
>  arch/arm/boot/dts/sun8i-v3s.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi
> b/arch/arm/boot/dts/sun8i-v3s.dtsi index a9f5795d4e57..bff822b9fa01 100644
> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> @@ -337,6 +337,12 @@ pio: pinctrl@1c20800 {
>  			interrupt-controller;
>  			#interrupt-cells = <3>;
> 
> +			/omit-if-no-ref/
> +			csi0_mclk_pin: csi0-mclk-pin {
> +				pins = "PE20";
> +				function = "csi_mipi";
> +			};
> +
>  			/omit-if-no-ref/
>  			csi1_8bit_pins: csi1-8bit-pins {
>  				pins = "PE0", "PE2", "PE3", 
"PE8", "PE9",





^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition
@ 2020-12-22  8:17   ` Jernej Škrabec
  0 siblings, 0 replies; 10+ messages in thread
From: Jernej Škrabec @ 2020-12-22  8:17 UTC (permalink / raw)
  To: devicetree, linux-arm-kernel, linux-kernel, Paul Kocialkowski
  Cc: Chen-Yu Tsai, Paul Kocialkowski, Maxime Ripard

Hi!

Dne petek, 18. december 2020 ob 20:50:33 CET je Paul Kocialkowski napisal(a):
> This adds a device-tree definition for the CSI0 MCLK pin,
> which can be used for feeding MIPI CSI-2 sensors.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>

Is this used anywhere? Current policy is to add pin definitions only if any 
user exists.

Best regards,
Jernej

> ---
>  arch/arm/boot/dts/sun8i-v3s.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi
> b/arch/arm/boot/dts/sun8i-v3s.dtsi index a9f5795d4e57..bff822b9fa01 100644
> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> @@ -337,6 +337,12 @@ pio: pinctrl@1c20800 {
>  			interrupt-controller;
>  			#interrupt-cells = <3>;
> 
> +			/omit-if-no-ref/
> +			csi0_mclk_pin: csi0-mclk-pin {
> +				pins = "PE20";
> +				function = "csi_mipi";
> +			};
> +
>  			/omit-if-no-ref/
>  			csi1_8bit_pins: csi1-8bit-pins {
>  				pins = "PE0", "PE2", "PE3", 
"PE8", "PE9",





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition
  2020-12-22  8:17   ` Jernej Škrabec
@ 2020-12-24  9:21     ` Paul Kocialkowski
  -1 siblings, 0 replies; 10+ messages in thread
From: Paul Kocialkowski @ 2020-12-24  9:21 UTC (permalink / raw)
  To: Jernej Škrabec
  Cc: devicetree, linux-arm-kernel, linux-kernel, Maxime Ripard, Chen-Yu Tsai

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]

Hi,

Le Tue 22 Dec 20, 09:17, Jernej Škrabec a écrit :
> Dne petek, 18. december 2020 ob 20:50:33 CET je Paul Kocialkowski napisal(a):
> > This adds a device-tree definition for the CSI0 MCLK pin,
> > which can be used for feeding MIPI CSI-2 sensors.
> > 
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> 
> Is this used anywhere? Current policy is to add pin definitions only if any 
> user exists.

Ah right, sorry. I'll resend this when adding a board that uses it!

Cheers,

Paul

> Best regards,
> Jernej
> 
> > ---
> >  arch/arm/boot/dts/sun8i-v3s.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi
> > b/arch/arm/boot/dts/sun8i-v3s.dtsi index a9f5795d4e57..bff822b9fa01 100644
> > --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> > @@ -337,6 +337,12 @@ pio: pinctrl@1c20800 {
> >  			interrupt-controller;
> >  			#interrupt-cells = <3>;
> > 
> > +			/omit-if-no-ref/
> > +			csi0_mclk_pin: csi0-mclk-pin {
> > +				pins = "PE20";
> > +				function = "csi_mipi";
> > +			};
> > +
> >  			/omit-if-no-ref/
> >  			csi1_8bit_pins: csi1-8bit-pins {
> >  				pins = "PE0", "PE2", "PE3", 
> "PE8", "PE9",
> 
> 
> 
> 

-- 
Developer of free digital technology and hardware support.

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition
@ 2020-12-24  9:21     ` Paul Kocialkowski
  0 siblings, 0 replies; 10+ messages in thread
From: Paul Kocialkowski @ 2020-12-24  9:21 UTC (permalink / raw)
  To: Jernej Škrabec
  Cc: Maxime Ripard, devicetree, Chen-Yu Tsai, linux-kernel, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 1475 bytes --]

Hi,

Le Tue 22 Dec 20, 09:17, Jernej Škrabec a écrit :
> Dne petek, 18. december 2020 ob 20:50:33 CET je Paul Kocialkowski napisal(a):
> > This adds a device-tree definition for the CSI0 MCLK pin,
> > which can be used for feeding MIPI CSI-2 sensors.
> > 
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> 
> Is this used anywhere? Current policy is to add pin definitions only if any 
> user exists.

Ah right, sorry. I'll resend this when adding a board that uses it!

Cheers,

Paul

> Best regards,
> Jernej
> 
> > ---
> >  arch/arm/boot/dts/sun8i-v3s.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi
> > b/arch/arm/boot/dts/sun8i-v3s.dtsi index a9f5795d4e57..bff822b9fa01 100644
> > --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> > @@ -337,6 +337,12 @@ pio: pinctrl@1c20800 {
> >  			interrupt-controller;
> >  			#interrupt-cells = <3>;
> > 
> > +			/omit-if-no-ref/
> > +			csi0_mclk_pin: csi0-mclk-pin {
> > +				pins = "PE20";
> > +				function = "csi_mipi";
> > +			};
> > +
> >  			/omit-if-no-ref/
> >  			csi1_8bit_pins: csi1-8bit-pins {
> >  				pins = "PE0", "PE2", "PE3", 
> "PE8", "PE9",
> 
> 
> 
> 

-- 
Developer of free digital technology and hardware support.

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition
  2020-12-22  8:17   ` Jernej Škrabec
@ 2020-12-30  3:29     ` Chen-Yu Tsai
  -1 siblings, 0 replies; 10+ messages in thread
From: Chen-Yu Tsai @ 2020-12-30  3:29 UTC (permalink / raw)
  To: Jernej Skrabec
  Cc: devicetree, linux-arm-kernel, linux-kernel, Paul Kocialkowski,
	Maxime Ripard

On Tue, Dec 22, 2020 at 4:17 PM Jernej Škrabec <jernej.skrabec@siol.net> wrote:
>
> Hi!
>
> Dne petek, 18. december 2020 ob 20:50:33 CET je Paul Kocialkowski napisal(a):
> > This adds a device-tree definition for the CSI0 MCLK pin,
> > which can be used for feeding MIPI CSI-2 sensors.
> >
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>
> Is this used anywhere? Current policy is to add pin definitions only if any
> user exists.

IIRC we sort of loosened that requirement with the use of /omit-if-no-ref/.
The A20 dtsi file has a whole bunch of pins defined that are not directly
used but are available for users to reference, especially in overlays.
The "-@" parameter for the device tree compiler, used to build overlay
compatible DTBs, makes the compiler ignore /omit-if-no-ref/ and include
all the nodes.

ChenYu

> Best regards,
> Jernej
>
> > ---
> >  arch/arm/boot/dts/sun8i-v3s.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi
> > b/arch/arm/boot/dts/sun8i-v3s.dtsi index a9f5795d4e57..bff822b9fa01 100644
> > --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> > @@ -337,6 +337,12 @@ pio: pinctrl@1c20800 {
> >                       interrupt-controller;
> >                       #interrupt-cells = <3>;
> >
> > +                     /omit-if-no-ref/
> > +                     csi0_mclk_pin: csi0-mclk-pin {
> > +                             pins = "PE20";
> > +                             function = "csi_mipi";
> > +                     };
> > +
> >                       /omit-if-no-ref/
> >                       csi1_8bit_pins: csi1-8bit-pins {
> >                               pins = "PE0", "PE2", "PE3",
> "PE8", "PE9",
>
>
>
>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition
@ 2020-12-30  3:29     ` Chen-Yu Tsai
  0 siblings, 0 replies; 10+ messages in thread
From: Chen-Yu Tsai @ 2020-12-30  3:29 UTC (permalink / raw)
  To: Jernej Skrabec
  Cc: Maxime Ripard, devicetree, linux-kernel, linux-arm-kernel,
	Paul Kocialkowski

On Tue, Dec 22, 2020 at 4:17 PM Jernej Škrabec <jernej.skrabec@siol.net> wrote:
>
> Hi!
>
> Dne petek, 18. december 2020 ob 20:50:33 CET je Paul Kocialkowski napisal(a):
> > This adds a device-tree definition for the CSI0 MCLK pin,
> > which can be used for feeding MIPI CSI-2 sensors.
> >
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>
> Is this used anywhere? Current policy is to add pin definitions only if any
> user exists.

IIRC we sort of loosened that requirement with the use of /omit-if-no-ref/.
The A20 dtsi file has a whole bunch of pins defined that are not directly
used but are available for users to reference, especially in overlays.
The "-@" parameter for the device tree compiler, used to build overlay
compatible DTBs, makes the compiler ignore /omit-if-no-ref/ and include
all the nodes.

ChenYu

> Best regards,
> Jernej
>
> > ---
> >  arch/arm/boot/dts/sun8i-v3s.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi
> > b/arch/arm/boot/dts/sun8i-v3s.dtsi index a9f5795d4e57..bff822b9fa01 100644
> > --- a/arch/arm/boot/dts/sun8i-v3s.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi
> > @@ -337,6 +337,12 @@ pio: pinctrl@1c20800 {
> >                       interrupt-controller;
> >                       #interrupt-cells = <3>;
> >
> > +                     /omit-if-no-ref/
> > +                     csi0_mclk_pin: csi0-mclk-pin {
> > +                             pins = "PE20";
> > +                             function = "csi_mipi";
> > +                     };
> > +
> >                       /omit-if-no-ref/
> >                       csi1_8bit_pins: csi1-8bit-pins {
> >                               pins = "PE0", "PE2", "PE3",
> "PE8", "PE9",
>
>
>
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition
  2020-12-30  3:29     ` Chen-Yu Tsai
@ 2021-01-18  6:25       ` Chen-Yu Tsai
  -1 siblings, 0 replies; 10+ messages in thread
From: Chen-Yu Tsai @ 2021-01-18  6:25 UTC (permalink / raw)
  To: Paul Kocialkowski
  Cc: devicetree, linux-arm-kernel, linux-kernel, Maxime Ripard,
	Jernej Skrabec

On Wed, Dec 30, 2020 at 11:29 AM Chen-Yu Tsai <wens@csie.org> wrote:
>
> On Tue, Dec 22, 2020 at 4:17 PM Jernej Škrabec <jernej.skrabec@siol.net> wrote:
> >
> > Hi!
> >
> > Dne petek, 18. december 2020 ob 20:50:33 CET je Paul Kocialkowski napisal(a):
> > > This adds a device-tree definition for the CSI0 MCLK pin,
> > > which can be used for feeding MIPI CSI-2 sensors.
> > >
> > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> >
> > Is this used anywhere? Current policy is to add pin definitions only if any
> > user exists.
>
> IIRC we sort of loosened that requirement with the use of /omit-if-no-ref/.
> The A20 dtsi file has a whole bunch of pins defined that are not directly
> used but are available for users to reference, especially in overlays.
> The "-@" parameter for the device tree compiler, used to build overlay
> compatible DTBs, makes the compiler ignore /omit-if-no-ref/ and include
> all the nodes.

I've queued up this patch for 5.12.

ChenYu

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition
@ 2021-01-18  6:25       ` Chen-Yu Tsai
  0 siblings, 0 replies; 10+ messages in thread
From: Chen-Yu Tsai @ 2021-01-18  6:25 UTC (permalink / raw)
  To: Paul Kocialkowski
  Cc: Maxime Ripard, devicetree, Jernej Skrabec, linux-kernel,
	linux-arm-kernel

On Wed, Dec 30, 2020 at 11:29 AM Chen-Yu Tsai <wens@csie.org> wrote:
>
> On Tue, Dec 22, 2020 at 4:17 PM Jernej Škrabec <jernej.skrabec@siol.net> wrote:
> >
> > Hi!
> >
> > Dne petek, 18. december 2020 ob 20:50:33 CET je Paul Kocialkowski napisal(a):
> > > This adds a device-tree definition for the CSI0 MCLK pin,
> > > which can be used for feeding MIPI CSI-2 sensors.
> > >
> > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> >
> > Is this used anywhere? Current policy is to add pin definitions only if any
> > user exists.
>
> IIRC we sort of loosened that requirement with the use of /omit-if-no-ref/.
> The A20 dtsi file has a whole bunch of pins defined that are not directly
> used but are available for users to reference, especially in overlays.
> The "-@" parameter for the device tree compiler, used to build overlay
> compatible DTBs, makes the compiler ignore /omit-if-no-ref/ and include
> all the nodes.

I've queued up this patch for 5.12.

ChenYu

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-01-18  6:27 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-18 19:50 [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition Paul Kocialkowski
2020-12-18 19:50 ` Paul Kocialkowski
2020-12-22  8:17 ` Jernej Škrabec
2020-12-22  8:17   ` Jernej Škrabec
2020-12-24  9:21   ` Paul Kocialkowski
2020-12-24  9:21     ` Paul Kocialkowski
2020-12-30  3:29   ` Chen-Yu Tsai
2020-12-30  3:29     ` Chen-Yu Tsai
2021-01-18  6:25     ` Chen-Yu Tsai
2021-01-18  6:25       ` Chen-Yu Tsai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.