From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1620AC433E0 for ; Sun, 27 Dec 2020 11:40:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA738217A0 for ; Sun, 27 Dec 2020 11:40:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726172AbgL0LkI (ORCPT ); Sun, 27 Dec 2020 06:40:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:43068 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbgL0LkH (ORCPT ); Sun, 27 Dec 2020 06:40:07 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B4618217A0; Sun, 27 Dec 2020 11:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609069167; bh=Qj9NQfjZ7w7YKnQLJ5QEgDh45V/wmnPlZYN1lqvpVYI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CJVOLAqhLrp/Rlx3iWCsxxyNTwcb7I0Kms0gwFdnTlNvBqFf3SW0UdO096r1JCMmh 7iUae2evmxtrHGm43fSaB9y68OOOnVvGBsrWXwNs3+53/VgGxCTMLof/h7Fe7T1s8k lBM9941zlVxcbyyYPLVpCbWeCqOhKhfLOzMoFN+8= Date: Sun, 27 Dec 2020 12:40:51 +0100 From: Greg Kroah-Hartman To: Angshuman Sengupta Cc: devel@driverdev.osuosl.org, Todd Kjos , linux-kernel@vger.kernel.org, Suren Baghdasaryan , Hridya Valsaraju , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Joel Fernandes , Martijn Coenen , Christian Brauner Subject: Re: [PATCH] staging: android: ashmem: Fixed warning for structure declaration Message-ID: References: <20201227112645.256943-1-senguptaangshuman17@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201227112645.256943-1-senguptaangshuman17@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 27, 2020 at 04:56:45PM +0530, Angshuman Sengupta wrote: > Warning found by checkpatch.pl script. > > Signed-off-by: Angshuman Sengupta > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > index 4789d36ddfd3..2cb665e0228c 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; > struct ashmem_area *asma = file->private_data; > int ret = 0; > Did you test build this change? Why not? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91923C433E0 for ; Sun, 27 Dec 2020 11:39:33 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DA2B224DE for ; Sun, 27 Dec 2020 11:39:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DA2B224DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id CE36185624; Sun, 27 Dec 2020 11:39:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PInwUIx4HN2E; Sun, 27 Dec 2020 11:39:30 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1236B844BD; Sun, 27 Dec 2020 11:39:30 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 2B7051BF57F for ; Sun, 27 Dec 2020 11:39:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 27AB7844BD for ; Sun, 27 Dec 2020 11:39:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EkykMLgipXQ2 for ; Sun, 27 Dec 2020 11:39:27 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 90041844B4 for ; Sun, 27 Dec 2020 11:39:27 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id B4618217A0; Sun, 27 Dec 2020 11:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609069167; bh=Qj9NQfjZ7w7YKnQLJ5QEgDh45V/wmnPlZYN1lqvpVYI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CJVOLAqhLrp/Rlx3iWCsxxyNTwcb7I0Kms0gwFdnTlNvBqFf3SW0UdO096r1JCMmh 7iUae2evmxtrHGm43fSaB9y68OOOnVvGBsrWXwNs3+53/VgGxCTMLof/h7Fe7T1s8k lBM9941zlVxcbyyYPLVpCbWeCqOhKhfLOzMoFN+8= Date: Sun, 27 Dec 2020 12:40:51 +0100 From: Greg Kroah-Hartman To: Angshuman Sengupta Subject: Re: [PATCH] staging: android: ashmem: Fixed warning for structure declaration Message-ID: References: <20201227112645.256943-1-senguptaangshuman17@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201227112645.256943-1-senguptaangshuman17@gmail.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Todd Kjos , Martijn Coenen , linux-kernel@vger.kernel.org, Joel Fernandes , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Hridya Valsaraju , Suren Baghdasaryan , Christian Brauner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sun, Dec 27, 2020 at 04:56:45PM +0530, Angshuman Sengupta wrote: > Warning found by checkpatch.pl script. > > Signed-off-by: Angshuman Sengupta > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c > index 4789d36ddfd3..2cb665e0228c 100644 > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; > struct ashmem_area *asma = file->private_data; > int ret = 0; > Did you test build this change? Why not? thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel