From: Sean Christopherson <seanjc@google.com>
To: Zhimin Feng <fengzhimin@bytedance.com>
Cc: zhouyibo@bytedance.com, zhanghaozhong@bytedance.com,
Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC: timer passthrough 0/9] Support timer passthrough for VM
Date: Mon, 28 Dec 2020 15:28:31 -0800 [thread overview]
Message-ID: <X+pqH77bs9nyhK8w@google.com> (raw)
In-Reply-To: <20201228091559.25745-1-fengzhimin@bytedance.com>
On Mon, Dec 28, 2020, Zhimin Feng wrote:
> The main motivation for this patch is to improve the performance of VM.
Do you have numbers that show when this improves performance, and by how much?
This adds hundreds of cycles of overhead (VMWRITEs, WRMSRs, RDMSRs, etc...) to
_every_ VM-Exit roundtrip, and the timer IRQ still incurs a VM-Exit. It's not
obvious that this is a net win, and it adds a fair amount of complexity and
subtlety, e.g. there are multiple corner cases this gets wrong. I suspect
you'll have a tough time getting this reviewed, let alone merged, without hard
numbers to justify the complexity and review effort.
parent reply other threads:[~2020-12-28 23:29 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201228091559.25745-1-fengzhimin@bytedance.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+pqH77bs9nyhK8w@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=fengzhimin@bytedance.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
--cc=zhanghaozhong@bytedance.com \
--cc=zhouyibo@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.