From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA15BC56202 for ; Thu, 12 Nov 2020 16:45:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5678521D91 for ; Thu, 12 Nov 2020 16:45:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="s0F50Ebh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729201AbgKLQo6 (ORCPT ); Thu, 12 Nov 2020 11:44:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:40292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728643AbgKLQo4 (ORCPT ); Thu, 12 Nov 2020 11:44:56 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5630B22201; Thu, 12 Nov 2020 16:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605199495; bh=0nhD/WqlMJ8Pv79MqKKt0vSqZj2iK1s1b6fB6XQ3BnU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s0F50Ebh+SmJAcWpfQa+qpb6NcgwA9M3g77Rz2Nm6oz7QTTTjD5JSVHulMK3XvMPd OIMyVtHhXHGzEU+8p4rAHhw50hUyamI+5AxqT00BQR4KGH/v7+/txgZHKivBPYlZLy 6naphLWfosq50gxir6dhjT2SdypuJneaWEvoN32g= Date: Thu, 12 Nov 2020 17:45:53 +0100 From: Greg KH To: Shuah Khan Cc: Matthew Wilcox , Kees Cook , corbet@lwn.net, peterz@infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/13] seqnum_ops: Introduce Sequence Number Ops Message-ID: References: <202011101614.E7D880689@keescook> <3075a4fd-8615-1459-2b20-b7d9d2be34ff@linuxfoundation.org> <20201112123621.GY17076@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 09:17:27AM -0700, Shuah Khan wrote: > On 11/12/20 5:36 AM, Matthew Wilcox wrote: > > On Wed, Nov 11, 2020 at 12:23:03PM -0700, Shuah Khan wrote: > > > > Agreed: this is a clear wrapping sequence counter. It's only abuse would > > > > be using it in a place where wrapping actually is _not_ safe. (bikeshed: > > > > can we call it wrap_u32 and wrap_u64?) > > > > > > Still like seqnum_ops. > > > > > > There is seqcount_t in seqlock.h which is a totally different feature. > > > > Yes, and that's why this new thing, whatever it is called should not > > have the word "sequence" in it. People will get it confused. > > Any suggestions for name. I am bad with coming up with names. How does > Statcnt API and struct statcnt along the lines of your name suggestions > in your previous email? What does "stat" mean here? And I don't understand the hesitation about "sequence" in a name, as that's exactly what this is. seqlock is different, yes. How about "seqnum_t"? That's what we call the sequence number that we export to uevents, a "SEQNUM". thanks, greg k-h