From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E2C1C56202 for ; Thu, 26 Nov 2020 17:49:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12007207BC for ; Thu, 26 Nov 2020 17:49:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oGrVxfJ+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391701AbgKZRtk (ORCPT ); Thu, 26 Nov 2020 12:49:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:43428 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391626AbgKZRtj (ORCPT ); Thu, 26 Nov 2020 12:49:39 -0500 Received: from sol.localdomain (172-10-235-113.lightspeed.sntcca.sbcglobal.net [172.10.235.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 257F52053B; Thu, 26 Nov 2020 17:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606412979; bh=BD8kUdWFybD9t7G40pqo6k9zDUDc9M1OCvnslZNmT4A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oGrVxfJ+LzZIs8hVexHcq3DO90RyIP3/zN4o9egA8ewsVmKocSWibGMAQiPB+c2YU b2vUm3XfWmGHmev1MKAGbIgC2MSHDF8wYlLR1ubi9qyg8NAGPGCc9LN8hnKlqMfRc2 wYQOmT95L0gjoRPFXx5d5z8hm5xFieSByrUFFKm4= Date: Thu, 26 Nov 2020 09:49:35 -0800 From: Eric Biggers To: Daeho Jeong Cc: Chao Yu , Daeho Jeong , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS_FILE Message-ID: References: <20201123031751.36811-1-daeho43@gmail.com> <20201123031751.36811-2-daeho43@gmail.com> <5b3cb83d-5d0f-c1ca-2cff-f28372dec48e@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2020 at 02:04:41PM +0900, Daeho Jeong wrote: > Eric, > > do_page_cache_ra() is defined in mm/internal.h for internal use > between in mm, so we cannot use this one right now. > So, I think we could use page_cache_ra_unbounded(), because we already > check i_size boundary on our own. > What do you think? What about page_cache_async_readahead() or page_cache_sync_readahead()? - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85460C56202 for ; Thu, 26 Nov 2020 18:00:38 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BE17207BC; Thu, 26 Nov 2020 18:00:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="TFddBSTZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="gzEQSi59"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oGrVxfJ+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BE17207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kiLZN-0002a7-Fu; Thu, 26 Nov 2020 18:00:37 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiLPI-0002CC-Du for linux-f2fs-devel@lists.sourceforge.net; Thu, 26 Nov 2020 17:50:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hMl+FHjlivENcMZp9kN382Qfgc3teG6dw7HLRlVn2iA=; b=TFddBSTZis19RetZcQjXcnVGwW cWcE17/vle4aPZvBcUFy7/RRaTvwOVQd5z+BEntQquKz2/vySL9HBDjOtaCCmHL/qVAcE0dAfjOZK 2oMFmm4lwPl7ys97Qx3rtYOtB6u7Xyh4yIPE8LYpCysve/8k/k1IpbMclFDY/X11vML0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hMl+FHjlivENcMZp9kN382Qfgc3teG6dw7HLRlVn2iA=; b=gzEQSi59H3DJIiButr/Q00aiFV RhdXLxQcAhQwEQXV6kJPOK71FABylaNLog7ZujUK2HYVKVNmbvsH+SvbmDoHF0y5dzJ1geMA8rg+5 eOwSFe59Eud13pTjQTLBhaSXB9yIXyeulhLqKlNkU2dxfWf4FglQ+PiGuuETG1U7O9zI=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kiLP3-005pxR-Vv for linux-f2fs-devel@lists.sourceforge.net; Thu, 26 Nov 2020 17:50:12 +0000 Received: from sol.localdomain (172-10-235-113.lightspeed.sntcca.sbcglobal.net [172.10.235.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 257F52053B; Thu, 26 Nov 2020 17:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606412979; bh=BD8kUdWFybD9t7G40pqo6k9zDUDc9M1OCvnslZNmT4A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oGrVxfJ+LzZIs8hVexHcq3DO90RyIP3/zN4o9egA8ewsVmKocSWibGMAQiPB+c2YU b2vUm3XfWmGHmev1MKAGbIgC2MSHDF8wYlLR1ubi9qyg8NAGPGCc9LN8hnKlqMfRc2 wYQOmT95L0gjoRPFXx5d5z8hm5xFieSByrUFFKm4= Date: Thu, 26 Nov 2020 09:49:35 -0800 From: Eric Biggers To: Daeho Jeong Message-ID: References: <20201123031751.36811-1-daeho43@gmail.com> <20201123031751.36811-2-daeho43@gmail.com> <5b3cb83d-5d0f-c1ca-2cff-f28372dec48e@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1kiLP3-005pxR-Vv Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS_FILE X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, Daeho Jeong , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Nov 26, 2020 at 02:04:41PM +0900, Daeho Jeong wrote: > Eric, > > do_page_cache_ra() is defined in mm/internal.h for internal use > between in mm, so we cannot use this one right now. > So, I think we could use page_cache_ra_unbounded(), because we already > check i_size boundary on our own. > What do you think? What about page_cache_async_readahead() or page_cache_sync_readahead()? - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel