All of
 help / color / mirror / Atom feed
From: Greg KH <>
To: Minchan Kim <>
Cc: Steven Rostedt <>,
	LKML <>,, Namhyung Kim <>
Subject: Re: [PATCH] tracing: Fix align of static buffer
Date: Thu, 26 Nov 2020 06:52:07 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Nov 25, 2020 at 02:56:54PM -0800, Minchan Kim wrote:
> With 5.9 kernel on ARM64, I found ftrace_dump output was broken but
> it had no problem with normal output "cat /sys/kernel/debug/tracing/trace".
> With investigation, it seems coping the data into temporal buffer seems to
> break the align binary printf expects if the static buffer is not aligned
> with 4-byte. IIUC, get_arg in bstr_printf expects that args has already
> right align to be decoded and seq_buf_bprintf says ``the arguments are saved
> in a 32bit word array that is defined by the format string constraints``.
> So if we don't keep the align under copy to temporal buffer, the output
> will be broken by shifting some bytes.
> This patch fixes it.

Does this resolve the issue reported at:


greg k-h

  reply	other threads:[~2020-11-26  5:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 22:56 Minchan Kim
2020-11-26  5:52 ` Greg KH [this message]
2020-11-26  9:31   ` Namhyung Kim
     [not found] ` <>
2020-11-26 13:04   ` Youngmin Nam
2020-11-26 18:05     ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] tracing: Fix align of static buffer' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.