From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26B3BC63697 for ; Sat, 14 Nov 2020 22:59:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAF5E24073 for ; Sat, 14 Nov 2020 22:59:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NpPw9VlT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726334AbgKNW7L (ORCPT ); Sat, 14 Nov 2020 17:59:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbgKNW7L (ORCPT ); Sat, 14 Nov 2020 17:59:11 -0500 Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9BB3C0613D1; Sat, 14 Nov 2020 14:59:10 -0800 (PST) Received: by mail-qt1-x844.google.com with SMTP id b16so9839144qtb.6; Sat, 14 Nov 2020 14:59:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZJV4itcrkzo0iqqlIyzwiAWmUlMWobk9rPKCYueitq4=; b=NpPw9VlTVt8vCy/GNWXCZV8JbNSV7GH4dGw1Mm1f5Up+kz+oWR564W88dXxqZFN86j GhAJ81Gw7xptZSGp0I9Dy2zqK+iEMFT6VRqYuzBcp4ky+kP6xhXLZRpWM4BzdoDnjBG2 zZ2qta7/baXDQCIbO711u4YQNlM3846FkmJNGcyx6meo8pOGUEQF/mHGQ2N/UBAZz8js FVgb965DXSPc15a/9kYMqBv+czkmfO6KTLmW0ejqcndIMrOPleq9AOyYsc/HWXyhybq8 AnhMxFbeTpnwLYZyvV6oln+zpBTwslGAWMOZsn4SP4FtMZPtWlRbgke0I/uDN9nGvJVa KThQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZJV4itcrkzo0iqqlIyzwiAWmUlMWobk9rPKCYueitq4=; b=mPLCcqwF7Ftqla/+fZKuTvS5N60C4CZs+deUPEBkN2Ofm9LK5hbB94WhESjzTwKpef bl14a6ufbHUbvzV2sLiJ8GpnJ6nvrUH+Y5coq01cKdMDTog/+dntqZi0+hMM1vJgdDAj NO0IH1DeAn9WOJHthzLdiZyhythGXb7H2Q6TD2Q96Fi8UpEHSa20F0PcUFtcNDig0A65 XY/BeAP1c/R1DEd1X8/zFFqgTyFEZQvJyJeY5kHs+1wd4qw/ae6FzE7K39JTaCvYZ/j/ Xt/YFOBuQ5p4YYHm3WPYeNy2wAuQNYNf7TueAFFCVsG0IU2Jn01ocigxDZyim+FP8Zg8 jRng== X-Gm-Message-State: AOAM5327rUimNArt+qgQvUU5aIWfVbwBeNaoVMUhWYud1IjHPqLNMrQK Vq1os56lXq3SxoOf2r9FB8A= X-Google-Smtp-Source: ABdhPJyFwsjl87sgx0iBIp7qQbUS+rVsGz/N1pgHSjdcO5CPXSFU8viOv3ofHohCg5ggBMTmuJ63bw== X-Received: by 2002:ac8:6c6:: with SMTP id j6mr8304427qth.123.1605394749978; Sat, 14 Nov 2020 14:59:09 -0800 (PST) Received: from shinobu (072-189-064-225.res.spectrum.com. [72.189.64.225]) by smtp.gmail.com with ESMTPSA id 9sm9995356qkm.81.2020.11.14.14.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2020 14:59:09 -0800 (PST) Date: Sat, 14 Nov 2020 17:58:28 -0500 From: William Breathitt Gray To: Alexandre Belloni , Kamel Bouhara Cc: jic23@kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check Message-ID: References: <20201111163807.10201-1-vilhelm.gray@gmail.com> <20201114224827.GQ4556@piout.net> <20201114225113.GR4556@piout.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LF/5iLACl9VFrJcf" Content-Disposition: inline In-Reply-To: <20201114225113.GR4556@piout.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LF/5iLACl9VFrJcf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 14, 2020 at 11:51:13PM +0100, Alexandre Belloni wrote: > On 14/11/2020 23:48:28+0100, Alexandre Belloni wrote: > > On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote: > > > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible valu= es > > > for CMR. This patch fixes the action_get() callback to properly check > > > for these values rather than mask them. > > >=20 > > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > > > Cc: Kamel Bouhara > > > Signed-off-by: William Breathitt Gray > > Acked-by: Alexandre Belloni > >=20 > > > --- > > > drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------ > > > 1 file changed, 10 insertions(+), 6 deletions(-) > > >=20 > > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counte= r/microchip-tcb-capture.c > > > index 039c54a78aa5..142b389fc9db 100644 > > > --- a/drivers/counter/microchip-tcb-capture.c > > > +++ b/drivers/counter/microchip-tcb-capture.c > > > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct coun= ter_device *counter, > > > =20 > > > regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr= ); > > > =20 > > > - *action =3D MCHP_TC_SYNAPSE_ACTION_NONE; > > > - > > > - if (cmr & ATMEL_TC_ETRGEDG_NONE) > > > + switch (cmr & ATMEL_TC_ETRGEDG_BOTH) { >=20 > BTW, this could be simply ATMEL_TC_ETRGEDG which is the mask. You're right, let me resubmit this patch with that change since it'll be much clearer. By the way, microchip-tcb-capture.c is missing a MAINTAINERS entry. Is Kamel the maintainer of this driver? I'd like to get a proper entry added so we have a point of contact in case of future bugs and changes. Thanks, William Breathitt Gray --LF/5iLACl9VFrJcf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAl+wYPUACgkQhvpINdm7 VJJI+hAA6HMTVn7T0kWkHIRa+CGFPliJYVMVECIiMeMVFSzfB8b//RWxSoYUY8Cr Oj1fCgZT/pddPB9kcvLkycgFrUJN1dO3MHvYtChn67moUIK2WdIRYXVKUNlpyOy0 cIzSznULfJYcqHYVROIaIjgBpLtQiBhsG857kqSxCni4UOWMjWHPnNU+XXPAy79U ORp0XAgViBrGpT1cD9z3mXO9TdIP49fm2An2rORC5Eu8UPMk+cpBKekhk+VwURUj H2T3Q61EwxH2iicDHip7rRzSlKQEDvXghIWYCzlLhJ99V+sOBaZD7qbO+FflOjJp T9z0+q3tuXhSrwQ6mWvISLVOddf2q2HcgnW2W45TUO4jyxlVXwIKWpwTsF+PKjBF tMYlrojud53CGe+jqA83baBEUw1k81Fioo5Tr7jjaIu3jRBN/clzIx4ontwU7rY8 et4OidOH/10ozD9ABffQOoOTDz/2jD6Ub+iQGNnCAVcOZJD8l29LjOIr1AldmeM/ 7ssqDXHI6f8FKxZDjjfcKlhFhEGrribZZ8/r1YdpkZgQkZ+35nH4gN9W2WOGZkrP lLd0z1o1ygkkhm/uQ0FDIKes4qoGPzwCV4u4d1BqW+DOTo5JX1pFZhXivqhkbVtw ux5Y7OIEeHjXQ+9xf6IToefeJ30zrGHI4tWgrI8bhnV0nY4geUw= =1W7P -----END PGP SIGNATURE----- --LF/5iLACl9VFrJcf-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 405EEC5519F for ; Sat, 14 Nov 2020 23:00:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3A4524102 for ; Sat, 14 Nov 2020 23:00:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uwgt14aP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NpPw9VlT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3A4524102 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hrA6suM6F2Oe4g333H5RYEG945CtzrA2KOVzwXmWiSk=; b=uwgt14aPwTFkAqobXXbNr3mBu j+JoemnFF1hBsALmSX39BJ/p55Mwfwv2L+8l7GZwhjXJVod7EnwWChL7Rk6hxLOnkZgc9GbNSOvtl fYnG3Nj+5eSSpaeBugP8HOsT6r2gRy+DlTXoHy76lyLeIDXSYXH5Vt7vTSI7onoU1+S8wFXBENCeb 4eQctACyYf1b8eWzzj5DZveccaB/8MsnwyY0WZz7Fza3DabKqdygBUQF2d9hEIkaiZd2Cq1yDwlVV IaMZYTTp5OA6HVtFIiqLeGfZAG7RHGWj2IPu4/h8n+QCThlrN1Wap3Nu+SJ9C8XJ6BIWH393FewsC kmcHVIARg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ke4Vn-0007UR-TA; Sat, 14 Nov 2020 22:59:15 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ke4Vl-0007U2-DZ for linux-arm-kernel@lists.infradead.org; Sat, 14 Nov 2020 22:59:14 +0000 Received: by mail-qt1-x842.google.com with SMTP id j31so10052673qtb.8 for ; Sat, 14 Nov 2020 14:59:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZJV4itcrkzo0iqqlIyzwiAWmUlMWobk9rPKCYueitq4=; b=NpPw9VlTVt8vCy/GNWXCZV8JbNSV7GH4dGw1Mm1f5Up+kz+oWR564W88dXxqZFN86j GhAJ81Gw7xptZSGp0I9Dy2zqK+iEMFT6VRqYuzBcp4ky+kP6xhXLZRpWM4BzdoDnjBG2 zZ2qta7/baXDQCIbO711u4YQNlM3846FkmJNGcyx6meo8pOGUEQF/mHGQ2N/UBAZz8js FVgb965DXSPc15a/9kYMqBv+czkmfO6KTLmW0ejqcndIMrOPleq9AOyYsc/HWXyhybq8 AnhMxFbeTpnwLYZyvV6oln+zpBTwslGAWMOZsn4SP4FtMZPtWlRbgke0I/uDN9nGvJVa KThQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZJV4itcrkzo0iqqlIyzwiAWmUlMWobk9rPKCYueitq4=; b=HtIfsu9xO/xfgACqEyUunJxPqBaXCoPXNDLhD8+O3IW+4nhLRpCKhLzNU7UPIXGpvs PMtfqFVR2MDK6fSFkmw0/8zHUPriuDWAuuv8L0MYNTgGwW3F2G5kyeMUzUrrykncDk1+ 2H9bvSg06jUkVYLEnKoabyoWXK3aXss9Rkn72KOKdGnSQ3Iv0YMIrSKt6x3SbmyR8RLn T/wG2LqFMpAKrrXXQm9VLw5ZsDyvI+lnjueH/hJHV5XhtbZdwsiHOSckryFrDqC11RK1 R9RvPItnDzzeL1pshov3AExfRJ43FeF7kVLVoLN+GC8QK5DXxNRQJ0Jm1ierDt50luWW VDNA== X-Gm-Message-State: AOAM530PHxzROH1lQUbHKk6HTl3jvimhqEb433Blbb0lsbbg0GPNgKrE HMtzeEtvvwi6CQIApv7jFM0= X-Google-Smtp-Source: ABdhPJyFwsjl87sgx0iBIp7qQbUS+rVsGz/N1pgHSjdcO5CPXSFU8viOv3ofHohCg5ggBMTmuJ63bw== X-Received: by 2002:ac8:6c6:: with SMTP id j6mr8304427qth.123.1605394749978; Sat, 14 Nov 2020 14:59:09 -0800 (PST) Received: from shinobu (072-189-064-225.res.spectrum.com. [72.189.64.225]) by smtp.gmail.com with ESMTPSA id 9sm9995356qkm.81.2020.11.14.14.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2020 14:59:09 -0800 (PST) Date: Sat, 14 Nov 2020 17:58:28 -0500 From: William Breathitt Gray To: Alexandre Belloni , Kamel Bouhara Subject: Re: [PATCH] counter: microchip-tcb-capture: Fix CMR value check Message-ID: References: <20201111163807.10201-1-vilhelm.gray@gmail.com> <20201114224827.GQ4556@piout.net> <20201114225113.GR4556@piout.net> MIME-Version: 1.0 In-Reply-To: <20201114225113.GR4556@piout.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201114_175913_470419_0F151753 X-CRM114-Status: GOOD ( 21.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-iio@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, jic23@kernel.org, linux-kernel@vger.kernel.org Content-Type: multipart/mixed; boundary="===============0964138200367798227==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0964138200367798227== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LF/5iLACl9VFrJcf" Content-Disposition: inline --LF/5iLACl9VFrJcf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 14, 2020 at 11:51:13PM +0100, Alexandre Belloni wrote: > On 14/11/2020 23:48:28+0100, Alexandre Belloni wrote: > > On 11/11/2020 11:38:07-0500, William Breathitt Gray wrote: > > > The ATMEL_TC_ETRGEDG_* defines are not masks but rather possible valu= es > > > for CMR. This patch fixes the action_get() callback to properly check > > > for these values rather than mask them. > > >=20 > > > Fixes: 106b104137fd ("counter: Add microchip TCB capture counter") > > > Cc: Kamel Bouhara > > > Signed-off-by: William Breathitt Gray > > Acked-by: Alexandre Belloni > >=20 > > > --- > > > drivers/counter/microchip-tcb-capture.c | 16 ++++++++++------ > > > 1 file changed, 10 insertions(+), 6 deletions(-) > > >=20 > > > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counte= r/microchip-tcb-capture.c > > > index 039c54a78aa5..142b389fc9db 100644 > > > --- a/drivers/counter/microchip-tcb-capture.c > > > +++ b/drivers/counter/microchip-tcb-capture.c > > > @@ -183,16 +183,20 @@ static int mchp_tc_count_action_get(struct coun= ter_device *counter, > > > =20 > > > regmap_read(priv->regmap, ATMEL_TC_REG(priv->channel[0], CMR), &cmr= ); > > > =20 > > > - *action =3D MCHP_TC_SYNAPSE_ACTION_NONE; > > > - > > > - if (cmr & ATMEL_TC_ETRGEDG_NONE) > > > + switch (cmr & ATMEL_TC_ETRGEDG_BOTH) { >=20 > BTW, this could be simply ATMEL_TC_ETRGEDG which is the mask. You're right, let me resubmit this patch with that change since it'll be much clearer. By the way, microchip-tcb-capture.c is missing a MAINTAINERS entry. Is Kamel the maintainer of this driver? I'd like to get a proper entry added so we have a point of contact in case of future bugs and changes. Thanks, William Breathitt Gray --LF/5iLACl9VFrJcf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAl+wYPUACgkQhvpINdm7 VJJI+hAA6HMTVn7T0kWkHIRa+CGFPliJYVMVECIiMeMVFSzfB8b//RWxSoYUY8Cr Oj1fCgZT/pddPB9kcvLkycgFrUJN1dO3MHvYtChn67moUIK2WdIRYXVKUNlpyOy0 cIzSznULfJYcqHYVROIaIjgBpLtQiBhsG857kqSxCni4UOWMjWHPnNU+XXPAy79U ORp0XAgViBrGpT1cD9z3mXO9TdIP49fm2An2rORC5Eu8UPMk+cpBKekhk+VwURUj H2T3Q61EwxH2iicDHip7rRzSlKQEDvXghIWYCzlLhJ99V+sOBaZD7qbO+FflOjJp T9z0+q3tuXhSrwQ6mWvISLVOddf2q2HcgnW2W45TUO4jyxlVXwIKWpwTsF+PKjBF tMYlrojud53CGe+jqA83baBEUw1k81Fioo5Tr7jjaIu3jRBN/clzIx4ontwU7rY8 et4OidOH/10ozD9ABffQOoOTDz/2jD6Ub+iQGNnCAVcOZJD8l29LjOIr1AldmeM/ 7ssqDXHI6f8FKxZDjjfcKlhFhEGrribZZ8/r1YdpkZgQkZ+35nH4gN9W2WOGZkrP lLd0z1o1ygkkhm/uQ0FDIKes4qoGPzwCV4u4d1BqW+DOTo5JX1pFZhXivqhkbVtw ux5Y7OIEeHjXQ+9xf6IToefeJ30zrGHI4tWgrI8bhnV0nY4geUw= =1W7P -----END PGP SIGNATURE----- --LF/5iLACl9VFrJcf-- --===============0964138200367798227== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0964138200367798227==--