From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1372BC2D0E4 for ; Wed, 18 Nov 2020 02:07:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4E812463D for ; Wed, 18 Nov 2020 02:07:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mQSoM3tp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726321AbgKRCGx (ORCPT ); Tue, 17 Nov 2020 21:06:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725771AbgKRCGx (ORCPT ); Tue, 17 Nov 2020 21:06:53 -0500 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20347C061A48; Tue, 17 Nov 2020 18:06:53 -0800 (PST) Received: by mail-pj1-x1041.google.com with SMTP id h12so230207pjv.2; Tue, 17 Nov 2020 18:06:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HZKGduzqBReBfRr08X8V7IvE/bDB3pEOMc9tQAotIvE=; b=mQSoM3tpBbs+SzuUQGWHjGluu1bhAz1/FEFkGbOZbZUz11uBEsqFbvKtimMU/um87B 916uaICDWLpwmbwaL+iBpNwswSh4oxWRUDr4iSLIJGbZLWpb5aa/zm2w9mFDIsrWkT+2 na8sjo0zllRPiibdAXQ3KhdbQkQWfmGb/XK/fSWQWBZiOACmbHLP2A5KhId6nN2EcSwA jSaWSPcy6dUuuu+5L2Y9TRiuBtXTek84eWL+9TyLGc/9E3HZtjDljXX19eO2EZEYRYzO szcc6AElGtvMPd9pCw49aa4/Sb9bZkPNgqelMw0k4gtb980X4UBx32AtQoFHH8DFilsp d9vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HZKGduzqBReBfRr08X8V7IvE/bDB3pEOMc9tQAotIvE=; b=QdvY+VN7oS4jzKOAKo+2jUBmWYLfJ9pinpNw270GCHW2kXgbBYWB2VqW7I5Q04dvDn B0o7CSOJMvpKQCa9oio1T0NruQyI2kLV4/xR7AhX5xpOGEFm+bCplbIxzWCOTakD1LI+ mg228MPr6QBWXKiC5oNtE4+PtJ3bTpZPrWG3p9vN2l6Yz6X25yt4JCwUnE/taDocQ1/E +XwWLUyULrsR01HRh5/9OXMOHtOJ0fyNf6sSzSLUNOMumfbfTOdmjjPD4vscx01TfKTB R9QTAsArFJGvJVtJI7yhtakG4+E649c8dkHsoRikU/s0yJFFpmeTigWNflxa4/Q+7CJs ctnQ== X-Gm-Message-State: AOAM530kyA/2WKeg1kfb2Uw9ATf/RA389g798vnLOzOJq2S9T990M2at yGJRVx6o95EVvonuAQqoY14= X-Google-Smtp-Source: ABdhPJzsOC1ruRnZumF1K8gm+9+QrU+lBpFYmyxlNYeWCcTFjgmk3F/6fFht7pWy24OfEAuO4KUfTg== X-Received: by 2002:a17:902:b196:b029:d5:a8fd:9a1c with SMTP id s22-20020a170902b196b02900d5a8fd9a1cmr2372153plr.44.1605665212605; Tue, 17 Nov 2020 18:06:52 -0800 (PST) Received: from localhost ([2409:10:2e40:5100:6e29:95ff:fe2d:8f34]) by smtp.gmail.com with ESMTPSA id s145sm22886088pfs.187.2020.11.17.18.06.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 18:06:51 -0800 (PST) Date: Wed, 18 Nov 2020 11:06:49 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Christoph Hellwig , sergey.senozhatsky.work@gmail.com, tony@atomide.com, linux-arm-kernel@lists.infradead.org, Andrew Morton , linux-kernel@vger.kernel.org, linux-mm , "Aneesh Kumar K . V" , Harish Sriram , stable@vger.kernel.org Subject: Re: [PATCH] Revert "mm/vunmap: add cond_resched() in vunmap_pmd_range" Message-ID: References: <20201105170249.387069-1-minchan@kernel.org> <20201106175933.90e4c8851010c9ce4dd732b6@linux-foundation.org> <20201107083939.GA1633068@google.com> <20201112200101.GC123036@google.com> <20201112144919.5f6b36876f4e59ebb4a99d6d@linux-foundation.org> <20201113162529.GA2378542@google.com> <20201116175323.GB3805951@google.com> <20201117135632.GA27763@infradead.org> <20201117202916.GA3856507@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117202916.GA3856507@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (20/11/17 12:29), Minchan Kim wrote: > Yub, I remeber the discussion. > https://lore.kernel.org/linux-mm/20200416203736.GB50092@google.com/ > > I wanted to remove it but 30% gain made me think again before > deciding to drop it. > Since it continue to make problems and Linux is approaching to > deprecate the 32bit machines, I think it would be better to drop it > rather than inventing weird workaround. > > Ccing Tony since omap2plus have used it by default for just in case. > > From fc1b17a120991fd86b9e1153ab22d0b0bdadd8d0 Mon Sep 17 00:00:00 2001 > From: Minchan Kim > Date: Tue, 17 Nov 2020 11:58:51 -0800 > Subject: [PATCH] mm/zsmalloc.c: drop ZSMALLOC_PGTABLE_MAPPING > > Even though this option showed some amount improvement(e.g., 30%) > in some arm32 platforms, it has been headache to maintain since it > have abused APIs[1](e.g., unmap_kernel_range in atomic context). > > Since we are approaching to deprecate 32bit machines and already made > the config option available for only builtin build since v5.8, lastly > it has been not default option in zsmalloc, it's time to drop the > option for better maintainance. > > [1] http://lore.kernel.org/linux-mm/20201105170249.387069-1-minchan@kernel.org > > Cc: Tony Lindgren > Cc: Sergey Senozhatsky > Cc: Christoph Hellwig > Cc: > Fixes: e47110e90584 ("mm/vunmap: add cond_resched() in vunmap_pmd_range") > Signed-off-by: Minchan Kim Looks good to me. Reviewed-by: Sergey Senozhatsky -ss From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55FFAC2D0E4 for ; Wed, 18 Nov 2020 02:07:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69A3724655 for ; Wed, 18 Nov 2020 02:07:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Zqb8KbR4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mQSoM3tp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69A3724655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A17i3Ome44YaGQHL7bZnWffBWfazFQnMpqI3m7ngSK4=; b=Zqb8KbR4+E1Lc04l3t8otdAAF Ln141IoD2HwMKwPo59VoQrgUatq4+XXanHbDPDLR6BN87F9T7K+8lr7kGYrDbFMmhdvAu84waPYAF YiF5FpK1kUYERPgr7mWI+1qCoB1d5XUdi0Cq+JKgs3Ah0/xvF3P5W+6L25T3rajeguB46vGU4xnSj dGSuYsCyBnXB+xZ5MKAm/gKPBgjmNA0FxS+IonDKFKPyJm3+UmW4z8hfosJacgN9V8n1NexDGqUgX 4HacowXLszmSX3trb0JmiJ8W11LBz0jyiVoyf9QXsdOycRrRCVkqR4PF7uuHbvmdl5Wc5qaW3iBjZ /yaG7vdbw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfCsB-0003Yx-32; Wed, 18 Nov 2020 02:07:03 +0000 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfCs7-0003Xr-TJ for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2020 02:07:01 +0000 Received: by mail-pj1-x1044.google.com with SMTP id r6so232760pjd.1 for ; Tue, 17 Nov 2020 18:06:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HZKGduzqBReBfRr08X8V7IvE/bDB3pEOMc9tQAotIvE=; b=mQSoM3tpBbs+SzuUQGWHjGluu1bhAz1/FEFkGbOZbZUz11uBEsqFbvKtimMU/um87B 916uaICDWLpwmbwaL+iBpNwswSh4oxWRUDr4iSLIJGbZLWpb5aa/zm2w9mFDIsrWkT+2 na8sjo0zllRPiibdAXQ3KhdbQkQWfmGb/XK/fSWQWBZiOACmbHLP2A5KhId6nN2EcSwA jSaWSPcy6dUuuu+5L2Y9TRiuBtXTek84eWL+9TyLGc/9E3HZtjDljXX19eO2EZEYRYzO szcc6AElGtvMPd9pCw49aa4/Sb9bZkPNgqelMw0k4gtb980X4UBx32AtQoFHH8DFilsp d9vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HZKGduzqBReBfRr08X8V7IvE/bDB3pEOMc9tQAotIvE=; b=PQ2W6Z1skF5xU1LWyALjq0H7G5w8l07LYdNO784nTlzT2dPdmTE5IkMP7CqeC3Tfg4 /ryHInn2vRsUxZjJcEhshzECaQEYNL6k5E7COgKdm6EpbyjLkVyfKH3HkfgVw6/nrGwq +WCU69GKPf+T1t/t22FsvUmJeHez1OsBgB23T2zTld39iVOl0FZ5nnn4+c3RWRBmeSXB vhPNYSe6f7GGqEDveiGdyni0HwMCeE3EZUKfKFXDCMI3NdVYFpvw6xJHE/cGJUYegSIN exuYU9arWgzN6jAHfygROQi+qQGLx4ODmCOAYTw2wRBd4DwqBRerawDqWWPU9T+M39cV Wihw== X-Gm-Message-State: AOAM530HJEgjZjPqr4CY/PZIBq8CS1ZUG3FxxBc7R7zOaJe86ukZ+7If DZr8cedIqfpNQ4xd+20G2w8= X-Google-Smtp-Source: ABdhPJzsOC1ruRnZumF1K8gm+9+QrU+lBpFYmyxlNYeWCcTFjgmk3F/6fFht7pWy24OfEAuO4KUfTg== X-Received: by 2002:a17:902:b196:b029:d5:a8fd:9a1c with SMTP id s22-20020a170902b196b02900d5a8fd9a1cmr2372153plr.44.1605665212605; Tue, 17 Nov 2020 18:06:52 -0800 (PST) Received: from localhost ([2409:10:2e40:5100:6e29:95ff:fe2d:8f34]) by smtp.gmail.com with ESMTPSA id s145sm22886088pfs.187.2020.11.17.18.06.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 18:06:51 -0800 (PST) Date: Wed, 18 Nov 2020 11:06:49 +0900 From: Sergey Senozhatsky To: Minchan Kim Subject: Re: [PATCH] Revert "mm/vunmap: add cond_resched() in vunmap_pmd_range" Message-ID: References: <20201105170249.387069-1-minchan@kernel.org> <20201106175933.90e4c8851010c9ce4dd732b6@linux-foundation.org> <20201107083939.GA1633068@google.com> <20201112200101.GC123036@google.com> <20201112144919.5f6b36876f4e59ebb4a99d6d@linux-foundation.org> <20201113162529.GA2378542@google.com> <20201116175323.GB3805951@google.com> <20201117135632.GA27763@infradead.org> <20201117202916.GA3856507@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201117202916.GA3856507@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201117_210659_976527_0881D93D X-CRM114-Status: GOOD ( 18.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sergey.senozhatsky.work@gmail.com, tony@atomide.com, "Aneesh Kumar K . V" , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Christoph Hellwig , linux-mm , Harish Sriram , Andrew Morton , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On (20/11/17 12:29), Minchan Kim wrote: > Yub, I remeber the discussion. > https://lore.kernel.org/linux-mm/20200416203736.GB50092@google.com/ > > I wanted to remove it but 30% gain made me think again before > deciding to drop it. > Since it continue to make problems and Linux is approaching to > deprecate the 32bit machines, I think it would be better to drop it > rather than inventing weird workaround. > > Ccing Tony since omap2plus have used it by default for just in case. > > From fc1b17a120991fd86b9e1153ab22d0b0bdadd8d0 Mon Sep 17 00:00:00 2001 > From: Minchan Kim > Date: Tue, 17 Nov 2020 11:58:51 -0800 > Subject: [PATCH] mm/zsmalloc.c: drop ZSMALLOC_PGTABLE_MAPPING > > Even though this option showed some amount improvement(e.g., 30%) > in some arm32 platforms, it has been headache to maintain since it > have abused APIs[1](e.g., unmap_kernel_range in atomic context). > > Since we are approaching to deprecate 32bit machines and already made > the config option available for only builtin build since v5.8, lastly > it has been not default option in zsmalloc, it's time to drop the > option for better maintainance. > > [1] http://lore.kernel.org/linux-mm/20201105170249.387069-1-minchan@kernel.org > > Cc: Tony Lindgren > Cc: Sergey Senozhatsky > Cc: Christoph Hellwig > Cc: > Fixes: e47110e90584 ("mm/vunmap: add cond_resched() in vunmap_pmd_range") > Signed-off-by: Minchan Kim Looks good to me. Reviewed-by: Sergey Senozhatsky -ss _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel