From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kmhm2-0000ai-K5 for mharc-grub-devel@gnu.org; Tue, 08 Dec 2020 13:31:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmhm0-0000Xj-F6 for grub-devel@gnu.org; Tue, 08 Dec 2020 13:31:40 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:46515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmhly-0001H5-71 for grub-devel@gnu.org; Tue, 08 Dec 2020 13:31:40 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 32DCDAEA; Tue, 8 Dec 2020 13:31:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 08 Dec 2020 13:31:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=VKiRYd4fwm2r3o78eEyAWhW9xh0 +k9Z3/33jglt90M0=; b=J6XcQuhSh0n1I7q2h9wX59Kd8ytJSBQSxA5ZWEgDmY2 Fkwl7zgLfhDJnGp+4cloGSwCHlzd1b4GGO1+m+SQKLtF/l+mIidS0p8zvcabFkqH lHVjq4lDOSX6yzptLPaikG1YYuyHmAK8Du6KxYCdlLAIgROLB0F2kns50asDqDn4 OegKGw48aXNew9Y0ggx0lLZrYxQ28vS5ia0wOgzEmHE53yifeLHvYrS1TxBf1TJs XN+qnef2YGmJZC7ZzJEJi3YyT7Ebhv5DlJImfqyV/CD7wwgYVpXnblS0PPLHmehQ vHUwcWGaIGr9eGlYz4SMYdYAndBqB2QvwMXnL5Sy7Xw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=VKiRYd 4fwm2r3o78eEyAWhW9xh0+k9Z3/33jglt90M0=; b=TZZqZ/72+WIhZ2Qh7Ip/z8 iTuTxfZHrw786bbp6dMFVrFkwuzDCdVJ/mTEPat3WgwwlU17zDbTI0mhdhMo1Ktz IVoKe+je+2P1aRqVy9DZwzzXpHtObkq1wWJ6yciW5DzBfcKLz3oF3++vIhOf95hu t2xA6at2S6ykqrjIQh3otBVw6k+tFuHbEfF6/fQcqxhWwLGjFUi8Xcl1pxgPYp9K qsLVsi6XA10N1WJ+5BrT6dva2cWVOrUKpiiLZOvbwgbxfPz48f0sUneMSkMJrChc r6ScCLV0O8yGgcQIFxhWaJEuHeJd4C+NHPSfuq7b8cT9A1hoCg61Ppt93ZaSF/GA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejiedgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhr ihgtkhcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecuggftrfgrthhtvg hrnhepheeghfdtfeeuffehkefgffduleffjedthfdvjeektdfhhedvlefgtefgvdettdfh necukfhppeejjedrudeluddrgedurdduheeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Received: from vm-mail (x4dbf299c.dyn.telefonica.de [77.191.41.156]) by mail.messagingengine.com (Postfix) with ESMTPA id C78161080057; Tue, 8 Dec 2020 13:31:33 -0500 (EST) Received: from localhost (tanuki [10.192.0.23]) by vm-mail (OpenSMTPD) with ESMTPSA id 1d076b84 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 8 Dec 2020 18:31:29 +0000 (UTC) Date: Tue, 8 Dec 2020 19:32:21 +0100 From: Patrick Steinhardt To: Glenn Washburn Cc: Daniel Kiper , grub-devel@gnu.org, Daniel Kiper Subject: Re: [PATCH v7 03/17] luks2: Remove unused argument in grub_error Message-ID: References: <20201207195244.ewtype67spf7bw4l@tomti.i.net-space.pl> <20201208114537.661d692b@crass-HP-ZBook-15-G2> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aFFgj6KNWtUaCt6r" Content-Disposition: inline In-Reply-To: <20201208114537.661d692b@crass-HP-ZBook-15-G2> Received-SPF: pass client-ip=64.147.123.21; envelope-from=ps@pks.im; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2020 18:31:40 -0000 --aFFgj6KNWtUaCt6r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 08, 2020 at 11:45:37AM -0600, Glenn Washburn wrote: > On Mon, 7 Dec 2020 20:52:44 +0100 > Daniel Kiper wrote: >=20 > > On Fri, Dec 04, 2020 at 10:43:32AM -0600, Glenn Washburn wrote: > > > Reviewed-by: Daniel Kiper > > > Signed-off-by: Glenn Washburn > >=20 > > Nit, my RB should be after your SOB. I will fix it. > >=20 > > Daniel >=20 > This is annoying to do with how my git is setup, which is to > automatically append my SOB when doing format-patch. Do you just do > SOBs and RBs by hand, or have a way to do this more automatically? >=20 > Glenn You can for example just use `git commit --signoff` when creating the commit. There's also `git rebase --signoff` to add SOBs for rebased patches if they don't have one yet. If RBs come in during review, I typically just `git rebase --interactive` and `r` commits to add the trailing RBs. Patrick --aFFgj6KNWtUaCt6r Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl/PxrQACgkQVbJhu7ck PpS/5RAAiZGi/ow2EBdKsw5Cn6WbuJmdS339O4NYHg5rKkpkyMq9/CI/yXZOGJSg M9Ln6c8gbaggoLZyY8YnLF63BoAnnAFlj+ZBBBWYv8rL4Oh3EldqS5dsckvRMjTP oU/e1lZAoM1qqwyZFKFU1BcUTiQsW39l83r646+uwOIUP3cIuvU4xx5bXvOGRBS7 FPjxgdwSP3nJAbY7DsNfBODyf0hu4zSYaVUt2VKpZVXW5P3Q6BZqPhOICcnNhCIs /kV7wGnHRkUq9lpnQqYuLl6UY7j2BTmJqYYH5GSEa7Gr1bmUnhKWaq9AasKAOEOc H7xnBDQTuIXNLqcOsVFT7Igb1TG7qXLRIMFxCy8UILLZlvLZ1VjXDkMwnWSForSd Nj9S2qIUeA1y0vnGFUEoiwNbXcqUdhQtk+Ael3Vevn1j6vUWtBBCm+2K+ecjkCbT mOFzeobp6aKvTNMCT3NkYibfEpjDlzxg+lqDr/RI6eaODv22rmJJVdyQ5cCXKOkK fMHi/OfI2CHHnjXC0ewdrMnypb7iRy8I4QP6X8trBxkl0haWROPQURzQax3fL9UB iFrak38ru1epu9YXJi4QIPY0K/WA9bV+6rBbPskBSPMgggCbmtHChZnmPM5MbalB Rcaugv881/kXDg1iEXiBcvRD6DuHsCX2TOUb7CyBwuDeSDEQsGU= =4VDR -----END PGP SIGNATURE----- --aFFgj6KNWtUaCt6r--