From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 047E3C433FE for ; Sun, 6 Dec 2020 22:39:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0066230FA for ; Sun, 6 Dec 2020 22:39:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728155AbgLFWjI (ORCPT ); Sun, 6 Dec 2020 17:39:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbgLFWjI (ORCPT ); Sun, 6 Dec 2020 17:39:08 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BBCFC0613D0; Sun, 6 Dec 2020 14:38:27 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0BC878D; Sun, 6 Dec 2020 23:38:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1607294304; bh=1wx/bpAq1sVWUhiUMz+GMMhPtjFkX7zepuboWLVNUj4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U9OReHadtVPn4VA99AVGXswMtfibJLXuJ4bubdePZGNeg+A+ZMGaxf/eWo2r6F6vR Z+3PEioIfI9A0pTmWgzDVmzWPtkke/81vPZimW5P3qNsN9ng7d4zCbdLi22nGFAuQq ITxN8CON5sxERUUwW9DTPSGLRIL/iC3C6M5Gfp6U= Date: Mon, 7 Dec 2020 00:38:21 +0200 From: Laurent Pinchart To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com, Kalyani Akula , Krzysztof Kozlowski , Manish Narani , Rajan Vaja , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 04/12] arm64: dts: zynqmp: Enable and wire reset controller Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, Thank you for the patch. On Wed, Dec 02, 2020 at 03:06:03PM +0100, Michal Simek wrote: > Enable reset controller for several IPs. > > Signed-off-by: Michal Simek > --- > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 29 ++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > index 68923fbd0e89..4fa820f78d76 100644 > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > @@ -187,6 +187,11 @@ zynqmp_pcap: pcap { > xlnx_aes: zynqmp-aes { > compatible = "xlnx,zynqmp-aes"; > }; > + > + zynqmp_reset: reset-controller { > + compatible = "xlnx,zynqmp-reset"; > + #reset-cells = <1>; > + }; > }; > }; > > @@ -466,6 +471,8 @@ gem0: ethernet@ff0b0000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_ETH_0>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GEM0>; > + reset-names = "gem0_rst"; I don't see any of the reset-names used in this patch defined in DT bindings (or used in drivers). For all devices but the USB controllers it seems they can be dropped. For the USB controllers, the bindings need to be updated first. > }; > > gem1: ethernet@ff0c0000 { > @@ -478,6 +485,8 @@ gem1: ethernet@ff0c0000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_ETH_1>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GEM1>; > + reset-names = "gem1_rst"; > }; > > gem2: ethernet@ff0d0000 { > @@ -490,6 +499,8 @@ gem2: ethernet@ff0d0000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_ETH_2>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GEM2>; > + reset-names = "gem2_rst"; > }; > > gem3: ethernet@ff0e0000 { > @@ -502,6 +513,8 @@ gem3: ethernet@ff0e0000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_ETH_3>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GEM3>; > + reset-names = "gem3_rst"; > }; > > gpio: gpio@ff0a0000 { > @@ -515,6 +528,8 @@ gpio: gpio@ff0a0000 { > #interrupt-cells = <2>; > reg = <0x0 0xff0a0000 0x0 0x1000>; > power-domains = <&zynqmp_firmware PD_GPIO>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GPIO>; > + reset-names = "gpio_rst"; > }; > > i2c0: i2c@ff020000 { > @@ -526,6 +541,8 @@ i2c0: i2c@ff020000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_I2C_0>; > + resets = <&zynqmp_reset ZYNQMP_RESET_I2C0>; > + reset-names = "i2c0_rst"; > }; > > i2c1: i2c@ff030000 { > @@ -537,6 +554,8 @@ i2c1: i2c@ff030000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_I2C_1>; > + resets = <&zynqmp_reset ZYNQMP_RESET_I2C1>; > + reset-names = "i2c1_rst"; > }; > > pcie: pcie@fd0e0000 { > @@ -602,6 +621,8 @@ sata: ahci@fd0c0000 { > interrupt-parent = <&gic>; > interrupts = <0 133 4>; > power-domains = <&zynqmp_firmware PD_SATA>; > + resets = <&zynqmp_reset ZYNQMP_RESET_SATA>; > + reset-names = "sata_rst"; > }; > > sdhci0: mmc@ff160000 { > @@ -733,6 +754,10 @@ usb0: usb@fe200000 { > reg = <0x0 0xfe200000 0x0 0x40000>; > clock-names = "clk_xin", "clk_ahb"; > power-domains = <&zynqmp_firmware PD_USB_0>; > + resets = <&zynqmp_reset ZYNQMP_RESET_USB0_CORERESET>, > + <&zynqmp_reset ZYNQMP_RESET_USB0_HIBERRESET>, > + <&zynqmp_reset ZYNQMP_RESET_USB0_APB>; > + reset-names = "usb0_crst", "usb0_hibrst", "usb0_apbrst"; > }; > > usb1: usb@fe300000 { > @@ -743,6 +768,10 @@ usb1: usb@fe300000 { > reg = <0x0 0xfe300000 0x0 0x40000>; > clock-names = "clk_xin", "clk_ahb"; > power-domains = <&zynqmp_firmware PD_USB_1>; > + resets = <&zynqmp_reset ZYNQMP_RESET_USB1_CORERESET>, > + <&zynqmp_reset ZYNQMP_RESET_USB1_HIBERRESET>, > + <&zynqmp_reset ZYNQMP_RESET_USB1_APB>; > + reset-names = "usb1_crst", "usb1_hibrst", "usb1_apbrst"; > }; > > watchdog0: watchdog@fd4d0000 { -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0BB6C4361B for ; Sun, 6 Dec 2020 22:40:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45032230FA for ; Sun, 6 Dec 2020 22:40:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45032230FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/X09WaWAcmg2TBtoal4fsVDrmq6d/4CFV1ApEpM7tuk=; b=pGTJTVWmhMR3X0vnkbMsAZDh2 BEDACQYGeqlNNM5mjfcvFX8MSgj61bnd01ZiqFhabDieGGoWai61ME/2fhg9QLIyv1Gq3kU+YJ+JV r+MpV1hOeW6gDmQvnhSXQx5WeB4EKeiu63lamEMkOHLSwPAAyk3o8aM02eum8D7HMggQwKn3Ktkhc IAJil37hgQCYojeg9dMByzB/lRuFYg6l20ccKtUM504r7TtPSX/21VTtXov/bEjwAxeNJdoHwz3PM xeiik3IqI0ML+0oyzpPFXCE87nOLQvvj5cqw3ZOmaPAtDeNWWlTx6sRDUggqbWRo9wohVwnxGOcVn sj3c+jnCA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1km2fq-0001k3-FX; Sun, 06 Dec 2020 22:38:34 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1km2fn-0001jc-0O for linux-arm-kernel@lists.infradead.org; Sun, 06 Dec 2020 22:38:32 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0BC878D; Sun, 6 Dec 2020 23:38:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1607294304; bh=1wx/bpAq1sVWUhiUMz+GMMhPtjFkX7zepuboWLVNUj4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U9OReHadtVPn4VA99AVGXswMtfibJLXuJ4bubdePZGNeg+A+ZMGaxf/eWo2r6F6vR Z+3PEioIfI9A0pTmWgzDVmzWPtkke/81vPZimW5P3qNsN9ng7d4zCbdLi22nGFAuQq ITxN8CON5sxERUUwW9DTPSGLRIL/iC3C6M5Gfp6U= Date: Mon, 7 Dec 2020 00:38:21 +0200 From: Laurent Pinchart To: Michal Simek Subject: Re: [PATCH 04/12] arm64: dts: zynqmp: Enable and wire reset controller Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201206_173831_393013_E0EFE427 X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, monstr@monstr.eu, Rajan Vaja , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Rob Herring , Manish Narani , git@xilinx.com, Kalyani Akula , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michal, Thank you for the patch. On Wed, Dec 02, 2020 at 03:06:03PM +0100, Michal Simek wrote: > Enable reset controller for several IPs. > > Signed-off-by: Michal Simek > --- > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 29 ++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > index 68923fbd0e89..4fa820f78d76 100644 > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > @@ -187,6 +187,11 @@ zynqmp_pcap: pcap { > xlnx_aes: zynqmp-aes { > compatible = "xlnx,zynqmp-aes"; > }; > + > + zynqmp_reset: reset-controller { > + compatible = "xlnx,zynqmp-reset"; > + #reset-cells = <1>; > + }; > }; > }; > > @@ -466,6 +471,8 @@ gem0: ethernet@ff0b0000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_ETH_0>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GEM0>; > + reset-names = "gem0_rst"; I don't see any of the reset-names used in this patch defined in DT bindings (or used in drivers). For all devices but the USB controllers it seems they can be dropped. For the USB controllers, the bindings need to be updated first. > }; > > gem1: ethernet@ff0c0000 { > @@ -478,6 +485,8 @@ gem1: ethernet@ff0c0000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_ETH_1>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GEM1>; > + reset-names = "gem1_rst"; > }; > > gem2: ethernet@ff0d0000 { > @@ -490,6 +499,8 @@ gem2: ethernet@ff0d0000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_ETH_2>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GEM2>; > + reset-names = "gem2_rst"; > }; > > gem3: ethernet@ff0e0000 { > @@ -502,6 +513,8 @@ gem3: ethernet@ff0e0000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_ETH_3>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GEM3>; > + reset-names = "gem3_rst"; > }; > > gpio: gpio@ff0a0000 { > @@ -515,6 +528,8 @@ gpio: gpio@ff0a0000 { > #interrupt-cells = <2>; > reg = <0x0 0xff0a0000 0x0 0x1000>; > power-domains = <&zynqmp_firmware PD_GPIO>; > + resets = <&zynqmp_reset ZYNQMP_RESET_GPIO>; > + reset-names = "gpio_rst"; > }; > > i2c0: i2c@ff020000 { > @@ -526,6 +541,8 @@ i2c0: i2c@ff020000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_I2C_0>; > + resets = <&zynqmp_reset ZYNQMP_RESET_I2C0>; > + reset-names = "i2c0_rst"; > }; > > i2c1: i2c@ff030000 { > @@ -537,6 +554,8 @@ i2c1: i2c@ff030000 { > #address-cells = <1>; > #size-cells = <0>; > power-domains = <&zynqmp_firmware PD_I2C_1>; > + resets = <&zynqmp_reset ZYNQMP_RESET_I2C1>; > + reset-names = "i2c1_rst"; > }; > > pcie: pcie@fd0e0000 { > @@ -602,6 +621,8 @@ sata: ahci@fd0c0000 { > interrupt-parent = <&gic>; > interrupts = <0 133 4>; > power-domains = <&zynqmp_firmware PD_SATA>; > + resets = <&zynqmp_reset ZYNQMP_RESET_SATA>; > + reset-names = "sata_rst"; > }; > > sdhci0: mmc@ff160000 { > @@ -733,6 +754,10 @@ usb0: usb@fe200000 { > reg = <0x0 0xfe200000 0x0 0x40000>; > clock-names = "clk_xin", "clk_ahb"; > power-domains = <&zynqmp_firmware PD_USB_0>; > + resets = <&zynqmp_reset ZYNQMP_RESET_USB0_CORERESET>, > + <&zynqmp_reset ZYNQMP_RESET_USB0_HIBERRESET>, > + <&zynqmp_reset ZYNQMP_RESET_USB0_APB>; > + reset-names = "usb0_crst", "usb0_hibrst", "usb0_apbrst"; > }; > > usb1: usb@fe300000 { > @@ -743,6 +768,10 @@ usb1: usb@fe300000 { > reg = <0x0 0xfe300000 0x0 0x40000>; > clock-names = "clk_xin", "clk_ahb"; > power-domains = <&zynqmp_firmware PD_USB_1>; > + resets = <&zynqmp_reset ZYNQMP_RESET_USB1_CORERESET>, > + <&zynqmp_reset ZYNQMP_RESET_USB1_HIBERRESET>, > + <&zynqmp_reset ZYNQMP_RESET_USB1_APB>; > + reset-names = "usb1_crst", "usb1_hibrst", "usb1_apbrst"; > }; > > watchdog0: watchdog@fd4d0000 { -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel