From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC948C433FE for ; Sun, 6 Dec 2020 22:48:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A43623107 for ; Sun, 6 Dec 2020 22:48:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728156AbgLFWrj (ORCPT ); Sun, 6 Dec 2020 17:47:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727123AbgLFWrj (ORCPT ); Sun, 6 Dec 2020 17:47:39 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30E92C0613D0; Sun, 6 Dec 2020 14:46:59 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DCA4C8D; Sun, 6 Dec 2020 23:46:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1607294817; bh=cOvWlh2xukW7Neo9qIrLq/5PlWpNQ+z1o2dslPsOy1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ULQu+TGHtST+9Bae03mAA45NHrvRFTMStNedK3kSnra5HUEqCWPUIjCTlvR464SKU gUa1qWUmTBiYQuF/SnKP39UAUd0yvwLnhyiwRHHeF41M3lDU6LECSsgp/oAxuY6oW9 1jQlCOdpoK7IAixzO8czaUrjSB51UL5myYC+Ly0A= Date: Mon, 7 Dec 2020 00:46:54 +0200 From: Laurent Pinchart To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com, Kalyani Akula , Krzysztof Kozlowski , Manish Narani , Rajan Vaja , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 06/12] arm64: dts: zynqmp: Add label for zynqmp_ipi Message-ID: References: <272e23e0123f02c559bfa4ada9de73eb197aced8.1606917949.git.michal.simek@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <272e23e0123f02c559bfa4ada9de73eb197aced8.1606917949.git.michal.simek@xilinx.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, Thank you for the patch. On Wed, Dec 02, 2020 at 03:06:05PM +0100, Michal Simek wrote: > Add label which is used by bootloader for adding bootloader specific flag. > > Signed-off-by: Michal Simek > --- > > U-Boot needs to add u-boot,dm-pre-reloc; property I'm not entirely sure what best practice rules are in this area, but shouldn't U-Boot locate the node by name instead of label ? > --- > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > index 4fa820f78d76..8e9b54b5e70c 100644 > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > @@ -99,7 +99,7 @@ opp03 { > }; > }; > > - zynqmp_ipi { > + zynqmp_ipi: zynqmp_ipi { > compatible = "xlnx,zynqmp-ipi-mailbox"; > interrupt-parent = <&gic>; > interrupts = <0 35 4>; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BD73C4361B for ; Sun, 6 Dec 2020 22:48:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B87123107 for ; Sun, 6 Dec 2020 22:48:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B87123107 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q4w5GtShBvXtyzUxQK/ugpHZTELd6jHvB4JQ9YjfvHY=; b=rdTUY1AUGPtAlxF65whyqgJ0D 2iRIAt1jZ+aBDlIh5lCrGiYXG9493GSvmJ2C1qeLoZqJhCkBUtsq4ryriRIgsjfwNX8aj474OCLpF ZbmYifRrnMuCZOnGYtuePQd1SJepOhqZp0wJdsqX4j2YWmM1monzg8giNC9FUxoaTg5jT0QbO3/8X RhuN+1yBI1+TS85prZpNaaxBuOlNwWkbbQgOwjh9fnDBk3gWZ78PtgVCkD1c6bHjFXUELnXz08ZH6 LLhKxluVyHmIPFU87fGfZh2lKgLAFHXqe6YTBkOcYEGyZqvCDwUKRKWKtemumL8vTKMppHn+BV8ro 1+nVJwlVg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1km2o1-0002CO-Bn; Sun, 06 Dec 2020 22:47:01 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1km2nz-0002C3-EM for linux-arm-kernel@lists.infradead.org; Sun, 06 Dec 2020 22:47:00 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DCA4C8D; Sun, 6 Dec 2020 23:46:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1607294817; bh=cOvWlh2xukW7Neo9qIrLq/5PlWpNQ+z1o2dslPsOy1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ULQu+TGHtST+9Bae03mAA45NHrvRFTMStNedK3kSnra5HUEqCWPUIjCTlvR464SKU gUa1qWUmTBiYQuF/SnKP39UAUd0yvwLnhyiwRHHeF41M3lDU6LECSsgp/oAxuY6oW9 1jQlCOdpoK7IAixzO8czaUrjSB51UL5myYC+Ly0A= Date: Mon, 7 Dec 2020 00:46:54 +0200 From: Laurent Pinchart To: Michal Simek Subject: Re: [PATCH 06/12] arm64: dts: zynqmp: Add label for zynqmp_ipi Message-ID: References: <272e23e0123f02c559bfa4ada9de73eb197aced8.1606917949.git.michal.simek@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <272e23e0123f02c559bfa4ada9de73eb197aced8.1606917949.git.michal.simek@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201206_174659_691661_D6BAC845 X-CRM114-Status: GOOD ( 16.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, monstr@monstr.eu, Rajan Vaja , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Rob Herring , Manish Narani , git@xilinx.com, Kalyani Akula , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michal, Thank you for the patch. On Wed, Dec 02, 2020 at 03:06:05PM +0100, Michal Simek wrote: > Add label which is used by bootloader for adding bootloader specific flag. > > Signed-off-by: Michal Simek > --- > > U-Boot needs to add u-boot,dm-pre-reloc; property I'm not entirely sure what best practice rules are in this area, but shouldn't U-Boot locate the node by name instead of label ? > --- > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > index 4fa820f78d76..8e9b54b5e70c 100644 > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > @@ -99,7 +99,7 @@ opp03 { > }; > }; > > - zynqmp_ipi { > + zynqmp_ipi: zynqmp_ipi { > compatible = "xlnx,zynqmp-ipi-mailbox"; > interrupt-parent = <&gic>; > interrupts = <0 35 4>; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel