From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0FF1C433FE for ; Tue, 8 Dec 2020 00:44:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 825EE23A04 for ; Tue, 8 Dec 2020 00:44:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728825AbgLHAnm (ORCPT ); Mon, 7 Dec 2020 19:43:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728824AbgLHAnm (ORCPT ); Mon, 7 Dec 2020 19:43:42 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB13FC061794 for ; Mon, 7 Dec 2020 16:43:01 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C5ADDD; Tue, 8 Dec 2020 01:43:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1607388180; bh=sXJJQ3Ales9snSM+M951qVfwVZH4bo1xYMrGw8Lpq9Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FQSetC4HXvcy/ljFLmrhL7T9XbUuMZSSBPTz78w2qxhWVLqXotEyYaZBLTVy3I7IP fLS+PoCfAbo9W1c63ChXr1sqWBzUZlDh6t7XlRvXXXY17KWXb1eks/VBu03Zy5a4D0 Euw6t6DVm6SBO4Hg3qSmbNm6q1M8c8V1qqxZpbiU= Date: Tue, 8 Dec 2020 02:42:57 +0200 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Laurent Pinchart , DRI Development , Linux-Renesas , Kieran Bingham , Kuninori Morimoto Subject: Re: [PATCH 1/9] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC Message-ID: References: <20201204220139.15272-1-laurent.pinchart+renesas@ideasonboard.com> <20201204220139.15272-2-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Geert, On Mon, Dec 07, 2020 at 09:15:11AM +0100, Geert Uytterhoeven wrote: > On Fri, Dec 4, 2020 at 11:02 PM Laurent Pinchart wrote: > > On D3 and E3 platforms, the LVDS encoder includes a PLL that can > > generate a clock for the corresponding CRTC, used even when the CRTC > > output to a non-LVDS port. This mechanism is supported by the driver, > > but the implementation is broken in dual-link LVDS mode. In that case, > > the LVDS1 drm_encoder is skipped, which causes a crash when trying to > > access its bridge later on. > > > > Fix this by storing bridge pointers internally instead of retrieving > > them from the encoder. > > > > Signed-off-by: Laurent Pinchart > > Thanks for your patch! > > I think this warrants a Fixes tag, to assist the stable team in backporting > this fix. I'll add one. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 522E4C4361B for ; Tue, 8 Dec 2020 00:43:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93839238EB for ; Tue, 8 Dec 2020 00:43:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93839238EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C873D6E8B5; Tue, 8 Dec 2020 00:43:03 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB1F26E8B5 for ; Tue, 8 Dec 2020 00:43:02 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C5ADDD; Tue, 8 Dec 2020 01:43:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1607388180; bh=sXJJQ3Ales9snSM+M951qVfwVZH4bo1xYMrGw8Lpq9Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FQSetC4HXvcy/ljFLmrhL7T9XbUuMZSSBPTz78w2qxhWVLqXotEyYaZBLTVy3I7IP fLS+PoCfAbo9W1c63ChXr1sqWBzUZlDh6t7XlRvXXXY17KWXb1eks/VBu03Zy5a4D0 Euw6t6DVm6SBO4Hg3qSmbNm6q1M8c8V1qqxZpbiU= Date: Tue, 8 Dec 2020 02:42:57 +0200 From: Laurent Pinchart To: Geert Uytterhoeven Subject: Re: [PATCH 1/9] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC Message-ID: References: <20201204220139.15272-1-laurent.pinchart+renesas@ideasonboard.com> <20201204220139.15272-2-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-Renesas , Kuninori Morimoto , Laurent Pinchart , Kieran Bingham , DRI Development Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Geert, On Mon, Dec 07, 2020 at 09:15:11AM +0100, Geert Uytterhoeven wrote: > On Fri, Dec 4, 2020 at 11:02 PM Laurent Pinchart wrote: > > On D3 and E3 platforms, the LVDS encoder includes a PLL that can > > generate a clock for the corresponding CRTC, used even when the CRTC > > output to a non-LVDS port. This mechanism is supported by the driver, > > but the implementation is broken in dual-link LVDS mode. In that case, > > the LVDS1 drm_encoder is skipped, which causes a crash when trying to > > access its bridge later on. > > > > Fix this by storing bridge pointers internally instead of retrieving > > them from the encoder. > > > > Signed-off-by: Laurent Pinchart > > Thanks for your patch! > > I think this warrants a Fixes tag, to assist the stable team in backporting > this fix. I'll add one. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel