All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Marc Zyngier <maz@kernel.org>, Johan Hovold <johan@kernel.org>,
	linux-usb <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] USB: serial: ftdi_sio: Helpful error on GPIO attempt
Date: Tue, 8 Dec 2020 10:02:59 +0100	[thread overview]
Message-ID: <X89BQ9l1ilubUNUd@localhost> (raw)
In-Reply-To: <CACRpkdaNQ_JgHX=1aEDBR5dpF-1b2Zwx-z8qG5F6VhRW_Au_Qg@mail.gmail.com>

On Tue, Dec 08, 2020 at 09:39:25AM +0100, Linus Walleij wrote:
> On Wed, Dec 2, 2020 at 7:13 PM Marc Zyngier <maz@kernel.org> wrote:
> 
> > And to clarify what I mean, here's a patchlet that does the trick.
> >
> > maz@tiger-roach:~$ sudo gpioinfo gpiochip3
> > gpiochip3 - 4 lines:
> >         line   0:      unnamed       unused  output  active-high
> >         line   1:      "AltFunc"     kernel  input   active-high [used]
> >         line   2:      "AltFunc"     kernel  input   active-high [used]
> >         line   3:      "AltFunc"     kernel  input   active-high [used]
> >
> > It at least make clear that you can't grab the GPIO. Of course, you
> > don't get the message that you just added...
> 
> I think this looks good.
> 
> > +#include "../../gpio/gpiolib.h"
> 
> I suppose I can live with this because it's for a noble cause.

Not needed, Marc fixed that bit up in his series.

> > Thoughts?
> 
> Could you combine it with a patch similar to min giving some probe() time
> information that some GPIO lines are altfunc and where to get the tool
> and send a proper patch?

He already did that, but I'm sceptical to spamming the logs with this
(we don't explain how people should setup up pinmuxing in their device
trees in the logs either). Please take a look at the discussion
following Marc's series.

Johan

      reply	other threads:[~2020-12-08  9:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 14:10 [PATCH] USB: serial: ftdi_sio: Helpful error on GPIO attempt Linus Walleij
2020-12-01 15:01 ` Marc Zyngier
2020-12-02 18:13   ` Marc Zyngier
2020-12-08  8:39     ` Linus Walleij
2020-12-08  9:02       ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X89BQ9l1ilubUNUd@localhost \
    --to=johan@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=maz@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.