From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04C38C71156 for ; Wed, 2 Dec 2020 17:14:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9283121D7F for ; Wed, 2 Dec 2020 17:14:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728658AbgLBROA (ORCPT ); Wed, 2 Dec 2020 12:14:00 -0500 Received: from mout.gmx.net ([212.227.15.18]:39967 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726276AbgLBROA (ORCPT ); Wed, 2 Dec 2020 12:14:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1606929099; bh=pQC+UTEB5yU7IDsAP8sscDmvQ/csugMq2wi4Lt2jCMA=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=A0lCja33qclyOmZ7pNpDKQShzqbo23g+otRjsFG0Jw0PPfURqItluSbaPQ3YKyUF2 /RK3dxDCkrc6NHp/8TeNxUMBqOOaiDFcE+v4Bu9XbMWvwVZsYkk8zr5SUo46fApa9v Pu91t1T++C4moITBAUkKhFYpVavUc6ELNLTrtAgc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([37.201.214.162]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MyKDe-1jz1Db2IqC-00yhlw; Wed, 02 Dec 2020 18:11:39 +0100 Date: Wed, 2 Dec 2020 18:11:33 +0100 From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= To: Lee Jones Cc: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Alessandro Zummo , Alexandre Belloni , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sam Ravnborg , Linus Walleij , Heiko Stuebner , Stephan Gerhold , Lubomir Rintel , Mark Brown , allen , Mauro Carvalho Chehab , "David S. Miller" , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Josua Mayer , Andreas Kemnade , Arnd Bergmann , Daniel Palmer , Andy Shevchenko Subject: Re: [PATCH v4 3/7] mfd: Add base driver for Netronix embedded controller Message-ID: References: <20201122222739.1455132-1-j.neuschaefer@gmx.net> <20201122222739.1455132-4-j.neuschaefer@gmx.net> <20201202130520.GL4801@dell> <20201202150943.GN4801@dell> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CjPGjgSPWBKyBoQi" Content-Disposition: inline In-Reply-To: <20201202150943.GN4801@dell> X-Provags-ID: V03:K1:pby5GaQCe/HvbnOvEPJyjfFrmN1ZR4ZMPcfMTgZaH6QQIMsS9Kk 4X7RFptBlMUrsOi/IIHFOdGz6JOATLTuLKB+sNi0sga4tNzYQZnvZYKpySbykNt/qhlpN9m 2GhhtQC00i2p8m4LQZtIchq7CW5lOPahB2AIqYhkP2inWc46iGs+vRKE07MafwuO4RGt9gy 0RI3dJrCYEJYrXML1pzIA== X-UI-Out-Filterresults: notjunk:1;V03:K0:TNBPRIlwunk=:Nsl6q2hLwYL/UQGmoy/mDT nJeEY3anUdcnRMg89CcfnQn78e6G0Gyc0oVud99TyvgqFlcXd6k4FNsiO4B35wvTAOFKOwSbF j9XMa3HTtStNcWOtJ8DUtja29Hl2V/cLObQAka/FWDxFpyJpS6pLc+TmmaTH2Fnpwwq032ktD DpxadmmYTOh5J8sxT5O4qDNDw/kUVan8bxlIvJsS0PBtDJpmhhxdBaEail1revilANxYSDsGv co8wnWFiZSFKL2K8rFDqmnt4Nw3r/dz6vqxIThJhYno2HR5PSKxjWsHAk8MGk/btb9h7xz6z+ Dg5J7rm4dDhdvm4LdVxf3JOWpQbgjN+ju4qNlRPTRn0aB+zauWeQ2cAiea48st9hoZYtchwwU zobmBt0lksLNGetBv5g+S2tJX1e5fF6NuE1P02PAysh19jJ9V817wRFS6bzcDj/+fSOHk6/Ry ngmiSJD0cAD7lcYiUDhe7VURl68v3n6KAWqCiVuBra9bMP2/EhxnP9xIZG5U4kGAEAXufzzXm VBaAow2uTDxd5GVswv9/2fDh26MTtmGkikNEhkXzA8oXrykeLUmmFFeIMxgsRZvP5eTrj3Utm HsTRlXQz6AdN7mmavpGPHNOHs2Q8WFlVTECfnBY70ri0LEzrgqYXDJ/cjlFrW7GTd9qhnAjjf tuIeuWrNQeo2/PApJ8l+stvGPZfYcSkEf87UPXYMFYDvtOfZtrkPAsV4oz7diaOmu2RNCiyfk jrGR58sioE3IWAfT9PFH0f/b+JobE9C6xXwMtmq6cfNw1vtqEV2bBGM3xDwtwOshPISSCxaEn kIbtFEA7j4EAyvMpq+s6NsLg+cZ8XAx/LUsbR5SWvdMEZEBrGwyvEXeG402lbtNQ1l66Ok951 koPkNlYD/HEYykIASRyQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --CjPGjgSPWBKyBoQi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 02, 2020 at 03:09:43PM +0000, Lee Jones wrote: > On Wed, 02 Dec 2020, Jonathan Neusch=C3=A4fer wrote: >=20 > > On Wed, Dec 02, 2020 at 01:05:20PM +0000, Lee Jones wrote: > > > On Sun, 22 Nov 2020, Jonathan Neusch=C3=A4fer wrote: > > [...] > > > > + /* Bail out if we encounter an unknown firmware version */ > > > > + switch (version) { > > > > + case 0xd726: /* found in Kobo Aura */ > > >=20 > > > No magic numbers. > > >=20 > > > Please submit a subsequent patch to define this. > >=20 > > Will do. > >=20 > > But I don't think I'll be able to give it a more meaningful name than > > NTXEC_VERSION_D726. I don't have a good overview of which versions > > appear in which devices. "0xd726 found in Kobo Aura" only means that; > > I don't know if it's the only version used in the Kobo Aura, and I don't > > know if the Kobo Aura is the only device where it is used. >=20 > Defines are not set in stone. >=20 > They can evolve over time as more is known. >=20 > NTXEC_KOBO_AURA would be fine for now. Alright. Thanks, Jonathan Neusch=C3=A4fer --CjPGjgSPWBKyBoQi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAl/HyrUACgkQCDBEmo7z X9ujoRAAiSfqDRe/Gtnw9hmQ5U6LeACNBPYHEExRWA9+KkwWBO6oVYGD06v1QLp/ 7M9dBhcudCM7OXobAwKgZWlnDOTgTct1TNehCOzq7ZyCUbz1oe5+QN+KY98RQNgK 2ZxEIJFrCoyWSBrPRH6qAiFDb3E28xIYJmZmX/EoHYOiVUfeo9DaaiLTZrIOapRg jjUZ5SDM99aB7z2TGjdjpSyRee+t0jSNgvrdb+z+oJ0ODiKJmWYVvCtHWtiZ+30J h5z31aKESIm2BaAxM6Xdv2m4OvWURx61gVCx51KVELcwGDtza2nz9osBrcLWqiWm OVBszstZwniWDNHqEGx5D4jnYdzLE6YG2ll5O9E3fPzrx3Vr28xmabea8bLiw6gF v1jDpZIy/Vx9vxz5+baXfPFLHBqLqNmsXHW0r4EAcNDyBy3B97Qq1R64nCBPKt7c 3wV+5ja9hykCjQLXAoH9TuATnTP7d5Ya4+njW6KP2p9p6PocSrG9mkKHlgucZGNZ ZYGOndbFNw16IOyHhu5Vr8LnvND7qZiYbP1i16L3CVduulbnJGVdWF3v1iH8IHHD yb67MJGHa+qDRI1AAsRt0KgM8Pd9sRmrqIxFDlOp0LOscg45FifdV8k5WjQ79hkT s5oiVIYAZ0bHyKLggR/Q3yvBFG695uXZucUUZMKj9WyBTYZOsfQ= =OnND -----END PGP SIGNATURE----- --CjPGjgSPWBKyBoQi-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD863C64E7B for ; Wed, 2 Dec 2020 17:14:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42626217A0 for ; Wed, 2 Dec 2020 17:14:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42626217A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QUSiOij0GkjZm+zTy4zLkO3M6sJiiSuUzxMtFMFNANM=; b=sWaUpdTRqBctCd3kwj5j6JASS OA5blygW/NRI0tXga/OehRtee/TgpA/VQ9nwgAwK/3XEQGmA2Nw1cK5znC/Qqf7iYD2c2pvEkeHAy U7iEyVRijObdUb+/rImoQBO7amvnfH0lvdeS26AeXzbNg6dTB7y4put2KBG+VsPLLkexdWjHM6lLr PLzrAROcQYAfA7pgTe+9SGWmbvvm163Iv7n+CY2YTOP9qQYQJzNoKadVewjExQ/PaHGKjzGPbNISZ 2b6DgCz/Mpl1a8Qiw1J5/tSjtcaMXwni2arveElCMwERUVoCakJfs0ZPs3fOwR9D+oKPZccrAirRw u1JO+MAzA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkVg3-0008Ck-GR; Wed, 02 Dec 2020 17:12:27 +0000 Received: from mout.gmx.net ([212.227.15.18]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkVfz-0008Bv-Uv for linux-arm-kernel@lists.infradead.org; Wed, 02 Dec 2020 17:12:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1606929099; bh=pQC+UTEB5yU7IDsAP8sscDmvQ/csugMq2wi4Lt2jCMA=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=A0lCja33qclyOmZ7pNpDKQShzqbo23g+otRjsFG0Jw0PPfURqItluSbaPQ3YKyUF2 /RK3dxDCkrc6NHp/8TeNxUMBqOOaiDFcE+v4Bu9XbMWvwVZsYkk8zr5SUo46fApa9v Pu91t1T++C4moITBAUkKhFYpVavUc6ELNLTrtAgc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([37.201.214.162]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MyKDe-1jz1Db2IqC-00yhlw; Wed, 02 Dec 2020 18:11:39 +0100 Date: Wed, 2 Dec 2020 18:11:33 +0100 From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= To: Lee Jones Subject: Re: [PATCH v4 3/7] mfd: Add base driver for Netronix embedded controller Message-ID: References: <20201122222739.1455132-1-j.neuschaefer@gmx.net> <20201122222739.1455132-4-j.neuschaefer@gmx.net> <20201202130520.GL4801@dell> <20201202150943.GN4801@dell> MIME-Version: 1.0 In-Reply-To: <20201202150943.GN4801@dell> X-Provags-ID: V03:K1:pby5GaQCe/HvbnOvEPJyjfFrmN1ZR4ZMPcfMTgZaH6QQIMsS9Kk 4X7RFptBlMUrsOi/IIHFOdGz6JOATLTuLKB+sNi0sga4tNzYQZnvZYKpySbykNt/qhlpN9m 2GhhtQC00i2p8m4LQZtIchq7CW5lOPahB2AIqYhkP2inWc46iGs+vRKE07MafwuO4RGt9gy 0RI3dJrCYEJYrXML1pzIA== X-UI-Out-Filterresults: notjunk:1;V03:K0:TNBPRIlwunk=:Nsl6q2hLwYL/UQGmoy/mDT nJeEY3anUdcnRMg89CcfnQn78e6G0Gyc0oVud99TyvgqFlcXd6k4FNsiO4B35wvTAOFKOwSbF j9XMa3HTtStNcWOtJ8DUtja29Hl2V/cLObQAka/FWDxFpyJpS6pLc+TmmaTH2Fnpwwq032ktD DpxadmmYTOh5J8sxT5O4qDNDw/kUVan8bxlIvJsS0PBtDJpmhhxdBaEail1revilANxYSDsGv co8wnWFiZSFKL2K8rFDqmnt4Nw3r/dz6vqxIThJhYno2HR5PSKxjWsHAk8MGk/btb9h7xz6z+ Dg5J7rm4dDhdvm4LdVxf3JOWpQbgjN+ju4qNlRPTRn0aB+zauWeQ2cAiea48st9hoZYtchwwU zobmBt0lksLNGetBv5g+S2tJX1e5fF6NuE1P02PAysh19jJ9V817wRFS6bzcDj/+fSOHk6/Ry ngmiSJD0cAD7lcYiUDhe7VURl68v3n6KAWqCiVuBra9bMP2/EhxnP9xIZG5U4kGAEAXufzzXm VBaAow2uTDxd5GVswv9/2fDh26MTtmGkikNEhkXzA8oXrykeLUmmFFeIMxgsRZvP5eTrj3Utm HsTRlXQz6AdN7mmavpGPHNOHs2Q8WFlVTECfnBY70ri0LEzrgqYXDJ/cjlFrW7GTd9qhnAjjf tuIeuWrNQeo2/PApJ8l+stvGPZfYcSkEf87UPXYMFYDvtOfZtrkPAsV4oz7diaOmu2RNCiyfk jrGR58sioE3IWAfT9PFH0f/b+JobE9C6xXwMtmq6cfNw1vtqEV2bBGM3xDwtwOshPISSCxaEn kIbtFEA7j4EAyvMpq+s6NsLg+cZ8XAx/LUsbR5SWvdMEZEBrGwyvEXeG402lbtNQ1l66Ok951 koPkNlYD/HEYykIASRyQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201202_121224_236230_0934BD55 X-CRM114-Status: GOOD ( 23.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Heiko Stuebner , linux-pwm@vger.kernel.org, Linus Walleij , Thierry Reding , Sam Ravnborg , linux-rtc@vger.kernel.org, Arnd Bergmann , Mauro Carvalho Chehab , Fabio Estevam , Daniel Palmer , Andy Shevchenko , Andreas Kemnade , NXP Linux Team , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , devicetree@vger.kernel.org, Stephan Gerhold , allen , Sascha Hauer , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Lubomir Rintel , Mark Brown , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , linux-kernel@vger.kernel.org, Rob Herring , Pengutronix Kernel Team , Heiko Stuebner , Josua Mayer , Shawn Guo , "David S. Miller" Content-Type: multipart/mixed; boundary="===============8512367007558406299==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8512367007558406299== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CjPGjgSPWBKyBoQi" Content-Disposition: inline --CjPGjgSPWBKyBoQi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 02, 2020 at 03:09:43PM +0000, Lee Jones wrote: > On Wed, 02 Dec 2020, Jonathan Neusch=C3=A4fer wrote: >=20 > > On Wed, Dec 02, 2020 at 01:05:20PM +0000, Lee Jones wrote: > > > On Sun, 22 Nov 2020, Jonathan Neusch=C3=A4fer wrote: > > [...] > > > > + /* Bail out if we encounter an unknown firmware version */ > > > > + switch (version) { > > > > + case 0xd726: /* found in Kobo Aura */ > > >=20 > > > No magic numbers. > > >=20 > > > Please submit a subsequent patch to define this. > >=20 > > Will do. > >=20 > > But I don't think I'll be able to give it a more meaningful name than > > NTXEC_VERSION_D726. I don't have a good overview of which versions > > appear in which devices. "0xd726 found in Kobo Aura" only means that; > > I don't know if it's the only version used in the Kobo Aura, and I don't > > know if the Kobo Aura is the only device where it is used. >=20 > Defines are not set in stone. >=20 > They can evolve over time as more is known. >=20 > NTXEC_KOBO_AURA would be fine for now. Alright. Thanks, Jonathan Neusch=C3=A4fer --CjPGjgSPWBKyBoQi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAl/HyrUACgkQCDBEmo7z X9ujoRAAiSfqDRe/Gtnw9hmQ5U6LeACNBPYHEExRWA9+KkwWBO6oVYGD06v1QLp/ 7M9dBhcudCM7OXobAwKgZWlnDOTgTct1TNehCOzq7ZyCUbz1oe5+QN+KY98RQNgK 2ZxEIJFrCoyWSBrPRH6qAiFDb3E28xIYJmZmX/EoHYOiVUfeo9DaaiLTZrIOapRg jjUZ5SDM99aB7z2TGjdjpSyRee+t0jSNgvrdb+z+oJ0ODiKJmWYVvCtHWtiZ+30J h5z31aKESIm2BaAxM6Xdv2m4OvWURx61gVCx51KVELcwGDtza2nz9osBrcLWqiWm OVBszstZwniWDNHqEGx5D4jnYdzLE6YG2ll5O9E3fPzrx3Vr28xmabea8bLiw6gF v1jDpZIy/Vx9vxz5+baXfPFLHBqLqNmsXHW0r4EAcNDyBy3B97Qq1R64nCBPKt7c 3wV+5ja9hykCjQLXAoH9TuATnTP7d5Ya4+njW6KP2p9p6PocSrG9mkKHlgucZGNZ ZYGOndbFNw16IOyHhu5Vr8LnvND7qZiYbP1i16L3CVduulbnJGVdWF3v1iH8IHHD yb67MJGHa+qDRI1AAsRt0KgM8Pd9sRmrqIxFDlOp0LOscg45FifdV8k5WjQ79hkT s5oiVIYAZ0bHyKLggR/Q3yvBFG695uXZucUUZMKj9WyBTYZOsfQ= =OnND -----END PGP SIGNATURE----- --CjPGjgSPWBKyBoQi-- --===============8512367007558406299== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8512367007558406299==--