From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF9F0C4361A for ; Sat, 5 Dec 2020 15:05:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3E5F2251D for ; Sat, 5 Dec 2020 15:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbgLEPAt (ORCPT ); Sat, 5 Dec 2020 10:00:49 -0500 Received: from isilmar-4.linta.de ([136.243.71.142]:36792 "EHLO isilmar-4.linta.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726600AbgLEO4e (ORCPT ); Sat, 5 Dec 2020 09:56:34 -0500 X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES Received: from light.dominikbrodowski.net (brodo.linta [10.2.0.102]) by isilmar-4.linta.de (Postfix) with ESMTPSA id ED40F2010FA; Sat, 5 Dec 2020 09:05:29 +0000 (UTC) Received: by light.dominikbrodowski.net (Postfix, from userid 1000) id A49C820EC0; Sat, 5 Dec 2020 09:31:04 +0100 (CET) Date: Sat, 5 Dec 2020 09:31:04 +0100 From: Dominik Brodowski To: Christophe JAILLET Cc: akpm@linux-foundation.org, peterz@infradead.org, olof@lixom.net, hch@lst.de, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] pcmcia/electra_cf: Fix some return values in 'electra_cf_probe()' in case of error Message-ID: References: <20200617195326.732863-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200617195326.732863-1-christophe.jaillet@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Wed, Jun 17, 2020 at 09:53:26PM +0200 schrieb Christophe JAILLET: > 'status' is known to be 0 at this point. It must be set to a meaningful > value in order to return an error code if one of the 'of_get_property()' > call fails. > > Return -EINVAL in such a case. > > Fixes: 2b571a066a2f("pcmcia: CompactFlash driver for PA Semi Electra boards") > Signed-off-by: Christophe JAILLET Applied to pcmcia-next. Thanks! Dominik From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dominik Brodowski Date: Sat, 05 Dec 2020 08:31:04 +0000 Subject: Re: [PATCH] pcmcia/electra_cf: Fix some return values in 'electra_cf_probe()' in case of error Message-Id: List-Id: References: <20200617195326.732863-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20200617195326.732863-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: akpm@linux-foundation.org, peterz@infradead.org, olof@lixom.net, hch@lst.de, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Am Wed, Jun 17, 2020 at 09:53:26PM +0200 schrieb Christophe JAILLET: > 'status' is known to be 0 at this point. It must be set to a meaningful > value in order to return an error code if one of the 'of_get_property()' > call fails. > > Return -EINVAL in such a case. > > Fixes: 2b571a066a2f("pcmcia: CompactFlash driver for PA Semi Electra boards") > Signed-off-by: Christophe JAILLET Applied to pcmcia-next. Thanks! Dominik