All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Cc: linux-serial@vger.kernel.org, git@xilinx.com, jacmet@sunsite.dk,
	linuxfoundation.org@xilinx.com
Subject: Re: [PATCH 3/3] serial-uartlite: Remove an un-necessary read of control register
Date: Wed, 9 Dec 2020 15:33:47 +0100	[thread overview]
Message-ID: <X9DgS7j8L45EdtoR@kroah.com> (raw)
In-Reply-To: <1607516301-26975-3-git-send-email-shubhrajyoti.datta@xilinx.com>

On Wed, Dec 09, 2020 at 05:48:21PM +0530, Shubhrajyoti Datta wrote:
> The control register is a writeonly register that's why reading it
> doesn't make any sense.

Are you _SURE_?  Many times this is needed for hardware control...

Can you point to the documentation that says this is ok to remove?

thanks,

greg k-h

  reply	other threads:[~2020-12-09 14:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09 12:18 [PATCH 1/3] serial-uartlite: Disable clocks in the error path Shubhrajyoti Datta
2020-12-09 12:18 ` [PATCH 2/3] serial-uartlite: Add runtime pm support Shubhrajyoti Datta
2020-12-09 14:33   ` Greg KH
2020-12-09 12:18 ` [PATCH 3/3] serial-uartlite: Remove an un-necessary read of control register Shubhrajyoti Datta
2020-12-09 14:33   ` Greg KH [this message]
2020-12-09 14:32 ` [PATCH 1/3] serial-uartlite: Disable clocks in the error path Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X9DgS7j8L45EdtoR@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=git@xilinx.com \
    --cc=jacmet@sunsite.dk \
    --cc=linux-serial@vger.kernel.org \
    --cc=linuxfoundation.org@xilinx.com \
    --cc=shubhrajyoti.datta@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.