From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E64E0C0018C for ; Thu, 10 Dec 2020 09:28:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB14923D9E for ; Thu, 10 Dec 2020 09:28:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731643AbgLJJ2Y (ORCPT ); Thu, 10 Dec 2020 04:28:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:38930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727006AbgLJJ2X (ORCPT ); Thu, 10 Dec 2020 04:28:23 -0500 Date: Thu, 10 Dec 2020 10:28:57 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607592463; bh=ALsu4fv9LUiXbofV9loYFZ/nlLyNOedi/phCg2wg4rA=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=S46lt3jyJFpy8iVMc0TVwN5okhxSQd+4Ux13XmKk/d5B/yn92N5eI0KVIjbVf5HFz 2QSeX0hHyxcHyDyN70FT7nVregU8s68f7/+oOdAUyF47RTV1AZdms65w1DhsfrxhIg aoyjuWvVEvklkvZB41AN0L8YT815Zx3m56mLC7Xg= From: Greg KH To: Mike Rapoport Cc: Andrew Morton , Andrea Arcangeli , Baoquan He , David Hildenbrand , Mel Gorman , Michal Hocko , Mike Rapoport , Qian Cai , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm: memblock: enforce overlap of memory.memblock and memory.reserved Message-ID: References: <20201209214304.6812-1-rppt@kernel.org> <20201209214304.6812-2-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201209214304.6812-2-rppt@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 09, 2020 at 11:43:03PM +0200, Mike Rapoport wrote: > From: Mike Rapoport > > memblock does not require that the reserved memory ranges will be a subset > of memblock.memory. > > As the result there maybe reserved pages that are not in the range of any > zone or node because zone and node boundaries are detected based on > memblock.memory and pages that only present in memblock.reserved are not > taken into account during zone/node size detection. > > Make sure that all ranges in memblock.reserved are added to memblock.memory > before calculating node and zone boundaries. > > Fixes: 73a6e474cb37 ("mm: memmap_init: iterate over memblock regions rather that check each PFN") > Reported-by: Andrea Arcangeli > Signed-off-by: Mike Rapoport > --- > include/linux/memblock.h | 1 + > mm/memblock.c | 24 ++++++++++++++++++++++++ > mm/page_alloc.c | 7 +++++++ > 3 files changed, 32 insertions(+) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.