All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes()
@ 2020-12-10 14:35 Markus Elfring
  2020-12-10 14:47   ` [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_ Greg Kroah-Hartman
  2021-02-03 11:40 ` [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes() Michael Ellerman
  0 siblings, 2 replies; 8+ messages in thread
From: Markus Elfring @ 2020-12-10 14:35 UTC (permalink / raw)
  To: linuxppc-dev, Andrew Donnellan, Arnd Bergmann, Frederic Barrat,
	Greg Kroah-Hartman
  Cc: kernel-janitors, LKML

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 10 Dec 2020 14:14:07 +0100

A local variable was used only within an if branch.
Thus move the definition for the variable “mm” into the corresponding
code block.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/misc/cxl/cxllib.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/misc/cxl/cxllib.c b/drivers/misc/cxl/cxllib.c
index 2a1783f32254..53b919856426 100644
--- a/drivers/misc/cxl/cxllib.c
+++ b/drivers/misc/cxl/cxllib.c
@@ -170,8 +170,6 @@ int cxllib_get_PE_attributes(struct task_struct *task,
 			     unsigned long translation_mode,
 			     struct cxllib_pe_attributes *attr)
 {
-	struct mm_struct *mm = NULL;
-
 	if (translation_mode != CXL_TRANSLATED_MODE &&
 		translation_mode != CXL_REAL_MODE)
 		return -EINVAL;
@@ -182,7 +180,7 @@ int cxllib_get_PE_attributes(struct task_struct *task,
 				true);
 	attr->lpid = mfspr(SPRN_LPID);
 	if (task) {
-		mm = get_task_mm(task);
+		struct mm_struct *mm = get_task_mm(task);
 		if (mm == NULL)
 			return -EINVAL;
 		/*
--
2.29.2


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes()
  2020-12-10 14:35 [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes() Markus Elfring
  2020-12-10 14:47   ` [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_ Greg Kroah-Hartman
@ 2020-12-10 14:47   ` Greg Kroah-Hartman
  1 sibling, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2020-12-10 14:47 UTC (permalink / raw)
  To: Markus Elfring
  Cc: linuxppc-dev, Andrew Donnellan, Arnd Bergmann, Frederic Barrat,
	LKML, kernel-janitors

On Thu, Dec 10, 2020 at 03:35:38PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 10 Dec 2020 14:14:07 +0100
> 
> A local variable was used only within an if branch.
> Thus move the definition for the variable “mm” into the corresponding
> code block.

You did nothing here except add a checkpatch warning :(

dropped.

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_
@ 2020-12-10 14:47   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2020-12-10 14:47 UTC (permalink / raw)
  To: Markus Elfring
  Cc: Andrew Donnellan, Arnd Bergmann, kernel-janitors, LKML,
	Frederic Barrat, linuxppc-dev

On Thu, Dec 10, 2020 at 03:35:38PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 10 Dec 2020 14:14:07 +0100
> 
> A local variable was used only within an if branch.
> Thus move the definition for the variable “mm” into the corresponding
> code block.

You did nothing here except add a checkpatch warning :(

dropped.

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes()
@ 2020-12-10 14:47   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2020-12-10 14:47 UTC (permalink / raw)
  To: Markus Elfring
  Cc: Andrew Donnellan, Arnd Bergmann, kernel-janitors, LKML,
	Frederic Barrat, linuxppc-dev

On Thu, Dec 10, 2020 at 03:35:38PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 10 Dec 2020 14:14:07 +0100
> 
> A local variable was used only within an if branch.
> Thus move the definition for the variable “mm” into the corresponding
> code block.

You did nothing here except add a checkpatch warning :(

dropped.

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes()
  2020-12-10 14:47   ` [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_ Greg Kroah-Hartman
  (?)
  (?)
@ 2020-12-10 16:04   ` Markus Elfring
  2020-12-10 18:01       ` [PATCH] cxl: Reduce scope for the variable =?UTF-8?B?4oCcbW3igJ0gaW4gY3hsbG Christophe JAILLET
  -1 siblings, 1 reply; 8+ messages in thread
From: Markus Elfring @ 2020-12-10 16:04 UTC (permalink / raw)
  To: Greg Kroah-Hartman, linuxppc-dev
  Cc: Frederic Barrat, kernel-janitors, Andrew Donnellan, Arnd Bergmann, LKML

>> A local variable was used only within an if branch.
>> Thus move the definition for the variable “mm” into the corresponding
>> code block.
>
> You did nothing here except add a checkpatch warning :(

elfring@Sonne:~/Projekte/Linux/next-patched> scripts/checkpatch.pl /home/elfring/Projekte/Bau/Linux/scripts/Coccinelle/tuning1/next/20201204/Flicken/0001-cxl-Reduce-scope-for-the-variable-mm-in-cxllib_get_P.patch
total: 0 errors, 0 warnings, 16 lines checked

Regards,
Markus

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes()
  2020-12-10 16:04   ` [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes() Markus Elfring
@ 2020-12-10 18:01       ` Christophe JAILLET
  0 siblings, 0 replies; 8+ messages in thread
From: Christophe JAILLET @ 2020-12-10 18:01 UTC (permalink / raw)
  To: Markus Elfring, Greg Kroah-Hartman; +Cc: kernel-janitors, LKML

Le 10/12/2020 à 17:04, Markus Elfring a écrit :
>>> A local variable was used only within an if branch.
>>> Thus move the definition for the variable “mm” into the corresponding
>>> code block.
>>
>> You did nothing here except add a checkpatch warning :(
> 
> elfring@Sonne:~/Projekte/Linux/next-patched> scripts/checkpatch.pl /home/elfring/Projekte/Bau/Linux/scripts/Coccinelle/tuning1/next/20201204/Flicken/0001-cxl-Reduce-scope-for-the-variable-mm-in-cxllib_get_P.patch
> total: 0 errors, 0 warnings, 16 lines checked
> 
> Regards,
> Markus
> 

Maybe:
    script/checkpatch.pl -f drivers/misc/cxl/cxllib.c

?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] cxl: Reduce scope for the variable  =?UTF-8?B?4oCcbW3igJ0gaW4gY3hsbG
@ 2020-12-10 18:01       ` Christophe JAILLET
  0 siblings, 0 replies; 8+ messages in thread
From: Christophe JAILLET @ 2020-12-10 18:01 UTC (permalink / raw)
  To: Markus Elfring, Greg Kroah-Hartman; +Cc: kernel-janitors, LKML

Le 10/12/2020 à 17:04, Markus Elfring a écrit :
>>> A local variable was used only within an if branch.
>>> Thus move the definition for the variable “mm” into the corresponding
>>> code block.
>>
>> You did nothing here except add a checkpatch warning :(
> 
> elfring@Sonne:~/Projekte/Linux/next-patched> scripts/checkpatch.pl /home/elfring/Projekte/Bau/Linux/scripts/Coccinelle/tuning1/next/20201204/Flicken/0001-cxl-Reduce-scope-for-the-variable-mm-in-cxllib_get_P.patch
> total: 0 errors, 0 warnings, 16 lines checked
> 
> Regards,
> Markus
> 

Maybe:
    script/checkpatch.pl -f drivers/misc/cxl/cxllib.c

?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes()
  2020-12-10 14:35 [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes() Markus Elfring
  2020-12-10 14:47   ` [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_ Greg Kroah-Hartman
@ 2021-02-03 11:40 ` Michael Ellerman
  1 sibling, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2021-02-03 11:40 UTC (permalink / raw)
  To: linuxppc-dev, Andrew Donnellan, Arnd Bergmann, Markus Elfring,
	Frederic Barrat, Greg Kroah-Hartman
  Cc: kernel-janitors, LKML

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

On Thu, 10 Dec 2020 15:35:38 +0100, Markus Elfring wrote:
> A local variable was used only within an if branch.
> Thus move the definition for the variable “mm” into the corresponding
> code block.
> 
> This issue was detected by using the Coccinelle software.

Applied to powerpc/next.

[1/1] cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes()
      https://git.kernel.org/powerpc/c/245a389c6ded15a7d308dbe988aec8a96e8aa8cf

cheers

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-02-03 12:40 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-10 14:35 [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes() Markus Elfring
2020-12-10 14:47 ` Greg Kroah-Hartman
2020-12-10 14:47   ` Greg Kroah-Hartman
2020-12-10 14:47   ` [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_ Greg Kroah-Hartman
2020-12-10 16:04   ` [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes() Markus Elfring
2020-12-10 18:01     ` Christophe JAILLET
2020-12-10 18:01       ` [PATCH] cxl: Reduce scope for the variable =?UTF-8?B?4oCcbW3igJ0gaW4gY3hsbG Christophe JAILLET
2021-02-03 11:40 ` [PATCH] cxl: Reduce scope for the variable “mm” in cxllib_get_PE_attributes() Michael Ellerman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.