From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1ko08q-0006px-L6 for mharc-grub-devel@gnu.org; Sat, 12 Dec 2020 03:20:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ko08o-0006oH-U9 for grub-devel@gnu.org; Sat, 12 Dec 2020 03:20:34 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:34297) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ko08k-0007UK-A7 for grub-devel@gnu.org; Sat, 12 Dec 2020 03:20:33 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id AE8847A0; Sat, 12 Dec 2020 03:20:28 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 12 Dec 2020 03:20:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=Z4DjfZeAtYEaRUnH0gG5YAGwckp z98mwM1YmREB0WCI=; b=MJFwONurTAyBXXwa6q4Mv5Jwg7WSg1RbC5K5ljbzGF6 clCbi4OSUCXBZLvwIhTJ/90sk/2hDEciP5O2mQfwv4sWSq3QifnYYzvsTEhEQRdM iO2kDeiOT8aGltIO3dhhoku6DGrcbql8YQREc3pHAx/EDcUNlCOs12LXozZJ/XjX QFdJ5ElKfHYnG07KEMASu1BnBOw8Xe2gWqgg1IhvYajRNU57rvbEEe8gBd8PQ0CB dPAcohJLss5LMtz+qgiZTzaTEd6KBzTLDQaiATcwY1/kocXXJ6TT3VYcq5KRgkj/ 4yNnMcDlGzeLgBQgnTzVzAdbFZWTCRROszJkxviopug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Z4DjfZ eAtYEaRUnH0gG5YAGwckpz98mwM1YmREB0WCI=; b=XnxlFXn/98/E12oebEUqp8 g09jsdpWVA21jdQqZ6f83+J2chFcTrbJqQ7wOHNWtaw0zVbnepkNI02v/ugC+69D fPGk8okUdnmOEZR4Pvavchf0Dp5NZuWW140+J40aczeI/dAyHL36z6J/MPauvRzQ 97WeNdkQUBC2zT+kxx/wUYBJ6QFMscenS1sHbd6vVb0ZsbA2fPVjlqEd+gxEbOgm y15eR17MB1SQrvmb3IZZBK1i05ftwYyyaYFPrml6uSlYniz7q1YVpdcsDSfjxUrJ 0J7d+D5Z4NPlxxcp4968VV+hIbb2ykC34wfcEJGdkOgjbCAu+5jVL08rSfrGbbCA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekfedguddvtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhr ihgtkhcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecuggftrfgrthhtvg hrnhepheeghfdtfeeuffehkefgffduleffjedthfdvjeektdfhhedvlefgtefgvdettdfh necukfhppeejjedrudeluddruddtrdduleegnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Received: from vm-mail (x4dbf0ac2.dyn.telefonica.de [77.191.10.194]) by mail.messagingengine.com (Postfix) with ESMTPA id A0B22108005C; Sat, 12 Dec 2020 03:20:26 -0500 (EST) Received: from localhost (ncase [10.192.0.11]) by vm-mail (OpenSMTPD) with ESMTPSA id bf9dec10 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 12 Dec 2020 08:20:25 +0000 (UTC) Date: Sat, 12 Dec 2020 09:20:24 +0100 From: Patrick Steinhardt To: Daniel Kiper Cc: Glenn Washburn , grub-devel@gnu.org Subject: Re: [PATCH v8 00/18] Cryptodisk fixes for v2.06 redux Message-ID: References: <20201210162059.g67tnm2rv3wdj7gz@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3XlULKOpzrFkU1OA" Content-Disposition: inline In-Reply-To: <20201210162059.g67tnm2rv3wdj7gz@tomti.i.net-space.pl> Received-SPF: pass client-ip=64.147.123.25; envelope-from=ps@pks.im; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Dec 2020 08:20:35 -0000 --3XlULKOpzrFkU1OA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 10, 2020 at 05:20:59PM +0100, Daniel Kiper wrote: > On Tue, Dec 08, 2020 at 04:45:31PM -0600, Glenn Washburn wrote: > > This patch series, fixes issues with v7 series. Some of those patches h= ad > > changes applied to the wrong patch. The added structure member was rena= med > > again, this time to idx. And there is an added patch that renames some = json > > index variables to note that they are such. > > > > Glenn > > > > Glenn Washburn (18): > > disk: Rename grub_disk_get_size to grub_disk_native_sectors > > misc: Add parentheses around ALIGN_UP and ALIGN_DOWN arguments > > whitespace: convert 8 spaces to tabs > > luks2: Remove unused argument in grub_error > > luks2: Make sure all fields of output argument in luks2_parse_digest() > > are written to > > luks2: Add idx member to struct grub_luks2_keyslot/segment/digest > > luks2: Use more intuitive object name instead of json index in user > > messages > > luks2: Rename json index variables to names that they are obviously > > json indexes > > luks2: Add string "index" to user strings using a json index. > > cryptodisk: Add macro GRUB_TYPE_BITS() to replace some literals > > cryptodisk: Add macros GRUB_TYPE_U_MAX/MIN(type) to replace literals > > luks2: grub_cryptodisk_t->total_sectors is the max number of device > > native sectors > > cryptodisk: Properly handle non-512 byte sized sectors > > luks2: Better error handling when setting up the cryptodisk > > luks2: Error check segment.sector_size > > mips: Enable __clzdi2() > > misc: Add grub_log2ull macro for calculating log base 2 of 64-bit > > integers > > luks2: Use grub_log2ull to calculate log_sector_size and improve > > readability >=20 > I will get all the patches except #14 and maybe some changes after that > one which does not apply due to lack of it. >=20 > Thank you for doing the work! >=20 > Daniel For what it's worth, I've also gone through all patches except 14 and added by RBs. Thanks! Patrick --3XlULKOpzrFkU1OA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl/UfUcACgkQVbJhu7ck PpT7PRAAnwQWP6txT4c3KTc7e8koiZJkNeEQozpYKmoO8FTdqCm1BgaWzYArLcwi cyrO2yD6U5baeDs6vefNORUx8VqXgC44pCxJuKKw30dCtwZRiQGxYaNPJdCFRKmZ w9P3W5Ouk1q3Epz2H4+/ZE/CBTDSMwJu0nhpcVUtvQ2gma7tpb5DLFzzPPj245xe wI7dG5R3/9DF3+/SlA8kBV+qy3Enzznr8dkWDaeH3jZ8+8aqU9i5+/FBuABP3mYJ ZyFjk1YpBBG09FFHAZ2XSWKU7abNByGW4WfLfkpOifu9+i69PFPIWIK3SbryrCMS 2bsQY8zmhchCp0DIJhrZ6BIOE9igZURRWDmvXwJV4pIMYbG/gikmRwrd7SPTWT3/ LbKYCdFby2n61XuQyI2UOPXkQXwB/4djMn3cZc/GRLImb+Ov84TI8f4cCJH3aFl2 rnBRpbJ7oq5uyuR0Gc+Sz/urpXD444J49TDh9bt5qB5ukiH9f1KC7e9H23nqE8Wh xUK5TQ8YhhMXQp339KuUMoH/wm/T/yP8gkZedfAiGY8ZCV2W1xHAPk2mfaRio3XX MzHgU7qWRMJBgZcmAUmjzHSh3ndlN6S3ftdrrGQw1I49Xl8TNJ0RK2QbxrVnDHuH hqth04aY/MhHgHBnUIl+QF+gRoFsYgsp882EQDpfPE/kT5KCUVE= =/9kW -----END PGP SIGNATURE----- --3XlULKOpzrFkU1OA--