From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D0DC4361B for ; Tue, 15 Dec 2020 21:35:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C6BE22D07 for ; Tue, 15 Dec 2020 21:35:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729028AbgLOVen (ORCPT ); Tue, 15 Dec 2020 16:34:43 -0500 Received: from mail-03.mail-europe.com ([91.134.188.129]:50940 "EHLO mail-03.mail-europe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726181AbgLOVee (ORCPT ); Tue, 15 Dec 2020 16:34:34 -0500 Date: Tue, 15 Dec 2020 21:32:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1608067980; bh=+ErT7m0bXPd7Crgokd60v7Q830jr1gZutzvXrXse6qo=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=RNh2bIvtXlOL6gQN/R751USoqvMFozgHQiHZxi/U2NP/l0P4kdbqqZTuJSF+EKgXe 93aWKnT+zsrNE/jcSav/J+kbErQDphUJKxvJFSQtDZ05Nguyc2jgbfKJPw/wGES89h OknbVP6n3NWY0CRceSWtSEMr+KI90SWgjYuT8I8s= To: Jakub Kicinski From: Lars Everbrand Cc: linux-kernel@vger.kernel.org, Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S. Miller" , netdev@vger.kernel.org Reply-To: Lars Everbrand Subject: Re: [PATCH net-next] bonding: correct rr balancing during link failure Message-ID: In-Reply-To: <20201205114513.4886d15e@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> References: <20201205114513.4886d15e@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 05, 2020 at 11:45:13AM -0800, Jakub Kicinski wrote: > Thanks for the patch! Kind words for my first attempt at this. Sorry for answering a bit late, proton-bridge is not my best friend lately. >=20 > Looking at the code in question it feels a little like we're breaking > abstractions if we bump the counter directly in get_slave_by_id. My intention was to avoid a big change, and this was the easiest way. I trust your opinion here. >=20 > For one thing when the function is called for IGMP packets the counter > should not be incremented at all. But also if packets_per_slave is not > 1 we'd still be hitting the same leg multiple times (packets_per_slave > / 2). So it seems like we should round the counter up somehow? I did not consider this case, I only test =3D1 and random. Yeah, it breaks if the counter is updated per packet in any >1 case.=20 >=20 > For IGMP maybe we don't have to call bond_get_slave_by_id() at all, > IMHO, just find first leg that can TX. Then we can restructure > bond_get_slave_by_id() appropriately for the non-IGMP case. I can have another look but my I am not confident that I am skilled enough in this area to produce a larger overhaul...=20