From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 065A4C4361B for ; Thu, 17 Dec 2020 06:27:18 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90A2D22D2C; Thu, 17 Dec 2020 06:27:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90A2D22D2C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kpmkt-0006IE-HW; Thu, 17 Dec 2020 06:27:15 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpmkr-0006Hx-Mq for linux-f2fs-devel@lists.sourceforge.net; Thu, 17 Dec 2020 06:27:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6O1PssmJXiD5G9fUigcu8UF/CqjsClUThY8ahTzPE5c=; b=ipDNnOhNjQF+5Hl7+Ai8tUsF90 TSeK7svbUVVxV0HVwQQXmb5JxqdDyN1tds2D4+DkgoVctLi+kB1DCqEBzTGZ0wh74DA0a1jn4Hyzp O5RyFzF40nuKFf9C4uKTfyq11VGvBSi8Zyamu/1x3zZCgw1l+sXeFnhwiKXr93H3asoM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6O1PssmJXiD5G9fUigcu8UF/CqjsClUThY8ahTzPE5c=; b=EN32qVo17m0NPJ0cp9AesHuZaD gy3DrU63Au61AmyzPrCw0ERWDFPoDC8YHNfPftBLvPyU/6PQWjFHY+oilfEyo+YMhRk78wab832aG rcQrb1T9stlbbh50poFXjnkR57ej5MWlvkWqsC0KVErJvYqdhhXq5oheJ0iM6yEOAFns=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kpmkn-00GyiD-98 for linux-f2fs-devel@lists.sourceforge.net; Thu, 17 Dec 2020 06:27:13 +0000 Date: Wed, 16 Dec 2020 22:26:54 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1608186415; bh=blQ9TjwzSGVLu2WJ7JajS1sME1qOEHQhDxH7XzxrnCo=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=M76Uw/Y5SCSdFGzGtff019b1daVNyBX3GI1Z+gAvdC1ZxfQq2Vf5xqDvxQqyBgY1M anTJt88QHNkAFzTWzu67r8X8qf8f5bVRX20d+uMVB59J6BybkrYSoMcDeHGzjwSeZM jF8QE5rKfb+Vb0PyUFprBGHqLADXUUn/zObT0lf1ScoMw2RxlUlMHv5NY4aWcGnRi6 /Vll/EDqWrCgIbJckZbNW8/V6OkpxeeJCIQa+renh7Ja/+vMniqNvext6Dv3PZDo9+ vc2Qv1VrPyxMxXp9s73NjV3bCFxr6NSm4FA3X/fkNL9tee2hDTyJ1NowpFMOiuzSHy 23/cpgB1asdEQ== From: Jaegeuk Kim To: "John A. Leuenhagen" Message-ID: References: <20201215015800.u37ixmukkwihmxi2@Lima-1.maple.zlima12.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201215015800.u37ixmukkwihmxi2@Lima-1.maple.zlima12.com> X-Headers-End: 1kpmkn-00GyiD-98 Subject: Re: [f2fs-dev] [PATCH] mkfs.f2fs: Fix behavior of -g option to match the man page. X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hi, On 12/14, John A. Leuenhagen via Linux-f2fs-devel wrote: > The man page states that simply specifying the -g option will use the > default Android options. However, mkfs.f2fs currently requires the user > to specify `-g android`. This makes the behavior of mkfs.f2fs match the > man page. I think we need to fix the manpage, since this requires to change all the use cases in android. :( Thanks, > > Signed-off-by: John A. Leuenhagen > --- > mkfs/f2fs_format_main.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c > index 03eb748..8db2191 100644 > --- a/mkfs/f2fs_format_main.c > +++ b/mkfs/f2fs_format_main.c > @@ -129,7 +129,7 @@ static void add_default_options(void) > > static void f2fs_parse_options(int argc, char *argv[]) > { > - static const char *option_string = "qa:c:C:d:e:E:g:hil:mo:O:rR:s:S:z:t:T:U:Vfw:"; > + static const char *option_string = "qa:c:C:d:e:E:ghil:mo:O:rR:s:S:z:t:T:U:Vfw:"; > static const struct option long_opts[] = { > { .name = "help", .has_arg = 0, .flag = NULL, .val = 'h' }, > { .name = NULL, .has_arg = 0, .flag = NULL, .val = 0 } > @@ -169,8 +169,7 @@ static void f2fs_parse_options(int argc, char *argv[]) > c.extension_list[1] = strdup(optarg); > break; > case 'g': > - if (!strcmp(optarg, "android")) > - c.defset = CONF_ANDROID; > + c.defset = CONF_ANDROID; > break; > case 'h': > mkfs_usage(); > -- > 2.26.2 > > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel