From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 0/3] inotify tests for v5.9 regression
Date: Fri, 18 Dec 2020 10:01:47 +0100 [thread overview]
Message-ID: <X9xv+6e0tJgVDN/9@pevik> (raw)
In-Reply-To: <20201218070631.1182292-1-amir73il@gmail.com>
Hi Amir,
> Hi Petr,
> Here is the test for the other v5.9 regression that I mentioned earlier.
> The fix commit has just been merged to master.
Thanks for your patch, LGTM. I'll probably merge it later today.
> History:
> Originally, inotify10 was written to cover a bug that was detected during
> the review of the fsnotify changes for v5.9, but was not merged to v5.9.
> Later, I wrote test case #3 to cover another bug that was merged to v5.9.
> While testing the v5.9-bug-fix in linux-next, Hugh Dickins reported [1]
> a bug introduced by the v5.9-bug-fix, so I added two more test cases
> to cover the bug-in-the-bug-fix.
> The bug-in-the-bug-fix was fixed before the v5.9-bug-fix was merged.
> Long story short, the only test case expected to fail is test case #3 on
> kernel >= v5.9 and now fixed in master :-)
Correct, it fails on my openSUSE 5.10.0-rc5 kernel.
I tested it on someold kernels (patched 4.4; 4.9) and on some newer ones
(5.8.14 and on current devel SLES kernel).
BTW interesting (nothing to be fixed in the test) that second commit slower down
on newer kernels (0,200s), while on old kernels is the same (0.010s).
Kind regards,
Petr
> Thanks,
> Amir.
> [1] https://lore.kernel.org/linux-fsdevel/alpine.LSU.2.11.2012101507080.1100@eggly.anvils/
> Amir Goldstein (3):
> syscalls/inotify10: Generalize for more test cases
> syscalls/inotify10: Add test cases with two groups
> syscalls/inotify10: Test two inotify groups with parent and child
> watches
> testcases/kernel/syscalls/inotify/inotify10.c | 126 ++++++++++++++----
> 1 file changed, 98 insertions(+), 28 deletions(-)
next prev parent reply other threads:[~2020-12-18 9:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 7:06 [LTP] [PATCH 0/3] inotify tests for v5.9 regression Amir Goldstein
2020-12-18 7:06 ` [LTP] [PATCH 1/3] syscalls/inotify10: Generalize for more test cases Amir Goldstein
2020-12-18 8:32 ` Petr Vorel
2020-12-18 7:06 ` [LTP] [PATCH 2/3] syscalls/inotify10: Add test cases with two groups Amir Goldstein
2020-12-18 8:36 ` Petr Vorel
2020-12-18 7:06 ` [LTP] [PATCH 3/3] syscalls/inotify10: Test two inotify groups with parent and child watches Amir Goldstein
2020-12-18 8:53 ` Petr Vorel
2020-12-18 9:01 ` Petr Vorel [this message]
2020-12-18 16:23 ` [LTP] [PATCH 0/3] inotify tests for v5.9 regression Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9xv+6e0tJgVDN/9@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.