From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 585EEC4361B for ; Fri, 18 Dec 2020 11:28:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23025224D4 for ; Fri, 18 Dec 2020 11:28:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725947AbgLRL2c (ORCPT ); Fri, 18 Dec 2020 06:28:32 -0500 Received: from mx2.suse.de ([195.135.220.15]:33128 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbgLRL2b (ORCPT ); Fri, 18 Dec 2020 06:28:31 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5D1D7AC7B; Fri, 18 Dec 2020 11:27:50 +0000 (UTC) Date: Fri, 18 Dec 2020 12:27:48 +0100 From: Petr Vorel To: Mimi Zohar Cc: ltp@lists.linux.it, Mimi Zohar , Lakshmi Ramasubramanian , Tushar Sugandhi , linux-integrity@vger.kernel.org Subject: Re: [PATCH v5 1/4] IMA: Move get_algorithm_digest(), set_digest_index() to ima_setup.sh Message-ID: Reply-To: Petr Vorel References: <20201214221946.6340-1-pvorel@suse.cz> <20201214221946.6340-2-pvorel@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org Hi Mimi, > Hi Petr, > Thank you! > On Mon, 2020-12-14 at 23:19 +0100, Petr Vorel wrote: > > To be reusable by more tests (preparation for next commit). > > Call set_digest_index() inside get_algorithm_digest() if needed > > instead of expecting get_algorithm_digest() caller to call > > set_digest_index() before. > For the existing builtin templates, the algorithm/digest field is > consistent. With support for per policy rule template formats, there > isn't necessarily a single template format for the entire list. > In the future "set_digest_index" might need to be renamed to > "get_digest_index" and the lookup done for each line. Thanks for info, noted as TODO. Policy example would speedup fixing. Kind regards, Petr > > Signed-off-by: Petr Vorel > Reviewed-by: Mimi Zohar From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Fri, 18 Dec 2020 12:27:48 +0100 Subject: [LTP] [PATCH v5 1/4] IMA: Move get_algorithm_digest(), set_digest_index() to ima_setup.sh In-Reply-To: References: <20201214221946.6340-1-pvorel@suse.cz> <20201214221946.6340-2-pvorel@suse.cz> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Mimi, > Hi Petr, > Thank you! > On Mon, 2020-12-14 at 23:19 +0100, Petr Vorel wrote: > > To be reusable by more tests (preparation for next commit). > > Call set_digest_index() inside get_algorithm_digest() if needed > > instead of expecting get_algorithm_digest() caller to call > > set_digest_index() before. > For the existing builtin templates, the algorithm/digest field is > consistent. With support for per policy rule template formats, there > isn't necessarily a single template format for the entire list. > In the future "set_digest_index" might need to be renamed to > "get_digest_index" and the lookup done for each line. Thanks for info, noted as TODO. Policy example would speedup fixing. Kind regards, Petr > > Signed-off-by: Petr Vorel > Reviewed-by: Mimi Zohar